]> git.koha-community.org Git - koha.git/commit
Bug 26990: (bug 22284 follow-up) Prevent hold to be placed if cannot be transferred
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 11 Nov 2020 13:55:27 +0000 (14:55 +0100)
committerLucas Gass <lucas@bywatersolutions.com>
Mon, 16 Nov 2020 22:45:36 +0000 (22:45 +0000)
commite0ec375ee31270a8ee123e116355086ad58fa36d
treec9764907f0dac20151f19f8e34a81ee58f5c69d5
parent8ea97143a53baf145fe2bb707760a4631a18096a
Bug 26990: (bug 22284 follow-up) Prevent hold to be placed if cannot be transferred

There is a missing parameter to CanItemBeReserved, we need to know if
the hold can be placed at a given pickup library.

Test plan:
1 - Set preferences:
     UseBranchTransferLimits: enforce
     BranchTransferLimitsType: itype
     AllowHoldPolicyOverride: Don't allow
2 - Set Centerville 'Book' items to not be allowed to transfer to any other library
3 - Make sure Hold policy is set to 'any library'
4 - Find a record with a Centerville item and other items
5 - Attempt to place an item level hold on the Centerville item (with a
pickup library different than Centerville)
=> Without this patch you are taken to the holds list, but your hold is not placed
Nothing indicates why hold has failed
=> With this patch you cannot select the item from Centerville
"Cannot be transferred to pickup library"

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit fbd0bbf98f574a7eb804673978a198eea6fdd798)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
reserve/request.pl