Bug 9065 - set correct permission for upload local cover image
authorFridolyn SOMERS <fridolyn.somers@biblibre.com>
Wed, 9 Jan 2013 09:40:24 +0000 (10:40 +0100)
committerJared Camins-Esakov <jcamins@cpbibliography.com>
Sun, 13 Jan 2013 13:32:18 +0000 (08:32 -0500)
commite81cc3d1d305cbca3c0b63310a9f0928bae4183d
treecfb61f252e65ce9b3e4b9a615aacc2fa993b9c21
parente901ae15de6717f8594bd80ecfb0c5e8a23b8af5
Bug 9065 - set correct permission for upload local cover image

This patch fixes a problem where if a staff user has the
upload_local_cover_images permission (and is not a superlibrarian
and does not have all of the tools permissions), trying to use the
"Tools -> Upload local cover image" will fail with "You do not have
permissions [...]".

To test after applying the patch:

- Create a staff uesr that has just the catalogue and
  upload_local_cover_images permission.
- Log in as that staff user.
- Go to "Tools -> Upload local cover image".
- Verify that one is given the form to upload a cover image.
- Without the patch, one will be presented with the login
  form instead.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
mysql> select * from permissions where code="upload_cover_images";
Empty set (0.00 sec)

mysql> select * from permissions where code="upload_local_cover_images";
+------------+---------------------------+---------------------------+
| module_bit | code                      | description               |
+------------+---------------------------+---------------------------+
|         13 | upload_local_cover_images | Upload local cover images |
+------------+---------------------------+---------------------------+
1 row in set (0.00 sec)

"git grep upload_cover_images" returns 0 result.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
tools/upload-cover-image.pl