Bug 19581: Remove 'split' option from Catmandu fixes for marc
authorNick Clemens <nick@bywatersolutions.com>
Sun, 5 Nov 2017 01:51:39 +0000 (01:51 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 9 Apr 2018 19:15:17 +0000 (16:15 -0300)
commitec0ea67a43455b94a9d8bd3cf4ba8f68d1678e4a
tree31cf7d9836000d39edfc83c48fd0d9f06cc68ce9
parent0798dcb0baef1cb2bd391188b49fee3ff270370a
Bug 19581: Remove 'split' option from Catmandu fixes for marc

This option in combination with append seems to add null entries in the indexes
for fields that don't exist. These fields then affect sorting. Removing it solves
the issue

To test:
1 - Have an ES setup
2 - Catalog and index some records
3 - View a record in ES:
    curl 'localhost:9200/koha_kohadev_biblios/data/4?pretty=yes'
4 - Note there are 'null' entries in the indexes, save this result for
comparison
5 - Apply patch
6 - Reindex, amking sure to delete existing indexes
    perl misc/search_tools/rebuild_elastic_search.pl -d
7 - View the record again
8 - Note the null entries are removed
9 - Note indices are otherwise intact

Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/SearchEngine/Elasticsearch.pm