Bug 16850: Remove C4::Members::IsMemberBlocked
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 4 Jul 2016 11:21:19 +0000 (12:21 +0100)
committerBrendan Gallagher <brendan@bywatersolutions.com>
Tue, 11 Oct 2016 13:20:19 +0000 (13:20 +0000)
commitee719cf10cf2f1c81de485228a98fc33e0f0c81b
tree8a91011b50ae391bf93f2265ec3be1c76e3a4e73
parent807ee1daa02f4bafe8da5689e74d76e997e7b5b8
Bug 16850: Remove C4::Members::IsMemberBlocked

This subroutine is only called once and can be replaced with a call to
is_debarred and has_overdues.
Note that prior to this patch, IsMemberBlocked copy/paste code from
HasOverdues, which did not make sense.

Test plan:
Debar a patron and make sure he is not able to checkout (the librarian
is asked to overwrite if OverduesBlockCirc is set to 'confirmation')
Remove the debarment and add overdues to this patron, same as
previously, the checkout should be blocked

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
C4/Circulation.pm
C4/Members.pm