]> git.koha-community.org Git - koha.git/log
koha.git
13 years agoFix for Bug 5051, Renewal due date doesn't always show on patron Checkout tab
Owen Leonard [Sat, 13 Nov 2010 03:00:26 +0000 (22:00 -0500)]
Fix for Bug 5051, Renewal due date doesn't always show on patron Checkout tab

Display of the renewal date footer in the template was conditional upon
the existence of checkouts from today.

In order to fix this bug it was necessary to repeat the markup for the
table footer twice in the template, so I created an include file for it.
The same include file can now be used in moremember.tmpl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 5269 - link to patron edit form when editing turned off
Owen Leonard [Fri, 12 Nov 2010 21:12:11 +0000 (16:12 -0500)]
Fix for Bug 5269 - link to patron edit form when editing turned off

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5281' into kcmaster
Chris Cormack [Mon, 29 Nov 2010 19:17:40 +0000 (08:17 +1300)]
Merge remote branch 'kc/new/bug_5281' into kcmaster

13 years agoFix for Bug 5281, "Check in" then "Renew" checkboxes checked in the same time
Owen Leonard [Fri, 12 Nov 2010 20:59:47 +0000 (15:59 -0500)]
Fix for Bug 5281, "Check in" then "Renew" checkboxes checked in the same time

This fix corrects the behavior of the checkboxes whether the user clicks the
checkbox itself or the <td> around it. Tested on a PC in Firefox 3.6, Chrome,
Safari 5, and IE 8.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/enh/bug_5430' into kcmaster
Chris Cormack [Mon, 29 Nov 2010 18:02:18 +0000 (07:02 +1300)]
Merge remote branch 'kc/new/enh/bug_5430' into kcmaster

13 years agoBug 5430: Follow-up, fixes error message when no 001 exists
Katrin Fischer [Sun, 28 Nov 2010 12:40:36 +0000 (13:40 +0100)]
Bug 5430: Follow-up, fixes error message when no 001 exists

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 5217 incrementing db version number
Chris Cormack [Mon, 29 Nov 2010 17:57:09 +0000 (06:57 +1300)]
bug 5217 incrementing db version number

13 years agobug 5127: database update to add the suggestion notification templates
Galen Charlton [Sat, 13 Nov 2010 21:50:30 +0000 (16:50 -0500)]
bug 5127: database update to add the suggestion notification templates

Being especially careful to not scribble over any ones
that the library might have already defined.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 5127: sample notice templates for suggestions
Galen Charlton [Sat, 13 Nov 2010 21:35:43 +0000 (16:35 -0500)]
bug 5127: sample notice templates for suggestions

* supply default suggestion status change email
  templates.
* remove the deprecated mail_suggestion_*.tmpl files

There are a couple suggestion statuses referred to
in the code and suggestion management page that currently
do not have notice templates defined: ASK and CHECKED.  These
seem to be internal, so perhaps default message templates
are not needed for these.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 4211: ensure that suggestion emails have full details
Galen Charlton [Sat, 13 Nov 2010 21:27:47 +0000 (16:27 -0500)]
bug 4211: ensure that suggestion emails have full details

Because of how the ModFoo routines work, if you are only
changing selected columns but are also using the change
as a trigger to place a message in the queue, you need
to fetch the full row before generating the message.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 4211: more fixes to suggestion letter template handling
Galen Charlton [Sat, 13 Nov 2010 20:43:27 +0000 (15:43 -0500)]
bug 4211: more fixes to suggestion letter template handling

* Now displays the correct list of fields to choose
  for suggestion letters.
* Clean up mixture of old and new column selection code
  introduced in commit 88bb1b63, thereby restoring
  the intent of the patch for bug 3522.
* Enable suggestion library to be used in suggestion
  letter templates

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBug 4211: This patch should provide a working way to send out mail from suggestions
Chris Cormack [Thu, 12 Aug 2010 21:44:46 +0000 (09:44 +1200)]
Bug 4211: This patch should provide a working way to send out mail from suggestions

Your suggestion notices template needs to contain things like
<<suggestions.title>>
<<suggestions.author>>
etc

Squashed commit of the following:

commit 3f4278bbe8d4c68be9f72d50e1eef6a411dc873d
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Fri Aug 13 09:41:34 2010 +1200

    bug 4211 parsing the letter before we enqueue it

commit ecdc0ff34c1aa9b96b68d541423ca693e2d63e67
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Fri Aug 13 09:32:09 2010 +1200

    Changing the query to fetch suggestions data, this is needed for suggestion mail to be sent

commit ece11d015b945ce119cf7cbc5e2563f4bc8aecf9
Author: Owen Leonard <oleonard@myacpl.org>
Date:   Thu Aug 12 12:36:26 2010 -0400

    Fix for Bug 4211, Acquisitions actions on suggestions don't generate email

    Assuming 1) The patch for Bug 5126 is approved and 2) Suggestions
    notices are added by hand (or from default sql--see Bug 5127) this
    correction should get suggestions notices properly enqueued.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
commit 5c3bbe7d557b1994be72518746217fc6fc4e5b83
Author: Owen Leonard <oleonard@myacpl.org>
Date:   Thu Aug 12 12:27:33 2010 -0400

    Fix for Bug 5126 - Suggestions module missing from "add notice" form

    - Adding "suggestions" entry
    - Re-ordering options in alphabetical order

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBug 5430: Add Control number as option to OPACSearchForTitleIn
Katrin Fischer [Wed, 24 Nov 2010 16:35:43 +0000 (11:35 -0500)]
Bug 5430: Add Control number as option to OPACSearchForTitleIn

Makes {CONTROLNUMBER} available as new placeholder in
system preference OPACSearchForTitleIn.

{CONTROLNUMBER} will be replaced by the number in tag 001.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5175' into kcmaster
Chris Cormack [Sat, 20 Nov 2010 21:44:16 +0000 (10:44 +1300)]
Merge remote branch 'kc/new/bug_5175' into kcmaster

13 years agoBug 5175: Publisher link breaks display, if no publisher exists
Katrin Fischer [Sat, 20 Nov 2010 13:00:01 +0000 (14:00 +0100)]
Bug 5175: Publisher link breaks display, if no publisher exists

If there is no publisher the empty publisher link will break the record display
in staff and intranet.

This patch adds a check for existence of subfield b.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5004' into kcmaster
Chris Cormack [Thu, 18 Nov 2010 20:53:19 +0000 (09:53 +1300)]
Merge remote branch 'kc/new/bug_5004' into kcmaster

13 years agoAnother bug 5004 fix, this time for road types
Owen Leonard [Mon, 15 Nov 2010 23:13:32 +0000 (18:13 -0500)]
Another bug 5004 fix, this time for road types

The road types interface didn't block deletion of road
types in use, but the script included the same queries
that cities.pl did, as if it intended to.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 5004, Don't block deletion of cities when instances exist in borrowers...
Owen Leonard [Mon, 15 Nov 2010 13:09:11 +0000 (08:09 -0500)]
Fix for Bug 5004, Don't block deletion of cities when instances exist in borrowers table

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 4440: Fixing template syntax errors
Chris Cormack [Thu, 18 Nov 2010 02:29:04 +0000 (15:29 +1300)]
Bug 4440: Fixing template syntax errors

13 years agoBug 4440 Follow-up for English typography and alignment
Frédéric Demians [Tue, 16 Nov 2010 07:33:10 +0000 (08:33 +0100)]
Bug 4440 Follow-up for English typography and alignment

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 4440 Layout tweaking follow-up patch
Koustubha Kale [Tue, 16 Nov 2010 07:33:09 +0000 (08:33 +0100)]
Bug 4440 Layout tweaking follow-up patch

Couple of tweaks to borders and Name.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 4440: Revised combined patch to print fee receipts and invoices
Koustubha Kale [Tue, 16 Nov 2010 07:33:08 +0000 (08:33 +0100)]
Bug 4440: Revised combined patch to print fee receipts and invoices

This patch adds a small enhancement to allow printing of Fees  / Fines
receipts from the Fines page.

Patch adds print links to the Fines page next to Fines or Receipts
transactions.

Clicking on the link will pop a new window and will print that with
total outstanding as on date.

You can edit koha-tmpl/intranet-tmpl/prog/en/css/printreceiptinvoice.css
to better control printing this type of material.

18-Oct-2010 Changed template and script names to match. Corrected
invalid markup in the templates.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5412 double quotes break coins and thus search results in some scenarios
Tomás Cohen Arazi [Wed, 17 Nov 2010 14:43:10 +0000 (09:43 -0500)]
Bug 5412 double quotes break coins and thus search results in some scenarios

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5204 Followup
Frédéric Demians [Mon, 15 Nov 2010 23:11:09 +0000 (18:11 -0500)]
Bug 5204 Followup

- Typo
- Duplicate 955 tag

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 5204: Unimarc XSLT, from French to English.
Zeno0 Tajoli [Mon, 15 Nov 2010 17:47:27 +0000 (18:47 +0100)]
bug 5204: Unimarc XSLT, from French to English.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoGerman and italian language updates
Chris Cormack [Wed, 17 Nov 2010 22:28:52 +0000 (11:28 +1300)]
German and italian language updates

13 years agoMerge remote branch 'kc/new/bug_5066' into kcmaster
Chris Cormack [Wed, 17 Nov 2010 20:43:25 +0000 (09:43 +1300)]
Merge remote branch 'kc/new/bug_5066' into kcmaster

13 years agoBug 5066 (Log timestamp consistently in _session_log)
Marcel de Rooy [Wed, 17 Nov 2010 12:18:00 +0000 (12:18 +0000)]
Bug 5066 (Log timestamp consistently in _session_log)

Small fix with thanks to Galen.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 2122 follow-up for authorities editor
Owen Leonard [Mon, 15 Nov 2010 23:19:26 +0000 (18:19 -0500)]
Bug 2122 follow-up for authorities editor

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 2122, Grayed out Fields not always visible
Owen Leonard [Mon, 15 Nov 2010 13:02:48 +0000 (08:02 -0500)]
Fix for Bug 2122, Grayed out Fields not always visible

- Adding "readonly" class to readonly fields to guarantee
  that readonly state is indicated visually
- Adding "locked" icon to the background of readonly
  fields for additional visual feedback

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 5152 - confirm buttons different styles on lists
Owen Leonard [Tue, 16 Nov 2010 23:33:49 +0000 (18:33 -0500)]
Fix for Bug 5152 - confirm buttons different styles on lists

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 5037 - If patron category is empty it shouldn't show
Owen Leonard [Tue, 16 Nov 2010 23:43:43 +0000 (18:43 -0500)]
Fix for Bug 5037 - If patron category is empty it shouldn't show

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 3013, Value builder for 006 and 008 need choices for all format types
Owen Leonard [Tue, 16 Nov 2010 23:52:36 +0000 (18:52 -0500)]
Fix for Bug 3013, Value builder for 006 and 008 need choices for all format types

This partial fix adds a complete list of values for 006/00, "Form of material,"
following the list found here: http://www.loc.gov/marc/bibliographic/bd006.html

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 4074 Fix fail to parse simple qualified search
Colin Campbell [Wed, 17 Nov 2010 00:33:38 +0000 (19:33 -0500)]
Bug 4074 Fix fail to parse simple qualified search

Searches such as au,phr and kw,wrdl were passing through the regexes
that should replace colon with equals
add wrdl and phr
use trn so not just rtrn is spotted
Where we were checking for multiple spaces specify that in the
regex not just two spaces

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBrooke caught my april fools trick, its not 20004 yet!
Chris Cormack [Mon, 15 Nov 2010 12:55:43 +0000 (07:55 -0500)]
Brooke caught my april fools trick, its not 20004 yet!

Ok it wasn't an april fools trick, but just a typo, april fools trick
sounds better though right?

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/enh/bug_4866' into kcmaster
Chris Cormack [Mon, 15 Nov 2010 08:34:39 +0000 (21:34 +1300)]
Merge remote branch 'kc/new/enh/bug_4866' into kcmaster

13 years agobug 4866 follow-up - minor code formatting cleanup
Galen Charlton [Sat, 13 Nov 2010 17:05:47 +0000 (12:05 -0500)]
bug 4866 follow-up - minor code formatting cleanup

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 4866 for master (Enable Change event for item plugins)
Marcel de Rooy [Sat, 13 Nov 2010 17:05:46 +0000 (12:05 -0500)]
Bug 4866 for master (Enable Change event for item plugins)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoCorrected patch for Bug 4520, facets "show more" doesn't work
Owen Leonard [Sat, 13 Nov 2010 04:22:24 +0000 (23:22 -0500)]
Corrected patch for Bug 4520, facets "show more" doesn't work

Re-doing Nahuel's fix so that it applies to master

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 4913 - Budget pages should show currency name instead of symbol
Owen Leonard [Sat, 13 Nov 2010 03:53:23 +0000 (22:53 -0500)]
Fix for Bug 4913 - Budget pages should show currency name instead of symbol

This patch adds a new include file to handle the display of the active
currency name and a warning if no currency is active.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 4912 - After editing private list redirect to private lists
Owen Leonard [Sat, 13 Nov 2010 03:48:41 +0000 (22:48 -0500)]
Fix for Bug 4912 - After editing private list redirect to private lists

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 5175, XSL view doesn't link publisher name to search
Owen Leonard [Fri, 12 Nov 2010 22:03:42 +0000 (23:03 +0100)]
Fix for Bug 5175, XSL view doesn't link publisher name to search

Fixes the doubled up display of the publisher.

This patch fixes the bug in both the OPAC and staff client

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 5210, back button on batch modification result page useless
Owen Leonard [Fri, 12 Nov 2010 20:58:00 +0000 (21:58 +0100)]
Fix for Bug 5210, back button on batch modification result page useless

I can't see any good use for a back button here, so I'm taking it out.

An improvement might be to build in a method to resubmit the same batch
of barcodes/item numbers again so that you could make additional
changes to the same set.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5381' into kcmaster
Chris Cormack [Sun, 14 Nov 2010 09:27:33 +0000 (22:27 +1300)]
Merge remote branch 'kc/new/bug_5381' into kcmaster

13 years agoBug 5381 - Fines in notices prints always 0.00
Chris Nighswonger [Fri, 12 Nov 2010 15:30:45 +0000 (16:30 +0100)]
Bug 5381 - Fines in notices prints always 0.00

This was due to passing off the biblionumber to GetFines rather than the itemnumber.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoAdditional fix for Bug 4423 - Staff Client XSLT is just a copy of the OPAC one
Owen Leonard [Sat, 13 Nov 2010 20:00:22 +0000 (15:00 -0500)]
Additional fix for Bug 4423 - Staff Client XSLT is just a copy of the OPAC one

- Adding "Lists that include this title" links
 - Also correcting minor XHTML error in the same section of opac-detail.tmpl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_4498' into kcmaster
Chris Cormack [Sat, 13 Nov 2010 20:42:23 +0000 (09:42 +1300)]
Merge remote branch 'kc/new/bug_4498' into kcmaster

13 years agobug 5400: new test case to find files with merge conflict markers
Galen Charlton [Sat, 13 Nov 2010 14:36:15 +0000 (09:36 -0500)]
bug 5400: new test case to find files with merge conflict markers

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 4498 - Acq always shows '1 suggestions waiting'
Owen Leonard [Tue, 7 Sep 2010 13:48:03 +0000 (15:48 +0200)]
Fix for Bug 4498 - Acq always shows '1 suggestions waiting'

- Removing 'suggestions waiting' link from left-hand menu. A plain
  'suggestions' link is still shown if suggestions are enabled.
- Putting back the 'pending suggestions' box that used to appear
  on the Acquisitions home page. This will show, with a count
  of pending suggestions, only if suggestions are turned on and
  there are pending suggestions.

Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoRemoving merge commit
Chris Cormack [Sat, 13 Nov 2010 16:40:55 +0000 (05:40 +1300)]
Removing merge commit

13 years agobug 4359: make other pages in the OPAC respect noItemTypeImages
Galen Charlton [Sat, 13 Nov 2010 03:41:32 +0000 (22:41 -0500)]
bug 4359: make other pages in the OPAC respect noItemTypeImages

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 4359 follow-up: noItemTypeImages should just control image display
Galen Charlton [Sat, 13 Nov 2010 03:41:31 +0000 (22:41 -0500)]
bug 4359 follow-up: noItemTypeImages should just control image display

Tweaked so that the item type column is always displayed in the
checkout history in the OPAC; noItemTypeImages now just controls
whether the icon displays.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 4359, noItemTypeImages not active in OPAC
Owen Leonard [Sat, 13 Nov 2010 03:41:30 +0000 (22:41 -0500)]
Fix for Bug 4359, noItemTypeImages not active in OPAC

- Auth.pm put the noItemTypeImages preference under "intranet only."
  Moved it to "OPAC or intranet."
- Added check for the preference on the OPAC advanced search page.
- Improved logic for displaying images on the reading history page.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5396: New system preference UseTablesortForCirc
Owen Leonard [Fri, 12 Nov 2010 20:54:50 +0000 (15:54 -0500)]
Bug 5396: New system preference UseTablesortForCirc

This system preference allows the librarian to toggle on or off whether the JQuery tablesort is used on the
circ/circulation.pl page.  For patrons with many checkouts, this sort may cause very slow page loading (and
therefore slow circulation transaction time), depending on the browser and local machine used.  Staff can
still see a sortable list of current checkouts on the members/moremember.pl page.

My revision prevents the template from including *any* tablesorter code if the
preference is feature is turned off: both the circulation list and
the holds list will have no jQuery tablesorter.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 3271, Missing message when adding to a list with no items selected
Owen Leonard [Sat, 13 Nov 2010 04:16:56 +0000 (23:16 -0500)]
Fix for Bug 3271, Missing message when adding to a list with no items selected

There is no visible Lists button to "attach" our warning to
as there is in the OPAC, so warning message is displayed via
a javascript alert.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoPartial fix for Bug 4924, Public/Internal notes missing in staff normal view
Owen Leonard [Sat, 13 Nov 2010 04:28:00 +0000 (23:28 -0500)]
Partial fix for Bug 4924, Public/Internal notes missing in staff normal view

This fix adds only public notes. A div is added as a hook for styling

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoFix for Bug 4933, Link to subfield's edit tab from subfield structure admin
Owen Leonard [Sat, 13 Nov 2010 04:33:54 +0000 (23:33 -0500)]
Fix for Bug 4933, Link to subfield's edit tab from subfield structure admin

- Also corrects framework display in the case of the default

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 5393 [SIGNED-OFF]: add test case to check well-formedness of XML/XSLT files
Galen Charlton [Fri, 12 Nov 2010 14:10:37 +0000 (15:10 +0100)]
bug 5393 [SIGNED-OFF]: add test case to check well-formedness of XML/XSLT files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5059' into kcmaster
Chris Cormack [Fri, 12 Nov 2010 22:33:45 +0000 (11:33 +1300)]
Merge remote branch 'kc/new/bug_5059' into kcmaster

13 years agoMerge remote branch 'kc/new/bug_5058' into kcmaster
Chris Cormack [Fri, 12 Nov 2010 22:33:41 +0000 (11:33 +1300)]
Merge remote branch 'kc/new/bug_5058' into kcmaster

13 years agoBug 5059: Inconsistent use of ordering price and list price in vendor form
Katrin Fischer [Fri, 12 Nov 2010 20:41:51 +0000 (15:41 -0500)]
Bug 5059: Inconsistent use of ordering price and list price in vendor form

Changes Ordering price to List price and make spelling more consistent.

Patch originally send for 3.2, still applied to HEAD without conflicts.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBUG 5058: small layout correction of vendor form
Katrin Fischer [Fri, 12 Nov 2010 20:24:04 +0000 (15:24 -0500)]
BUG 5058: small layout correction of vendor form

Rebased to HEAD, should also apply to 3.2

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_4979' into kcmaster
Chris Cormack [Fri, 12 Nov 2010 17:47:45 +0000 (06:47 +1300)]
Merge remote branch 'kc/new/bug_4979' into kcmaster

13 years agoMerge remote branch 'kc/new/bug_5392' into kcmaster
Chris Cormack [Fri, 12 Nov 2010 17:47:26 +0000 (06:47 +1300)]
Merge remote branch 'kc/new/bug_5392' into kcmaster

13 years agoBug 5392 Initialize vars used in building url strings
Colin Campbell [Fri, 12 Nov 2010 12:35:47 +0000 (07:35 -0500)]
Bug 5392 Initialize vars used in building url strings

If no failures are to be added to the to the strings for redirect
the corresponding variables are undefined causing warnings
to be logged. Initialize them so that the error log is not
being filled with trivia.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 4305: Add test case for ISBN-13 to ISBN-10 conversion
Colin Campbell [Fri, 12 Nov 2010 12:35:46 +0000 (07:35 -0500)]
Bug 4305: Add test case for ISBN-13 to ISBN-10 conversion

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 4979: Acq: input fields for new record are too short
Katrin Fischer [Fri, 12 Nov 2010 12:35:45 +0000 (07:35 -0500)]
Bug 4979: Acq: input fields for new record are too short

Patch rebased to HEAD, should also apply to 3.2

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 5389: mark Business::ISBN as a required dependency
Galen Charlton [Thu, 11 Nov 2010 15:26:16 +0000 (10:26 -0500)]
bug 5389: mark Business::ISBN as a required dependency

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_4305' into kcmaster
Chris Cormack [Thu, 11 Nov 2010 21:47:38 +0000 (10:47 +1300)]
Merge remote branch 'kc/new/bug_4305' into kcmaster

13 years agoBug 5385 - Fixing an error that crept in with the POD cleanup
Chris Cormack [Thu, 11 Nov 2010 21:38:42 +0000 (10:38 +1300)]
Bug 5385 - Fixing an error that crept in with the POD cleanup

13 years agoBug 5385 - Fixing an error that crept in with the POD cleanup
Chris Cormack [Thu, 11 Nov 2010 21:38:42 +0000 (10:38 +1300)]
Bug 5385 - Fixing an error that crept in with the POD cleanup

13 years agobug 4305: add a couple test cases for _isbn_cleanup
Galen Charlton [Thu, 11 Nov 2010 14:43:47 +0000 (09:43 -0500)]
bug 4305: add a couple test cases for _isbn_cleanup

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 4305 Improve code flow
Colin Campbell [Thu, 11 Nov 2010 14:02:13 +0000 (09:02 -0500)]
Bug 4305 Improve code flow

Use the ISBN Object's method to format the string
rather than add extra code to do it
Clean up the code flow for clarity
Benchmarking shows its a bit faster too
Don't add to the number of Test::Perl::Critic warnings
 for no benefit

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5385: POD Cleanups (part 2)
Andrew Elwell [Thu, 11 Nov 2010 13:18:47 +0000 (08:18 -0500)]
Bug 5385: POD Cleanups (part 2)

More podchecker cleanups to eliminate warnings / errors

Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5385: POD Cleanups (part 1)
Andrew Elwell [Thu, 11 Nov 2010 13:18:46 +0000 (08:18 -0500)]
Bug 5385: POD Cleanups (part 1)

working through the master branch to eliminate all
podchecker warnings/errors

Actual improvement to the quality of the POD will
come later (hopefully with assistance of others)

Signed-off-by: Andrew Elwell <Andrew.Elwell@gmail.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5112: Organisation does not show links to professionals
Katrin Fischer [Thu, 11 Nov 2010 12:39:32 +0000 (07:39 -0500)]
Bug 5112: Organisation does not show links to professionals

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5386' into kcmaster
Chris Cormack [Thu, 11 Nov 2010 17:41:25 +0000 (06:41 +1300)]
Merge remote branch 'kc/new/bug_5386' into kcmaster

13 years agobug 5386: remove dep on Path::Class from t/00-load.t
Galen Charlton [Thu, 11 Nov 2010 13:30:13 +0000 (08:30 -0500)]
bug 5386: remove dep on Path::Class from t/00-load.t

File::Spec is a core module, Path::Class isn't; not yet
worth adding a new dependency.

Also some minor whitepace cleanup.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5105' into kcmaster
Chris Cormack [Thu, 11 Nov 2010 08:33:48 +0000 (21:33 +1300)]
Merge remote branch 'kc/new/bug_5105' into kcmaster

13 years agoBug 5105 Regression test for switch statement
Frédéric Demians [Thu, 11 Nov 2010 08:11:00 +0000 (09:11 +0100)]
Bug 5105 Regression test for switch statement

Add a test identifying Perl scripts and modules using switch statements.
This test file follow Chris pre-hook naming convention in order to be
triggered for patch submissions.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoTest modules compile
Chris Cormack [Thu, 11 Nov 2010 08:06:00 +0000 (09:06 +0100)]
Test modules compile

Script to test modules compile, when used with a pre-commit hook this
can test before a commit

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/master' into new/bug_5105
Chris Cormack [Wed, 10 Nov 2010 22:33:10 +0000 (11:33 +1300)]
Merge remote branch 'kc/master' into new/bug_5105

Conflict fixed

Conflicts:
opac/opac-detail.pl

13 years agoBug 5105 - Remove use of depreciated Switch module
Colin Campbell [Wed, 8 Sep 2010 13:16:32 +0000 (14:16 +0100)]
Bug 5105 - Remove use of depreciated Switch module

Use of switch generates errors in perl 12 and above
Replaced uses of the Switch module by if- else constructs
Removed some mixed space+tab indentation around these where
it generated visual confusion

As of perl 10 you can use given/when constructs but this is not
supported in earlier perls.

13 years agoFix bug on opac-detail.pl with switch statement
Frédéric Demians [Wed, 10 Nov 2010 22:00:54 +0000 (23:00 +0100)]
Fix bug on opac-detail.pl with switch statement

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 5003: Can not search for organisation by name
Katrin Fischer [Wed, 10 Nov 2010 13:45:33 +0000 (08:45 -0500)]
Bug 5003: Can not search for organisation by name

Rebased to current HEAD, small error fixed.
Should also apply to 3.2

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 5380: remove copy-and-paste from authorities/detail.pl
Galen Charlton [Wed, 10 Nov 2010 05:09:37 +0000 (00:09 -0500)]
bug 5380: remove copy-and-paste from authorities/detail.pl

MARC editor code not needed here.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 5372: identify empty field in authority record correctly
Galen Charlton [Wed, 10 Nov 2010 04:48:33 +0000 (23:48 -0500)]
bug 5372: identify empty field in authority record correctly

This is the sibling to the fix for this bug for the bib
editor.  However, note that this change won't have a
direct effect yet, as currently you can't specify a
default value for a field or subfield in the authority
MARC frameworks.  See bug 4887.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoUkranian and Russian syspref language updates
Chris Cormack [Mon, 8 Nov 2010 23:01:02 +0000 (12:01 +1300)]
Ukranian and Russian syspref language updates

13 years agoRussian and Ukranian opac language updates
Chris Cormack [Mon, 8 Nov 2010 23:00:40 +0000 (12:00 +1300)]
Russian and Ukranian opac language updates

13 years agoStaff interface .po file updates
Chris Cormack [Mon, 8 Nov 2010 22:59:41 +0000 (11:59 +1300)]
Staff interface .po file updates

13 years agoMerge remote branch 'kc/new/bug_5370' into kcmaster
Chris Cormack [Mon, 8 Nov 2010 21:49:01 +0000 (10:49 +1300)]
Merge remote branch 'kc/new/bug_5370' into kcmaster

13 years agoBug 5370: Fix all references to koha.org
Katrin Fischer [Mon, 8 Nov 2010 20:52:32 +0000 (21:52 +0100)]
Bug 5370: Fix all references to koha.org

Thx to Brooke for helping with the wiki.

This is the last patch.
We will have to change some more links, after translate.koha.org was moved.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge branch 'trivial_bugs' of git://git.koha-community.org/wip/koha-fbc into kcmaster
Chris Cormack [Mon, 8 Nov 2010 06:42:41 +0000 (19:42 +1300)]
Merge branch 'trivial_bugs' of git://git.koha-community.org/wip/koha-fbc into kcmaster

13 years agoBug 4515 (Few very small errors in opac-search.pl) RESENT fixing whitespace warning
Marcel de Rooy [Thu, 4 Nov 2010 11:38:45 +0000 (11:38 +0000)]
Bug 4515 (Few very small errors in opac-search.pl) RESENT fixing whitespace warning

Loop on results should stop before $i==@servers.  Adding fix for warnings on undefined values in comparison for lines 485, 488 and 510.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoBug 4472 Apply it to MARC21
Frédéric Demians [Wed, 3 Nov 2010 17:38:35 +0000 (18:38 +0100)]
Bug 4472 Apply it to MARC21

For French installation of Koha using MARC21, the same issues as UNIMARC
affects handling of &nbsp; by translation scripts.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5214' into kcmaster
Chris Cormack [Mon, 8 Nov 2010 02:31:49 +0000 (15:31 +1300)]
Merge remote branch 'kc/new/bug_5214' into kcmaster

13 years agoFix for Bug 5214 - undefined itype images cause broken image icon in request.pl
Owen Leonard [Thu, 28 Oct 2010 14:24:59 +0000 (10:24 -0400)]
Fix for Bug 5214 - undefined itype images cause broken image icon in request.pl

Also fixes the same bug on the Itemtypes administration page.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agoMerge remote branch 'kc/new/bug_5236' into kcmaster
Chris Cormack [Mon, 8 Nov 2010 02:26:37 +0000 (15:26 +1300)]
Merge remote branch 'kc/new/bug_5236' into kcmaster

13 years agobug 5236: remove hidemytags from CSS as well
Galen Charlton [Thu, 28 Oct 2010 13:23:12 +0000 (09:23 -0400)]
bug 5236: remove hidemytags from CSS as well

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 5219: tidy cleanup_database.pl
Galen Charlton [Thu, 28 Oct 2010 13:05:21 +0000 (09:05 -0400)]
bug 5219: tidy cleanup_database.pl

Includes a bit of cleanup of the enhancement patch
for bug 5074 - adding comments about old and new
behavior isn't necessary for such small changes.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>