]> git.koha-community.org Git - koha.git/log
koha.git
12 years agoBug 5668 Error during during insall with web installer, Step 3
mveron [Thu, 12 Apr 2012 20:17:02 +0000 (22:17 +0200)]
Bug 5668 Error during during insall with web installer, Step 3

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Mason James <mtj at kohaaloha.com>
Before patch web installer dies with error message on creating
database tables:
ERROR 1064 (42000) at line 2821: You have an error in your SQL
syntax; check the manual that corresponds to your MySQL server
version for the right syntax to use near '- biblionumber int(11)
NOT NULL, - rating_value tinyint(1) NOT NULL, - ' at line 2

After patch installation completes normally. I also checked
that tables ratings and pending_offline_operations were
created correctly.

Note: This is Marc Veron's first patch for Koha - congratulations!
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5668 follow-up: removing empty lines in opac.pref
Paul Poulain [Tue, 10 Apr 2012 12:58:32 +0000 (14:58 +0200)]
Bug 5668 follow-up: removing empty lines in opac.pref

Those lines where introduced by this patch

12 years agoBug 5668 follow-up: DBRev number
Paul Poulain [Tue, 10 Apr 2012 12:57:55 +0000 (14:57 +0200)]
Bug 5668 follow-up: DBRev number

12 years agoBug 5668 - Star ratings in the opac
Mason James [Fri, 30 Mar 2012 03:35:29 +0000 (16:35 +1300)]
Bug 5668 - Star ratings in the opac

patch applied to commit eb3dc448d2378e01a524d082fc6389484b0cc7d8

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Turned on star ratings in the opac on details and results
Searched for titles - saw the stars
Clicked on a title
Clicked on the stars
Clicked on the stars to change my rating
Logged out
Tried to click on stars
Logged in as different user
Rated items that were rated already and saw average change
Changed preference to show only on detail and repeated tests
Changed preference to now show stars

All above tests passed. Signing off.

Rebased 3-19-12 by Ian Walls

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7743 follow up fixing syntax to so templates pass test
Chris Cormack [Mon, 9 Apr 2012 08:04:20 +0000 (20:04 +1200)]
Bug 7743 follow up fixing syntax to so templates pass test

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Failing test was: xt/author/valid-templates.t

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 :[SIGNED-OFF] Fixing some perlcritic violations in the opac
Chris Cormack [Thu, 5 Apr 2012 03:40:46 +0000 (15:40 +1200)]
Bug 6679 :[SIGNED-OFF] Fixing some perlcritic violations in the opac

signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

12 years agoBug 6679 :[SIGNED-OFF] members dir now passes perlcritic tests
Chris Cormack [Thu, 5 Apr 2012 02:43:20 +0000 (14:43 +1200)]
Bug 6679 :[SIGNED-OFF] members dir now passes perlcritic tests

signed-off-by Jonathan Druart <jonathan.druart@biblibre.com>

12 years agoBug 7816 :[SIGNED-OFF] Encode output as utf-8 dont just flag it as such
Colin Campbell [Fri, 23 Mar 2012 12:17:58 +0000 (12:17 +0000)]
Bug 7816 :[SIGNED-OFF] Encode output as utf-8 dont just flag it as such

Intention of code is that data is output in utf-8 requires an
encoding layer to ensure that. ':utf-8' flags the stream as utf-8
but does not ensure output characters are correctly encoded

signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7871: prevents crash when suggestion linked to erased budget
Adrien Saurat [Tue, 3 Apr 2012 07:56:46 +0000 (09:56 +0200)]
Bug 7871: prevents crash when suggestion linked to erased budget

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7807: [SIGNED-OFF] Fix call to GetSuggestionFromBiblionumber
Julian Maurice [Thu, 22 Mar 2012 16:20:01 +0000 (17:20 +0100)]
Bug 7807: [SIGNED-OFF] Fix call to GetSuggestionFromBiblionumber

This sub only takes one parameter

signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7886 follow-up DBRev number
Paul Poulain [Tue, 10 Apr 2012 09:53:15 +0000 (11:53 +0200)]
Bug 7886 follow-up DBRev number

12 years agoBug 7886 - C4/ShelfBrowser slow SQL performance
Dobrica Pavlinusic [Wed, 4 Apr 2012 23:03:30 +0000 (01:03 +0200)]
Bug 7886 - C4/ShelfBrowser slow SQL performance

ShelfBrowser uses two SQL queries with syntax

WHERE ((cn_sort = ? AND itemnumber < ?) OR cn_sort < ?)
AND homebranch = ? AND location = ? AND ccode = ?

homebranch already has index, and adding indexes on ccode and location
improves performance by 30% for each query since MySQL is able to use
index_merge intersect(items_ccode,homebranch,items_location)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7900: Link to vendor from subscription detail is broken
Katrin Fischer [Fri, 6 Apr 2012 15:09:30 +0000 (17:09 +0200)]
Bug 7900: Link to vendor from subscription detail is broken

To test:
- Add a serial subscription with a link to a vendor
- Check the subscription detail page for the name and link to the vendor
- Check that the link works correctly

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 2505 : Switch on warnings in circ/returns.pl
Colin Campbell [Wed, 15 Jun 2011 11:15:14 +0000 (12:15 +0100)]
Bug 2505 : Switch on warnings in circ/returns.pl

Removed a compile time warning caused by a void context
in a bit of too clever obscure code

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 2505 : use warnings in smart_rules.pl
Colin Campbell [Tue, 7 Jun 2011 13:34:18 +0000 (14:34 +0100)]
Bug 2505 : use warnings in smart_rules.pl

Fix some careless code redeclaring a variable
declaring a variable in a condition
so that these don't generate errors

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 2505 - enable Perl warnings in all modules and scripts
Mason James [Thu, 15 Mar 2012 08:06:22 +0000 (21:06 +1300)]
Bug 2505 - enable Perl warnings in all modules and scripts

enable warnings, and correct perlcritic's 'Loop iterator is not lexical' errors in C4/Ris.pm

modified:   C4/Ris.pm

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7893 - add package dependencies
Robin Sheat [Wed, 4 Apr 2012 11:10:59 +0000 (23:10 +1200)]
Bug 7893 - add package dependencies

This adds some dependencies to the control file that are required.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 2780 - Capitalize strings consistently (home, about, login)
Katrin Fischer [Sun, 8 Apr 2012 21:42:36 +0000 (23:42 +0200)]
Bug 2780 - Capitalize strings consistently (home, about, login)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_2780'
Paul Poulain [Tue, 10 Apr 2012 08:32:48 +0000 (10:32 +0200)]
Merge remote-tracking branch 'origin/new/bug_2780'

12 years ago[SIGNED-OFF]Bug 2780 - Capitalize strings consistently (tools)
Katrin Fischer [Sun, 8 Apr 2012 21:31:33 +0000 (23:31 +0200)]
[SIGNED-OFF]Bug 2780 - Capitalize strings consistently (tools)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This patch also fixes some strings:
* itemcallnumber => item call number
* Profile marcfields=> Profile MARC fields

12 years ago[SIGNED-OFF]Bug 2780 - Capitalize strings consistently (virtualshelves)
Katrin Fischer [Sun, 8 Apr 2012 20:50:10 +0000 (22:50 +0200)]
[SIGNED-OFF]Bug 2780 - Capitalize strings consistently (virtualshelves)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
This patch also fixes some vocabulary replacing "shelf" by "list"

12 years ago[SIGNED-OFF]Bug 2780 - Capitalize strings consistently (reports)
Katrin Fischer [Sun, 8 Apr 2012 19:29:39 +0000 (21:29 +0200)]
[SIGNED-OFF]Bug 2780 - Capitalize strings consistently (reports)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years ago[SIGNED-OFF]Bug 2780: Capitalize strings consistently
Katrin Fischer [Sun, 8 Apr 2012 17:39:00 +0000 (19:39 +0200)]
[SIGNED-OFF]Bug 2780: Capitalize strings consistently

Fixes some more strings.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years ago[SIGNED-OFF]Bug 2780: Capitalize strings consistently
Katrin Fischer [Fri, 6 Apr 2012 22:26:23 +0000 (00:26 +0200)]
[SIGNED-OFF]Bug 2780: Capitalize strings consistently

Some missing strings.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_2780'
Paul Poulain [Tue, 10 Apr 2012 08:04:51 +0000 (10:04 +0200)]
Merge remote-tracking branch 'origin/new/bug_2780'

12 years agoBug 2780 - Capitalize strings consistently - various
Katrin Fischer [Sun, 8 Apr 2012 20:35:26 +0000 (22:35 +0200)]
Bug 2780 - Capitalize strings consistently - various

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
12 years agoBug 2780 - Capitalize strings consistently (serials)
Katrin Fischer [Sun, 8 Apr 2012 20:17:24 +0000 (22:17 +0200)]
Bug 2780 - Capitalize strings consistently (serials)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
12 years agoBug 2780 - Capitalize strings consistently (reserve, review, rotating collections)
Katrin Fischer [Sun, 8 Apr 2012 19:44:56 +0000 (21:44 +0200)]
Bug 2780 - Capitalize strings consistently (reserve, review, rotating collections)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
12 years agoBug 2780 - Capitalize strings consistently (patron cards)
Katrin Fischer [Sun, 8 Apr 2012 18:44:38 +0000 (20:44 +0200)]
Bug 2780 - Capitalize strings consistently (patron cards)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
12 years agoBug 2780 - Capitalize strings consistently (offline circulation)
Katrin Fischer [Sun, 8 Apr 2012 18:22:41 +0000 (20:22 +0200)]
Bug 2780 - Capitalize strings consistently (offline circulation)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
12 years agoBug 2780 - Capitalize strings consistently (members)
Katrin Fischer [Sun, 8 Apr 2012 17:49:57 +0000 (19:49 +0200)]
Bug 2780 - Capitalize strings consistently (members)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
12 years agoBug 2780 - Follow up - Capitalize strings consistently (Staff client cart)
Katrin Fischer [Fri, 6 Apr 2012 17:52:41 +0000 (19:52 +0200)]
Bug 2780 - Follow up - Capitalize strings consistently (Staff client cart)

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
12 years agoBug 2780 - Follow up - Capitalize strings consistently (Admin pages)
Katrin Fischer [Fri, 6 Apr 2012 17:43:29 +0000 (19:43 +0200)]
Bug 2780 - Follow up - Capitalize strings consistently (Admin pages)

Fixes some missed strings.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
12 years agoBug 2780 - Capitalize strings consistently (Labels templates)
Owen Leonard [Fri, 6 Apr 2012 19:50:10 +0000 (15:50 -0400)]
Bug 2780 - Capitalize strings consistently (Labels templates)

Correcting capitalization in Labels templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Labels help)
Owen Leonard [Fri, 6 Apr 2012 19:11:44 +0000 (15:11 -0400)]
Bug 2780 - Capitalize strings consistently (Labels help)

Correcting capitalization in Labels help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Misc. help pages)
Owen Leonard [Fri, 6 Apr 2012 18:06:37 +0000 (14:06 -0400)]
Bug 2780 - Capitalize strings consistently (Misc. help pages)

Correcting capitalization in various help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Circulation help)
Owen Leonard [Fri, 6 Apr 2012 13:35:18 +0000 (09:35 -0400)]
Bug 2780 - Capitalize strings consistently (Circulation help)

Correcting capitalization in Circulation help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Authorities and Cataloging help)
Owen Leonard [Fri, 6 Apr 2012 13:20:42 +0000 (09:20 -0400)]
Bug 2780 - Capitalize strings consistently (Authorities and Cataloging help)

Correcting capitalization in Authorities and Cataloging help pages

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Admin help)
Owen Leonard [Thu, 5 Apr 2012 16:33:37 +0000 (12:33 -0400)]
Bug 2780 - Capitalize strings consistently (Admin help)

Correcting capitalization in Administration help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Acqui help)
Owen Leonard [Thu, 5 Apr 2012 15:46:12 +0000 (11:46 -0400)]
Bug 2780 - Capitalize strings consistently (Acqui help)

Correcting capitalization in Acquisitions help templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Installer)
Owen Leonard [Fri, 6 Apr 2012 19:42:02 +0000 (15:42 -0400)]
Bug 2780 - Capitalize strings consistently (Installer)

Correcting capitalization in Installer templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Error pages)
Owen Leonard [Thu, 5 Apr 2012 15:14:11 +0000 (11:14 -0400)]
Bug 2780 - Capitalize strings consistently (Error pages)

Correcting capitalization in staff client error pages

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (OPAC includes)
Owen Leonard [Wed, 4 Apr 2012 19:18:39 +0000 (15:18 -0400)]
Bug 2780 - Capitalize strings consistently (OPAC includes)

Correcting capitalization in OPAC includes

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Circulation)
Owen Leonard [Wed, 4 Apr 2012 18:38:11 +0000 (14:38 -0400)]
Bug 2780 - Capitalize strings consistently (Circulation)

Correcting capitalization in Circulation templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Cataloging pages)
Owen Leonard [Wed, 4 Apr 2012 16:56:17 +0000 (12:56 -0400)]
Bug 2780 - Capitalize strings consistently (Cataloging pages)

Correcting capitalization in Cataloging templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Cataloging plugins)
Owen Leonard [Wed, 4 Apr 2012 16:36:12 +0000 (12:36 -0400)]
Bug 2780 - Capitalize strings consistently (Cataloging plugins)

Correcting capitalization in Cataloging plugins. Also
correcting some instances of invalid HTML.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Catalog pages)
Owen Leonard [Wed, 4 Apr 2012 14:59:43 +0000 (10:59 -0400)]
Bug 2780 - Capitalize strings consistently (Catalog pages)

Correcting capitalization in the staff client catalog pages

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Staff client cart)
Owen Leonard [Wed, 4 Apr 2012 14:22:29 +0000 (10:22 -0400)]
Bug 2780 - Capitalize strings consistently (Staff client cart)

Correcting capitalization in the staff client's cart templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Authorities pages)
Owen Leonard [Wed, 4 Apr 2012 13:47:15 +0000 (09:47 -0400)]
Bug 2780 - Capitalize strings consistently (Authorities pages)

Correcting capitalization in Authorities templates

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2780 - Capitalize strings consistently (Admin pages)
Owen Leonard [Tue, 3 Apr 2012 19:28:23 +0000 (15:28 -0400)]
Bug 2780 - Capitalize strings consistently (Admin pages)

Correcting capitalization in Administration templates.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 2733 - Can't print patron account
Owen Leonard [Tue, 3 Apr 2012 13:03:25 +0000 (09:03 -0400)]
Bug 2733 - Can't print patron account

Changing "print page" link to "print summary." I hope this will
alleviate the suggstion that the option prints the current page.

- Changed "Quick slip" to "Print quick slip" to make it consistent
  with the other options in the menu

- Corrected the case of other text strings as required by
  Bug 2780.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_2780'
Paul Poulain [Fri, 6 Apr 2012 16:28:07 +0000 (18:28 +0200)]
Merge remote-tracking branch 'origin/new/bug_2780'

12 years agoBug 2780 - Capitalize strings consistently (OPAC pages)
Owen Leonard [Wed, 4 Apr 2012 19:31:11 +0000 (15:31 -0400)]
Bug 2780 - Capitalize strings consistently (OPAC pages)

Correcting capitalization in OPAC templates

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Passes tests, changes look consistent by reading through the patch.

What a doozy!

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6701 - login timeout is in seconds
Dobrica Pavlinusic [Tue, 27 Mar 2012 13:14:22 +0000 (15:14 +0200)]
Bug 6701 - login timeout is in seconds

I checked in C4/Auth and we are using perl time() for comparison with this value.

I also added description of specifying timeout in days which is available in code.

Robin Sheat suggested to document just lowercase d for days option, to reduce
confusion although uppercase D works as days specifier as well.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7781'
Paul Poulain [Fri, 6 Apr 2012 16:22:19 +0000 (18:22 +0200)]
Merge remote-tracking branch 'origin/new/bug_7781'

12 years agoBug 7847 - OPAC search dies with plack
Dobrica Pavlinusic [Sat, 31 Mar 2012 01:28:47 +0000 (03:28 +0200)]
Bug 7847 - OPAC search dies with plack

This bug was uncovered by @mglavica during HackFest in Marseille
It also showed it's ugly head during my plack presentation there.

Following chang removes circural dependecy introduced by commit
b65efdaacaf77fb53fee479da7f2e990ba0adeed which is part of Bug 6027

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agobug 7894 [SIGNED-OFF]: crude fix: convert results array into an arrayref
MJ Ray [Wed, 4 Apr 2012 09:23:06 +0000 (10:23 +0100)]
bug 7894 [SIGNED-OFF]: crude fix: convert results array into an arrayref

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
This patch fixes the problem with the first record on the second
page, but there is still a problem with the next/previous links,
as described in comments 3 and 4 in the bug report. I'm signing
off since it's unclear wether that problem is directly linked to
the "first record on the second page" problem, and a partial fix
seems better than no fix at all.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7758 - Koha allowing LOST items to check out without alert
Kyle M Hall [Thu, 5 Apr 2012 15:16:47 +0000 (11:16 -0400)]
Bug 7758 - Koha allowing LOST items to check out without alert

Adds a confirmation alert when issuing an item that has
been marked as lost.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
passes tests, works as advertiesd

Tested:
- checking out an item that is marked lost performs all usual lost operations
- checking out an item that is marked lost prompts for confirmation

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5549 follow-up DBRev number
Paul Poulain [Fri, 6 Apr 2012 15:59:47 +0000 (17:59 +0200)]
Bug 5549 follow-up DBRev number

for lengthunit follow-up (that was missing in kohastructure, see comments 86 - 95

12 years agobug 5549: change to kohastructure.sql missing from commit 8cea8e5cc05075dc391194248d3...
MJ Ray [Thu, 5 Apr 2012 17:56:39 +0000 (18:56 +0100)]
bug 5549: change to kohastructure.sql missing from commit 8cea8e5cc05075dc391194248d31a54586389601

Also deletes earlier updatedatabase addition of lengthunit to avoid errors for people upgrading from stable (thanks Katrin for the idea)

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Checked creating a database from scratch and updating a database
with missing lengthunit column. Both worked without any problem.
If you update and have the column updatedatabase will report an error,
but the database will be ok.

12 years agoBug 7897: Move the SocialNetworks syspref to the Opac tab
Jonathan Druart [Thu, 5 Apr 2012 11:50:48 +0000 (13:50 +0200)]
Bug 7897: Move the SocialNetworks syspref to the Opac tab

Original bug is Bug 7470

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7445 - Clicking on a tag gives "Language ... does not exist"
Magnus Enger [Mon, 2 Apr 2012 13:27:49 +0000 (15:27 +0200)]
Bug 7445 - Clicking on a tag gives "Language ... does not exist"

To test:
- Syspref QueryStemming = Try
- Install Norwegian bokmål:
  cd misc/translator/
  perl translate install nb-NO
- Go to Home › Administration › System Preferences > I18N/L10N
  and enable "Norsk bokmål(nb-NO)" for opaclanguages as well as
  setting opaclanguagesdisplay = Allow
- Make sure you have selected "Norsk bokmål" as the active language
  in the OPAC
- Find a record that has a tag (which does not contain any digits)
- Click on the tag and see that you get the error in the title of
  this bug
- Apply the patch
- Click on the tag again and the error should be gone

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Easy to test with a great test plan. Works nicely.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7613 follow-up DBRev number
Paul Poulain [Fri, 6 Apr 2012 15:37:26 +0000 (17:37 +0200)]
Bug 7613 follow-up DBRev number

12 years agoBug 7613 follow up to fix perlcritic errors
Chris Cormack [Thu, 5 Apr 2012 02:28:06 +0000 (14:28 +1200)]
Bug 7613 follow up to fix perlcritic errors

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agobug_7613: OCLC Connexion gateway
Srdjan [Thu, 29 Mar 2012 03:04:50 +0000 (16:04 +1300)]
bug_7613: OCLC Connexion gateway

svc/import_bib:
* takes POST request with parameters in url and MARC XML as DATA
* pushes MARC XML to an impoort bach queue of type 'webservice'
* returns status and imported record XML
* is a drop-in replacement for svc/new_bib

misc/cronjobs/import_webservice_batch.pl:
* a cron job for processing impoort bach queues of type 'webservice'
* batches can also be processed through the UI

misc/bin/connexion_import_daemon.pl:
* a daemon that listens for OCLC Connexion requests and is compliant
  with OCLC Gateway spec
* takes request with MARC XML
* takes import batch params from a config file and forwards the lot to
  svc/import_bib
* returns status

ImportBatches:
* Added new import batch type of 'webservice'
* Changed interface to AddImportBatch() - now it takes a hashref
* Replaced batch_type = 'batch' with
  batch_type IN ( 'batch', 'webservice' ) in some SELECTs

Signed-off-by: MJ Ray <mjr@phonecoop.coop>
12 years agoBug 7641 - Add ability to suspend reserves - Followup
Kyle M Hall [Thu, 29 Mar 2012 15:50:43 +0000 (11:50 -0400)]
Bug 7641 - Add ability to suspend reserves - Followup

  * Switch from C4::Dates to $KohaDates
  * Fix 'Resume All Suspended All Requests'
  * Change button text to follow capitalization rules
  * Change 'requests' to 'holds'

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7781 : enhancements on main page
Adrien Saurat [Thu, 22 Mar 2012 11:07:16 +0000 (12:07 +0100)]
Bug 7781 : enhancements on main page

- moves the different search boxes on top of page
- displays the Koha logo
- displays the breadcrumb bar
- displays a general title "Welcome to Koha"
- reorganises the links to modules
- centers the main menu even if no news are displayed
- fixes the Submit button when CircAutocompl is on

Signed-off-by: mveron <veron@veron.ch>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7310'
Paul Poulain [Fri, 6 Apr 2012 14:02:11 +0000 (16:02 +0200)]
Merge remote-tracking branch 'origin/new/bug_7310'

12 years ago7368 Followup for indentation in VirtualShelves.pm
Marcel de Rooy [Thu, 5 Apr 2012 13:58:22 +0000 (15:58 +0200)]
7368 Followup for indentation in VirtualShelves.pm

Corrects some further indentation issues, removes last tab from file.
Related to report 7310.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
12 years agoMerge remote-tracking branch 'origin/new/bug_7143'
Paul Poulain [Fri, 6 Apr 2012 13:12:28 +0000 (15:12 +0200)]
Merge remote-tracking branch 'origin/new/bug_7143'

12 years agoItalian translation teams
Zeno Tajoli [Sat, 31 Mar 2012 08:08:29 +0000 (10:08 +0200)]
Italian translation teams

http://bugs.koha-community.org/show_bug.cgi?id=7143

12 years agoBug 7785: Remove unused function columns() which uses a MySQLism.
Marc Balmer [Fri, 23 Mar 2012 16:37:02 +0000 (17:37 +0100)]
Bug 7785: Remove unused function columns() which uses a MySQLism.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoStop unnecessary warnings in get_language
Colin Campbell [Mon, 2 Apr 2012 14:06:28 +0000 (15:06 +0100)]
Stop unnecessary warnings in get_language

Refactor code to be more idiomatic and clarify its intention was testing
undef against languages causing log warn was creating and assigning to
unnecessary variables calling accept_language with an undef is an
expensive way to get undef returned to the caller test we are asking it
a meabingful question use any rather than first ( we dont care about
firstness it should be unique anyway but it obscures the meaning of the
test ) split takes a pattern not a string

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Having put my hands recently in this part of Koha code, I can confirm
that this patch fix log warnings, and add clarity and conciseness.

http://bugs.koha-community.org/show_bug.cgi?id=7874
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7284'
Paul Poulain [Wed, 4 Apr 2012 16:18:26 +0000 (18:18 +0200)]
Merge remote-tracking branch 'origin/new/bug_7284'

12 years agobug 7284: fix package build problem, move BEGIN into new
MJ Ray [Thu, 29 Mar 2012 17:35:04 +0000 (18:35 +0100)]
bug 7284: fix package build problem, move BEGIN into new

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7766 - C4/Auth.pm: emit DEBUG output to STDERR
Dobrica Pavlinusic [Wed, 21 Mar 2012 08:26:22 +0000 (09:26 +0100)]
Bug 7766 - C4/Auth.pm: emit DEBUG output to STDERR

writing to STDOUT breaks plack when running with DEBUG=1

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 2780 - Capitalize strings consistently (Acquisitions pages)
Owen Leonard [Tue, 3 Apr 2012 18:22:42 +0000 (14:22 -0400)]
Bug 2780 - Capitalize strings consistently (Acquisitions pages)

Correcting capitalization on strings in Acquisitions templates

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (miscellaneous)
Owen Leonard [Tue, 3 Apr 2012 15:49:16 +0000 (11:49 -0400)]
Bug 2780 - Capitalize strings consistently (miscellaneous)

Correcting all remaining includes

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (Tools)
Owen Leonard [Tue, 3 Apr 2012 15:36:06 +0000 (11:36 -0400)]
Bug 2780 - Capitalize strings consistently (Tools)

Correcting Tools-related includes

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (Reports)
Owen Leonard [Tue, 3 Apr 2012 15:31:22 +0000 (11:31 -0400)]
Bug 2780 - Capitalize strings consistently (Reports)

Correcting Reports-related includes

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (Administration)
Owen Leonard [Tue, 3 Apr 2012 15:23:10 +0000 (11:23 -0400)]
Bug 2780 - Capitalize strings consistently (Administration)

Correcting System administration-related includes

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (Cataloging)
Owen Leonard [Tue, 3 Apr 2012 15:09:53 +0000 (11:09 -0400)]
Bug 2780 - Capitalize strings consistently (Cataloging)

Correcting Cataloging-related includes

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (Serials)
Owen Leonard [Tue, 3 Apr 2012 15:06:11 +0000 (11:06 -0400)]
Bug 2780 - Capitalize strings consistently (Serials)

Correcting Serials-related includes

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (Patrons)
Owen Leonard [Tue, 3 Apr 2012 14:58:54 +0000 (10:58 -0400)]
Bug 2780 - Capitalize strings consistently (Patrons)

Correcting Patron-related includes

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (Patron cards)
Owen Leonard [Tue, 3 Apr 2012 14:29:38 +0000 (10:29 -0400)]
Bug 2780 - Capitalize strings consistently (Patron cards)

Correcting Patron card creator-related includes

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (Labels)
Owen Leonard [Tue, 3 Apr 2012 14:25:08 +0000 (10:25 -0400)]
Bug 2780 - Capitalize strings consistently (Labels)

Correcting Labels-related includes

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (Circulation)
Owen Leonard [Tue, 3 Apr 2012 14:15:07 +0000 (10:15 -0400)]
Bug 2780 - Capitalize strings consistently (Circulation)

Correcting Circulation-related includes

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (Budgets)
Owen Leonard [Tue, 3 Apr 2012 13:36:44 +0000 (09:36 -0400)]
Bug 2780 - Capitalize strings consistently (Budgets)

Correcting Budgets-related includes.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently (catalog)
Owen Leonard [Tue, 3 Apr 2012 13:32:45 +0000 (09:32 -0400)]
Bug 2780 - Capitalize strings consistently (catalog)

Correcting catalog-related includes.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently
Owen Leonard [Tue, 3 Apr 2012 13:26:47 +0000 (09:26 -0400)]
Bug 2780 - Capitalize strings consistently

Corrections to Authorities-related includes.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 2780 - Capitalize strings consistently
Owen Leonard [Tue, 3 Apr 2012 13:20:45 +0000 (09:20 -0400)]
Bug 2780 - Capitalize strings consistently

Corrections to Acquisitions include files. Patch
also includes some corrections to unescaped ampersands.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7482: overdues report downloads without names
Katrin Fischer [Sun, 1 Apr 2012 16:20:05 +0000 (18:20 +0200)]
Bug 7482: overdues report downloads without names

This patch is an alternate patch for the bug. Instead of having
one column 'name' for a concatenated first and last name it
adds 2 separate columns to the exported csv file.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7876 - Add ids to divs and spans with ids in opac-user.tt
Kyle M Hall [Mon, 2 Apr 2012 17:57:36 +0000 (13:57 -0400)]
Bug 7876 - Add ids to divs and spans with ids in opac-user.tt

This commit adds an id to each div, and adds spans where
there are no appropriate divs to add. In addition, non-static text
such as the expiration date are wrapped in a special sub-span so
that data can be pulled and reused when customizing via jQuery.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7885 - Change filename of TransferLog suggested by packages to fit with logrotate
Magnus Enger [Wed, 4 Apr 2012 06:49:56 +0000 (08:49 +0200)]
Bug 7885 - Change filename of TransferLog suggested by packages to fit with logrotate

The apache accesslogs suggested by the default config files are called
*_log, which results in them not getting picked up by logrotate, which
looks for *.log. This patch changes the suggested filenames to *.log.

To test:
Not much to test here, just apply the patch and check that all
occurences of TransferLog and CustomLog are now on the form *.log

All the lines where these occur are commented out, so this will
not actually change any behaviour.

Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
12 years agoBug 7850 - Fix values for hidden in subfields of 952 + maxlength in NORMARC frameworks
Magnus Enger [Fri, 30 Mar 2012 07:59:03 +0000 (09:59 +0200)]
Bug 7850 - Fix values for hidden in subfields of 952 + maxlength in NORMARC frameworks

This patch does three things:

- Add a copyright comment to normarc_fastadd_framework.sql
- Change the value of marc_subfield_structure.hidden from -1 to 0 for
  several subfields of 952, in both the default and fast add framework,
  using this SQL statement:
  update marc_subfield_structure set hidden = 0 where tagfield = '952' and hidden = -1;
- Add the maxlength column introduced by bug 7263 to all rows in
  marc_subfield_structure, setting the following maxlengths:
  000 = 24
  008 = 40
  all other subfields = 9999

The format of the SQL files is the one that is produced by exporting the
frameworks from the Web UI, with added copyright comments at the top.

To test:
- Install nb-NO
- Run through the web installer in Norwegian on an empty database
- Select NORMARC as the marcflavour
- Be sure to select the fast add framework ("Rammeverk for
  hurtigkatalogisering" under "Valgritt")
- Check in Home › Administration › MARC Frameworks that 000 and 008
  for both frameworks have the right length
- Add a dummy record so you get to the item edit screen and check that
  the form for subfields looks good. The subfields that are shown
  should be 01234578abcdefghjoptuvwyz and all subfields should have
  a text box or a dropdown associated with them. Check this for
  for both the default and fast add frameworks

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Walked through the test plan, seems to work well.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7858 - Missing packages from install_misc/ubuntu.packages
Owen Leonard [Mon, 2 Apr 2012 12:55:06 +0000 (08:55 -0400)]
Bug 7858 - Missing packages from install_misc/ubuntu.packages

- Adding missing dependencies to install_misc/ubuntu.packages
- Removing items from CPAN instructions which are installed
  as packages

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Seems to add all necessary packages.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7860 - /virtualshelves/addbybiblionumber.pl plack scoping
Dobrica Pavlinusic [Fri, 30 Mar 2012 23:30:26 +0000 (01:30 +0200)]
Bug 7860 - /virtualshelves/addbybiblionumber.pl plack scoping

Variable "$query" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 115.
Variable "$loggedinuser" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 129.
Variable "$shelfnumber" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 134.
Variable "$newvirtualshelf" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 135.
Variable "$sortfield" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 136.
Variable "$category" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 137.
Variable "$loggedinuser" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 137.
Variable "$authorized" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 139.
Variable "$errcode" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 140.
Variable "@biblionumber" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 143.
Variable "$query" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 145.
Variable "$authorized" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 150.
Variable "$loggedinuser" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 150.
Variable "$shelfnumber" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 150.
Variable "@biblionumber" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 151.
Variable "$query" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 153.
Variable "$errcode" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 157.
Variable "$authorized" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 162.
Variable "$loggedinuser" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 162.
Variable "$shelfnumber" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 162.
Variable "$template" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 165.
Variable "$errcode" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 173.
Variable "$loggedinuser" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 178.
Variable "$template" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 180.
Variable "@biblionumber" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 188.
Variable "$template" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 196.
Variable "$template" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 204.
Variable "$newshelf" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 205.
Variable "$authorized" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 206.
Variable "$errcode" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 207.
Variable "$query" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 209.
Variable "$cookie" is not available at /srv/koha/virtualshelves/addbybiblionumber.pl line 209.
Can't call method "param" on an undefined value at /srv/koha/virtualshelves/addbybiblionumber.pl line 115.

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7864: Little changes to the display
Katrin Fischer [Sun, 1 Apr 2012 12:33:31 +0000 (14:33 +0200)]
Bug 7864: Little changes to the display

Changes the display of subscribers a bit.

- Makes each name a link to the patron account instead of having a separate
  'View' link behind each name
- Show the title and subscrption number as link to the subscription detail
  page instead of just 'subscription'

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7864: Reintroduce list of subscribers to a serial alert message
Katrin Fischer [Sun, 1 Apr 2012 07:49:06 +0000 (09:49 +0200)]
Bug 7864: Reintroduce list of subscribers to a serial alert message

Adds a link to the existing template from the serial detail page:

Patron alert with: RLIST (subscribers)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7888 - Permission for "change password" button in circ toolbar should be "borrowe...
Liz Rea [Tue, 3 Apr 2012 15:35:28 +0000 (10:35 -0500)]
Bug 7888 - Permission for "change password" button in circ toolbar should be "borrowers" instead of "staffaccess"

Patch changes permisison for "change password" button in circ-toolbar.inc from staffaccess to borrowers.

To test:
- With a staff user with borrowers permission, verify the change password button is shown for a normal patron.
- With a staff user without borrowers permission, verify the change password button does not appear.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>