]> git.koha-community.org Git - koha.git/log
koha.git
14 years agoBugzilla 1080 to add enhancement for sound. Only changed circulation.tmpl/pl and...
root [Wed, 17 Feb 2010 18:24:46 +0000 (13:24 -0500)]
Bugzilla 1080 to add enhancement for sound. Only changed circulation.tmpl/pl and returns.tmpl/pl and added a single syspref (set to off) along with very compressed OGG files for sound which are on the open source "artistic" licence.

Works for HTML5 because it loads smoothly and no plugins required but *at
  this time* this update will only work with staff clients which are Firefox
  version >=3.5 (std for Koha) but other browsers will soon be adding support.

  Additional sounds are included for people to modify and play with, but this
  is such a simple upgrade I doubt at this time Koha needs another complex
  selector so users can add their own sounds. It could be a nice enhancement
  later, of course.

  Suggest we stick with HTML5 <audio tag because it is a standard and no
  plug-ins.

  This simple update has been running live for SMFPL.org for almost 2 weeks

  -Darrell Ulm

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 3775: Accounts::chargelostitem uses title, but title not available to it
J. David Bavousett [Wed, 17 Feb 2010 16:19:09 +0000 (11:19 -0500)]
Bug 3775: Accounts::chargelostitem uses title, but title not available to it

This patch fixes the SELECT so that title is available when it is used
later on, which will prevent 'Use of uninitialized value' errors.

It also uses JOIN properly, which the original query and my initial
patches for this did not.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoMT2116 : CSV Exports : add 'new line' as separator
Matthias Meusburger [Tue, 16 Feb 2010 20:46:57 +0000 (21:46 +0100)]
MT2116 : CSV Exports : add 'new line' as separator

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoMT 2116: Addons to the CSV export
Matthias Meusburger [Tue, 16 Feb 2010 20:46:56 +0000 (21:46 +0100)]
MT 2116: Addons to the CSV export

Fix encoding selection

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoMT2116: Addons to the CSV export
Matthias Meusburger [Thu, 28 Jan 2010 14:05:54 +0000 (15:05 +0100)]
MT2116:   Addons to the CSV export

Adds the ability to customize CSV exports through the use of a YAML file.

The following customizations are available :
  - Preprocessing
  - Postprocessing
  - Field-by-field processing

The YAML field should be stored in the tools/csv-profiles/ directory and
named after the id of the CSV profile you want to customize.
An example file is provided in that directory.
(cherry picked from commit 76655b5b941f6f6094f705a296f7b68e64d148df)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoMT2716: fixing finishreceive.pl Software Error
Paul Poulain [Tue, 16 Feb 2010 20:46:54 +0000 (21:46 +0100)]
MT2716: fixing finishreceive.pl Software Error

finishreceive.pl was buggy when AcqCreateItem was set to recieve (wrong API)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoMT1203: don't display menus if the user don't has the permission
Paul Poulain [Tue, 16 Feb 2010 20:46:55 +0000 (21:46 +0100)]
MT1203: don't display menus if the user don't has the permission

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoMT 2348 : acqui-home minor improvements
Paul Poulain [Tue, 16 Feb 2010 20:46:52 +0000 (21:46 +0100)]
MT 2348 : acqui-home minor improvements

- moving some links to the left part of koha (currencies and suggestions)
- removed currency table
- changing supplier display

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years ago(bug #4062) add item index in zebra conf
Nahuel ANGELINETTI [Tue, 16 Feb 2010 15:30:02 +0000 (16:30 +0100)]
(bug #4062) add item index in zebra conf

This add the "item" index.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoupdated install instructions to include Locale::Currency::Format
Galen Charlton [Wed, 17 Feb 2010 11:45:04 +0000 (06:45 -0500)]
updated install instructions to include Locale::Currency::Format

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoset Locale::Currency::Format dep test as DBrev 119
Galen Charlton [Wed, 17 Feb 2010 11:39:22 +0000 (06:39 -0500)]
set Locale::Currency::Format dep test as DBrev 119

Also fixed bug that prevented updatedatabase.pl
from compiling if Locale::Currency::Format wasn't
already installed.  To test to see if module is present,
do

eval{require Locale::Currency::Format};

not

eval{use Locale::Currency::Format};

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBugfix: Moving sample_notices.sql to mandatory subdir
Chris Nighswonger [Tue, 16 Feb 2010 15:40:05 +0000 (10:40 -0500)]
Bugfix: Moving sample_notices.sql to mandatory subdir

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBugfix: [3/3] [TRANSLATION NEEDED] overdue_notices.pl does not process all advertised...
Chris Nighswonger [Tue, 16 Feb 2010 15:43:26 +0000 (10:43 -0500)]
Bugfix: [3/3] [TRANSLATION NEEDED] overdue_notices.pl does not process all advertised fields

Updating mandatory sample notices sql files

NOTE TO TRANSLATORS: Some of these will require new translations

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBugfix: [2/3] overdue_notices.pl does not process all advertised fields
Chris Nighswonger [Tue, 16 Feb 2010 15:56:03 +0000 (10:56 -0500)]
Bugfix: [2/3] overdue_notices.pl does not process all advertised fields

This patch adds a dependency requirement for Locale::Currency::Format

NOTE: It does not adjust kohaversion.pl and sets the dev version to XXX.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBugfix: [1/3] overdue_notices.pl does not process all advertised fields
Chris Nighswonger [Tue, 16 Feb 2010 15:56:02 +0000 (10:56 -0500)]
Bugfix: [1/3] overdue_notices.pl does not process all advertised fields

Note: overdue_notices.pl really needs to be completely re-written.

The script does not process all fields advertised in tools/letter.pl
This patch adds code to process all fields advertised as well as any
from the items table.

It also adds two additional tags for use in the letter templates:

<item></item> which should enclose all fields from the biblio, biblioitems,
and items tables.

<fine></fine> which should be enclosed by the item tag and should
enclose a currency identifier per ISO 4217. If this tag is present with
a proper identifier, the fine for that item will be displayed in the
proper currency format. Note: ISO 4217 changes from time to time therefore
all currencies may not be supported. If you find one that is not
supported, please file a bug with the Locale::Currency::Format author
Tan D Nguyen <tnguyen at cpan doe org>.

An example of the implimentation of these two tags in a notice template
might be like:

The following item(s) is/are currently overdue:

<item>"<<biblio.title>>" by <<biblio.author>>, <<items.itemcallnumber>>, Barcode: <<items.barcode>> Fine: <fine>GBP</fine></item>

Which, assuming two items were overdue, would result in a notice like:

The following item(s) is/are currently overdue:

"A Short History of Western Civilization" by Harrison, John B, 909.09821 H2451, Barcode: 08030003 Fine: £3.50
"History of Western Civilization" by Hayes, Carlton Joseph Huntley, 909.09821 H3261 v.1, Barcode: 08030004 Fine: £3.50

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4197 fix opac patron update
Nicole Engard [Tue, 16 Feb 2010 11:16:01 +0000 (06:16 -0500)]
bug 4197 fix opac patron update

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 3973: make auto-fill button work on budget planning form
Galen Charlton [Wed, 17 Feb 2010 11:17:31 +0000 (06:17 -0500)]
bug 3973: make auto-fill button work on budget planning form

Also fixed a variety of XHTML validation errors.

Programming note: it is invalid XHTML and can break Javascript
to use element IDs and class names that start with digits.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4203: add display column to aqbudgets_planning if needed (DBrev 118)
Galen Charlton [Wed, 17 Feb 2010 10:31:13 +0000 (05:31 -0500)]
bug 4203: add display column to aqbudgets_planning if needed (DBrev 118)

Had not been included in kohastructure.sql

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years ago(bug #4135) fix aqplan form
Henri-Damien LAURENT [Tue, 16 Feb 2010 15:30:00 +0000 (16:30 +0100)]
(bug #4135) fix aqplan form

This fix the form to have always the submit button, and fix security issue in aqplan.pl(authnotrequired set to 1)

Conflicts solved:

koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqplan.tmpl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 3654 Fix sql syntax error in earlier patch
Colin Campbell [Tue, 16 Feb 2010 13:10:49 +0000 (13:10 +0000)]
Bug 3654 Fix sql syntax error in earlier patch

mysql comments require a space after the --

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4151: replace dep on YAML::XS with YAML::Syck
Galen Charlton [Wed, 17 Feb 2010 10:02:42 +0000 (05:02 -0500)]
bug 4151: replace dep on YAML::XS with YAML::Syck

YAML::Syck is also fast, and dropped YAML::XS means
we don't have to add a formal dependency on it.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years ago(bug #4195) fix OAI repository
Nahuel ANGELINETTI [Tue, 16 Feb 2010 13:34:58 +0000 (14:34 +0100)]
(bug #4195) fix OAI repository

this fix the OAI repository, to don't return resumptionToken if there is no more record.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 2959 - Add a timeout parameter to the URL checker
Frédéric Demians [Mon, 15 Feb 2010 07:14:25 +0000 (08:14 +0100)]
Bug 2959 - Add a timeout parameter to the URL checker

Could improve performances for DB containing URLs which can't be fetched
(good or bad) quickly.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 3652: Fixes XSS vulnerabilities and XTHML errors in opac-search-history.tmpl
Garry Collum [Tue, 16 Feb 2010 00:17:01 +0000 (19:17 -0500)]
Bug 3652: Fixes XSS vulnerabilities and XTHML errors in opac-search-history.tmpl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 2505: fix warnings in opac-MARCdetail.pl
Galen Charlton [Tue, 16 Feb 2010 11:31:16 +0000 (06:31 -0500)]
bug 2505: fix warnings in opac-MARCdetail.pl

Also indulged in a little code cleanup.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 3449: Fixes the perpetual error message that pops up when filtering by tag reviewer.
Garry Collum [Mon, 15 Feb 2010 15:43:23 +0000 (10:43 -0500)]
Bug 3449: Fixes the perpetual error message that pops up when filtering by tag reviewer.

Duplicates the code for searching by reviewer in the form that is used in searching via a link.

It looks like it was the intention of the original writer to filter by borrower number or by name.  Filtering by name was not implemented.  Added a FIXME reference to indicate this.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 3090: Adds the report ID field to the saved reports page in the guided reports.
Garry Collum [Mon, 15 Feb 2010 16:55:24 +0000 (11:55 -0500)]
Bug 3090: Adds the report ID field to the saved reports page in the guided reports.

Adds an ID field to the save reports table in guided reports to make running runreport.pl easier for users.

Also adds zebra striping to the data table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 2505: Enables warnings in opac-MARCdetail.pl and opac-authoritiesdetail.pl
Garry Collum [Mon, 15 Feb 2010 22:20:17 +0000 (17:20 -0500)]
Bug 2505: Enables warnings in opac-MARCdetail.pl and opac-authoritiesdetail.pl

No resulting warnings after warnings were turned on.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 4192: Fixes warnings generated by opac-account.pl.
Garry Collum [Mon, 15 Feb 2010 22:44:47 +0000 (17:44 -0500)]
Bug 4192: Fixes warnings generated by opac-account.pl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoUpdate fr-FR preferences
Frédéric Demians [Mon, 15 Feb 2010 11:46:42 +0000 (12:46 +0100)]
Update fr-FR preferences

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agotweak description of OpacBrowser syspref
Galen Charlton [Tue, 16 Feb 2010 11:08:25 +0000 (06:08 -0500)]
tweak description of OpacBrowser syspref

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoAdd OpacBrowser preference to opac.pref
Frédéric Demians [Tue, 16 Feb 2010 09:52:21 +0000 (10:52 +0100)]
Add OpacBrowser preference to opac.pref

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 2885: attempting to add library with existing code now gives error message
Galen Charlton [Mon, 15 Feb 2010 02:10:25 +0000 (21:10 -0500)]
bug 2885: attempting to add library with existing code now gives error message

If one attempts to add a new library with a code already in use,
an error message is shown.  The main library data input by the user
is preserved, allowing the user to try a new code.

This also corrects a glitch in the previous patch concerning
adding a branch category whose code is already in use.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFix for bug 2885, now an error message is thrown instead of a silent fail
Chris Cormack [Sat, 26 Dec 2009 09:23:05 +0000 (22:23 +1300)]
Fix for bug 2885, now an error message is thrown instead of a silent fail

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBugfix in errors/*.pl and opac/errors/*.pl
Sébastien Hinderer [Sun, 1 Nov 2009 00:04:19 +0000 (01:04 +0100)]
Bugfix in errors/*.pl and opac/errors/*.pl

The scripts did not define the status printed on the first line of
HTTP headers correctly: they were sending 200 OK,
which was confusing for browsers.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoChange default AUTH_INDEX_MODE to dom
Colin Campbell [Fri, 12 Feb 2010 12:38:46 +0000 (12:38 +0000)]
Change default AUTH_INDEX_MODE to dom

[RM note: DOM is recommended for MARC21 authorities.  As of
 now, GRS-1 is the only mode supported for UNIMARC authorities.]

dom is the recommended authorities indexing mode in external docs
making it default accepts what appears to be the de facto preference
see Indexdata's documentation for more details on the options

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 2959 - Cache already failed URLs to speedup check-url.pl
Frédéric Demians [Fri, 12 Feb 2010 22:06:02 +0000 (23:06 +0100)]
Bug 2959 - Cache already failed URLs to speedup check-url.pl

Based on David Schuster improvement patch.

For David:

- To send the output into an HTML file, there is no need to add a
  paramater to this script, just redirect to a file:

  check-url --html --host-prot=http://koha-pro.mylib.org \\
    > /usr/local/koha/koha-tmpl/badurls.html

- If you want as a result a table with alternate rows, use CSS and
  JavaScript. For example, with jQuery (found with google):

  <style type="text/css">
  table {width:400px; border:1px solid blue;}
  .oddrow {background-color:#E5E5E5;}
  </style>
  <script type="text/javascript"
   src="http://code.jquery.com/jquery-latest.min.js"></script>
  <script type="text/javascript">
  $(function(){
    $("table.tiger-stripe tr:even").addClass("oddrow");
  });

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug #2162: Step 2, add pagination. Splits results into blocks of 250 results and...
Will Stokes [Sun, 14 Feb 2010 20:31:08 +0000 (09:31 +1300)]
Bug #2162: Step 2, add pagination. Splits results into blocks of 250 results and adds Previous and Next buttons. Achieved using forms, hidden search variables and submit buttons.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug #2162: Step 1, prevent running of report upon entry to page. Add name run_report...
Will Stokes [Sun, 14 Feb 2010 20:31:07 +0000 (09:31 +1300)]
Bug #2162: Step 1, prevent running of report upon entry to page. Add name run_report to submit button and checks in template.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 4181: Fixes XHTML in viewlog.tmpl.
Garry Collum [Sun, 14 Feb 2010 23:34:43 +0000 (18:34 -0500)]
Bug 4181: Fixes XHTML in viewlog.tmpl.

Also adds zebra striping to the data table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agofixed errors in previous patch
Galen Charlton [Mon, 15 Feb 2010 00:07:45 +0000 (19:07 -0500)]
fixed errors in previous patch

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFixing some small XSS vulnerabilities
Chris Cormack [Sun, 14 Feb 2010 23:25:42 +0000 (12:25 +1300)]
Fixing some small XSS vulnerabilities

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 1542: remove now unneeded parameter
Galen Charlton [Sun, 14 Feb 2010 23:31:58 +0000 (18:31 -0500)]
bug 1542: remove now unneeded parameter

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 1542 followup - tweak to keep handling the UI selected value out of C4
Galen Charlton [Sun, 14 Feb 2010 23:30:08 +0000 (18:30 -0500)]
bug 1542 followup - tweak to keep handling the UI selected value out of C4

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 1542, followup patch to tidy up some messy dropdown behaviour
Chris Cormack [Sun, 14 Feb 2010 20:23:46 +0000 (09:23 +1300)]
Bug 1542, followup patch to tidy up some messy dropdown behaviour

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agonew test script to help debug template errors
Galen Charlton [Sun, 14 Feb 2010 23:05:45 +0000 (18:05 -0500)]
new test script to help debug template errors

From the POD:

NAME

show-template-structure.pl

DESCRIPTION

This script displays the structure of loops and conditional statements in
an HTML::Template::Pro template, and is an aid for debugging errors
reported by the xt/author/valid-templates.t test.  It also identifies the
following errors:

* TMPL_IF/TMPL_UNLESS/TMPL_LOOP with no closing tag
* TMPL_ELSE with no initial TMPL_IF or TMPL_UNLESS
* extra closing tags
* HTML comment of the form <!-- TMPL_FOO ..., where TMPL_FOO is not a valid HTML::Template::Pro tag

USAGE

xt/author/show-template-structure.pl path/to/template.tmpl

Output is sent to STDOUT.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoremove extra /TMPL_IF
Galen Charlton [Sun, 14 Feb 2010 23:05:14 +0000 (18:05 -0500)]
remove extra /TMPL_IF

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoChanges to further work on Bug 3550, Use GetRecordValue to get the subtitle
Owen Leonard [Fri, 12 Feb 2010 14:52:38 +0000 (09:52 -0500)]
Changes to further work on Bug 3550, Use GetRecordValue to get the subtitle

- Adding subtitle display to OPAC Cart, lists, and reading record
- Minor tweaks to some displays

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4104: remove stray disused template (intranet tags.tmpl)
Galen Charlton [Sun, 14 Feb 2010 19:33:40 +0000 (14:33 -0500)]
bug 4104: remove stray disused template (intranet tags.tmpl)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4174 add AWSPrivateKey sys pref to new interface
Nicole Engard [Fri, 12 Feb 2010 05:59:58 +0000 (00:59 -0500)]
bug 4174 add AWSPrivateKey sys pref to new interface

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 4180: Fixes unclose TMPL_IF in supplier.tmpl
Garry Collum [Sun, 14 Feb 2010 04:08:19 +0000 (23:08 -0500)]
Bug 4180: Fixes unclose TMPL_IF in supplier.tmpl

Also fixes a minor XHTML error.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4169: fix item batch modification for MARC21
Galen Charlton [Mon, 1 Feb 2010 16:19:22 +0000 (10:19 -0600)]
bug 4169: fix item batch modification for MARC21

The MARC21 framework uses $0 for the item withdrawn status.  Because
of how the tool had marked the barcode and stocknumber as being
uneditable, this resulted in an off-by-one error, causing the wrong
item fields to be updated.

Fixed by simply not including the uneditable fields in list
of item fields that can be edited - if you can't change the barcode,
there's no point in displaying it in the list of fields.

Also fixed how the bib title/author/ISBN got displayed so that the
withdrawn column gets displayed after an item update.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Liz Rea <lrea@nekls.org>
14 years agoBug 4154 - Include preferences translation into install.pl
Frédéric Demians [Fri, 12 Feb 2010 06:50:46 +0000 (07:50 +0100)]
Bug 4154 - Include preferences translation into install.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoPerltidy of C4/VirtualShelves/Page.pm
Owen Leonard [Thu, 11 Feb 2010 19:25:20 +0000 (14:25 -0500)]
Perltidy of C4/VirtualShelves/Page.pm

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4168 add keyword to marc mapping to menu
Nicole Engard [Sat, 6 Feb 2010 11:48:58 +0000 (06:48 -0500)]
bug 4168 add keyword to marc mapping to menu

Also fixed misnamed budgets & funds links

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoadd koha to marc mapping help file
Nicole Engard [Sat, 6 Feb 2010 11:58:45 +0000 (06:58 -0500)]
add koha to marc mapping help file

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 4163 Preserve budget value unless changed by user
Colin Campbell [Thu, 11 Feb 2010 19:38:34 +0000 (19:38 +0000)]
Bug 4163 Preserve budget value unless changed by user

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobugfix suppress warnings coming from acquisitions homepage
Colin Campbell [Thu, 11 Feb 2010 14:40:44 +0000 (14:40 +0000)]
bugfix suppress warnings coming from acquisitions homepage

Before formatting and doing arithmetic with them we should
ensure undefined numeric elements are numbers
(This should be enforced in the db)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 4154 - Follow-up
Frédéric Demians [Thu, 11 Feb 2010 21:28:41 +0000 (22:28 +0100)]
Bug 4154 - Follow-up

- Modify install-code.pl to install prefs with templates
- Update .po preferences file in order to get last 'en' preferences

For 3.4, I will do a script which will handle together the 3 .po file:
opac, intranet and preferences (and .tt files if necessary). Don't do it
now, since it will change files naming convention.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBZ4116: results from cataloging search is different from advanced search results
Matthias Meusburger [Wed, 10 Feb 2010 16:13:41 +0000 (17:13 +0100)]
BZ4116: results from cataloging search is different from advanced search results

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBugfix: Make smart-rules.tmpl display zero values in fields.
Chris Nighswonger [Wed, 10 Feb 2010 20:00:36 +0000 (15:00 -0500)]
Bugfix: Make smart-rules.tmpl display zero values in fields.

Since TMPL_IFs evaluate false if the template variable is 0,
smart-rules.tmpl was not displaying zero values in fields where
the db field value was indeed zero which leads to some small confusion.

This patch removes the TMPL_IFs since those fields will always be
populated with some value even if it is zero.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4150 require title in new list on staff client
Nicole Engard [Sat, 6 Feb 2010 02:46:29 +0000 (21:46 -0500)]
bug 4150 require title in new list on staff client

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 4154 - Add a .po based mechanism to translate preferences
Frédéric Demians [Thu, 11 Feb 2010 06:27:45 +0000 (07:27 +0100)]
Bug 4154 - Add a .po based mechanism to translate preferences

Add to previous patch (and replace it):
  - update function
  - translation of tab subsection labels
  - GPL2
  - fix last minute bug catched by Galen

Cut-and-past of pref-trans script perldoc:

NAME
       pref-trans - Handle preferences translation

SYNOPSYS
         pref-trans init fr-FR
         pref-trans update fr-FR
         pref-trans install fr-FR

USAGE
       pref-trans init lang
           Create a .po file in po directory, named lang-pref.po. This
           file contains text to translate extracted from .pref files.

       pref-trans update lang
           Update a .po file in po directory, named lang-pref.po. This
           file contains new text to translate extracted from .pref files.
           Previous translated text are kept. There is a minor bug, which can’t
           be fixed due to preferences data struture: preferences tab
           subsection labels are lost when updating .po file.

       pref-trans install lang
           Use lang-pref.po file to translate the english version of
           preferences files and copy those files in the appropriate
           directory.

DESCRIPTION
       Koha preferences are stored in a data structure found in
       koha-tmpl/intranet-tmpl/en/module/admin/preferences/ files.
       Depending of user language, other files are used. This script extract text
       from ’en’ preference files, and put them in one .po file.  This .po
       file can be updated. When completed, a .po file can be applied to create
       localized versions of preferences templates.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFrench .po file for preferences
Frédéric Demians [Thu, 11 Feb 2010 06:27:46 +0000 (07:27 +0100)]
French .po file for preferences

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoremove unconditional warn
Galen Charlton [Thu, 11 Feb 2010 03:51:51 +0000 (22:51 -0500)]
remove unconditional warn

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoReformat Keyword to MARC mapping interface according to existing patterns
Owen Leonard [Wed, 10 Feb 2010 18:30:11 +0000 (13:30 -0500)]
Reformat Keyword to MARC mapping interface according to existing patterns

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4153 move messages on inventory tool to top
Nicole Engard [Sat, 6 Feb 2010 05:50:01 +0000 (00:50 -0500)]
bug 4153 move messages on inventory tool to top

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 3920 follow-up: tweak wording of staff XSLT* sysprefs
Galen Charlton [Thu, 11 Feb 2010 03:40:11 +0000 (22:40 -0500)]
bug 3920 follow-up: tweak wording of staff XSLT* sysprefs

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoAdditional changes to fix Bug 3920, XSLTdetailDisplay syspref controls both OPAC...
Owen Leonard [Wed, 10 Feb 2010 17:04:51 +0000 (12:04 -0500)]
Additional changes to fix Bug 3920, XSLTdetailDisplay syspref controls both OPAC and Intranet

This patch adds XSLTDetailsDisplay and XSLTResultsDisplay variables
for the staff client, OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay
variables to the OPAC. Note that the XSLTResultsDisplay doesn't actually
do anything because no one has added an XSLT version of search results
to the staff client.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBugfix: Removing useless lines from patroncards/manage.pl
Chris Nighswonger [Wed, 10 Feb 2010 17:21:27 +0000 (12:21 -0500)]
Bugfix: Removing useless lines from patroncards/manage.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoadd patron card help files
Nicole Engard [Sat, 6 Feb 2010 05:40:54 +0000 (00:40 -0500)]
add patron card help files

there are still more to add, but these are what I have written so far

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoupdated help files
Nicole Engard [Sat, 6 Feb 2010 06:24:31 +0000 (01:24 -0500)]
updated help files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 2505 adding use warnings to edithelp.pl
Chris Cormack [Wed, 10 Feb 2010 21:09:34 +0000 (10:09 +1300)]
Bug 2505 adding use warnings to edithelp.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 2505 adding use warnings, also added missing copyright statement
Chris Cormack [Wed, 10 Feb 2010 21:09:35 +0000 (10:09 +1300)]
Bug 2505 adding use warnings, also added missing copyright statement

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 2505: Enables warnings in matching-rules.pl.
Garry Collum [Thu, 11 Feb 2010 02:24:48 +0000 (21:24 -0500)]
Bug 2505: Enables warnings in matching-rules.pl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 3797, second part of the patch, extending output_html_with_http_headers to take...
Chris Cormack [Fri, 20 Nov 2009 01:50:02 +0000 (14:50 +1300)]
Bug 3797, second part of the patch, extending output_html_with_http_headers to take a status parameter (optional)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 3797 output 404 error page with a 404 header
Chris Cormack [Fri, 20 Nov 2009 01:32:22 +0000 (14:32 +1300)]
Bug 3797 output 404 error page with a 404 header

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4152: fixed template so that barcode file uploads work
Galen Charlton [Wed, 10 Feb 2010 18:32:18 +0000 (13:32 -0500)]
bug 4152: fixed template so that barcode file uploads work

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4152: fixed call to GetItemsForInventory()
Galen Charlton [Wed, 10 Feb 2010 17:42:40 +0000 (12:42 -0500)]
bug 4152: fixed call to GetItemsForInventory()

Restores ability to run a report of items for inventory.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFix for Bug 3730 - Wrong ISO 639-2 Language Code for Portuguese in database
Chris Cormack [Fri, 23 Oct 2009 22:30:37 +0000 (11:30 +1300)]
Fix for Bug 3730 - Wrong ISO 639-2 Language Code for Portuguese in database

[Patch originally by Ricardo Dias Marques]

Bug 3730 - Wrong ISO 639-2 Language Code for Portuguese in database
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3730

For 3.0.x head of the Git branch, the ISO 639-2 Language Code for
Portuguese in Koha database is wrong.

Specifically, in the table "language_rfc4646_to_iso639", when the
field "rfc4646_subtag" has the value "pt", the field "iso639_2_code"
should have the value of "por" and NOT the current one of "pol"
("pol" refers to "Polish" as correctly also appears for the code "pl",
in the row above the "pt" one).

In my test setups, this showed some serious sequences for people
that choose the Portuguese language in the Web Installer, namely:
- very weird look of Staff client with missing Header and Footer,
that renders the Staff client unusable
- Portuguese translation apparently not getting updated for the OPAC
(for people that do an Upgrade from a previous version)

This patch is for the 3.0.x branch (I tested it with that branch).

For the master branch, I don't have a database setup to create and
test a similar patch but Chris Cormack nicely volunteered to do that.
Thanks Chris!

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug Fixing : 3640
Henri-Damien LAURENT [Fri, 25 Sep 2009 01:09:30 +0000 (03:09 +0200)]
bug Fixing : 3640

This patch filters all non itemrelated fields in the marcrecord before making update

AddItemhad the same problem as ModItem
They would try and take fields which would not be item fields

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFixes a typo in marc21_field_008.pl
Magnus Enger [Mon, 2 Nov 2009 20:30:43 +0000 (21:30 +0100)]
Fixes a typo in marc21_field_008.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4122: make WebBasedSelfCheck functional
Galen Charlton [Wed, 10 Feb 2010 12:11:17 +0000 (07:11 -0500)]
bug 4122: make WebBasedSelfCheck functional

The WebBasedSelfCheck preference is now functional - if a user
tries to use /cgi-bin/koha/sco/sco-main.pl if the preference
is not on, they get redirected to the OPAC home page.

Also, the patron image web service now returns HTTP 403 (forbidden) unless
both WebBasedSelfCheck and ShowPatronImageInWebBasedSelfCheck are on.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 3893 : No way to see late orders
Henri-Damien LAURENT [Wed, 10 Feb 2010 13:05:54 +0000 (14:05 +0100)]
bug 3893 : No way to see late orders

When no lateorders were found, there was no way to change the limit in order to check for older orders

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobugs 3912, 4144: can now add contracts if dataformat is not metric
Galen Charlton [Wed, 10 Feb 2010 13:31:45 +0000 (08:31 -0500)]
bugs 3912, 4144: can now add contracts if dataformat is not metric

Fixed bug in date validation that prevented adding new contracts
if the dateformat syspref was set to something other than 'metric'.

In process, also removed three hand-written date validation routines
in favor of using JavaScript Date objects and the Date_from_syspref
function provided in calendar.inc.

This fixes bug 3912, and partially addresses bug 4144.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoremoving test.pl
Galen Charlton [Wed, 10 Feb 2010 11:27:30 +0000 (06:27 -0500)]
removing test.pl

Following up on patch submitted by Colin Campbell, convinced
myself that this was a throwaway test script comitted in error.
Since it isn't of use otherwise, I've elected to remove it
instead of moving it to misc/split_test.pl as Colin proposes.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 3162 Fix only for [forward port of tempoary fix 3.0.x]
Zeno Tajoli [Sun, 17 May 2009 21:26:17 +0000 (23:26 +0200)]
Bug 3162 Fix only for [forward port of tempoary fix 3.0.x]

Note that this patch causes the authority subfield visibility
to match 3.0.x, but at a cost - only two options are available now,
hide all and show all, and much flexibility is lost.  This will
need to be improved.

(cherry picked from commit 56831089ed654190a6b64265e75179957c044309)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 3860: Can't expand authorities.
Garry Collum [Tue, 9 Feb 2010 20:09:41 +0000 (15:09 -0500)]
Bug 3860: Can't expand authorities.

Adds a link to the Authority tag to expand the fields if advancedMARCeditor is in "Don't display" mode.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 4147 Correct name of external javascript file
Colin Campbell [Wed, 10 Feb 2010 09:56:36 +0000 (09:56 +0000)]
Bug 4147 Correct name of external javascript file

An earlier patch inadvertantly reverted a name change in the template

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobugfix Dates.t test plan has wrong value
Colin Campbell [Wed, 10 Feb 2010 08:58:05 +0000 (08:58 +0000)]
bugfix Dates.t test plan has wrong value

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 4145 - fix typo in sysprefs.sql
Galen Charlton [Tue, 9 Feb 2010 18:54:29 +0000 (13:54 -0500)]
bug 4145 - fix typo in sysprefs.sql

Fixed following error during new en installation:

ERROR 1064 (42000) at line 217: You have an error in your SQL syntax;
check the manual that corresponds to your MySQL server version for the right
syntax to use near ''XSLTDetailsDisplay','0','','Enable XSL stylesheet control
over details page dis' at line 1

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBugfix: Uncommenting pagination code
Chris Nighswonger [Tue, 9 Feb 2010 13:35:58 +0000 (08:35 -0500)]
Bugfix: Uncommenting pagination code

Pagination code was commented out during development causing the
spill over page one to be wrapped back onto page one. This patch
fixes that problem.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 2505 Enabled warnings in authorities/*
Colin Campbell [Fri, 2 Oct 2009 11:22:47 +0000 (12:22 +0100)]
Bug 2505 Enabled warnings in authorities/*

Fixed obvious warnings generators in scripts
with mismatched comparisons or undefined variables
removed temporary variable selected while ensuring the
comparison it represented was between two defined variables

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 3700 Parameters passed in wrong sequence
Colin Campbell [Fri, 9 Oct 2009 11:23:54 +0000 (12:23 +0100)]
Bug 3700 Parameters passed in wrong sequence

As subsequent operations don't get what they expect
all manner of nastiness ensues

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoadd PTFS-Europe as a contributing company
Colin Campbell [Thu, 17 Sep 2009 09:38:14 +0000 (10:38 +0100)]
add PTFS-Europe as a contributing company

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoEnable warnings in koha2marclinks.pl
Colin Campbell [Thu, 1 Oct 2009 10:27:51 +0000 (11:27 +0100)]
Enable warnings in koha2marclinks.pl

Fix code generating warnings with warnings enabled

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoEnable warnings in marctagstructure.pl
Colin Campbell [Thu, 1 Oct 2009 10:28:24 +0000 (11:28 +0100)]
Enable warnings in marctagstructure.pl

Fix a couple of comparisons generating warnings

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 3723 Correct return of Institution in Patron Info Resp
Colin Campbell [Wed, 21 Oct 2009 08:54:18 +0000 (09:54 +0100)]
Bug 3723 Correct return of Institution in Patron Info Resp

While the comment correctly notes that the order of variable length
fields is not fixed some units expect mandatory fields to
follow the sequence in the protocol definition and fail
parsing otherwise. Moved institution id to its expected
place in the patron information response.

Indented the first half of the if (patron_valid) so its clearer
that two cases are handled here.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years ago(Bug 3767 - Return error if checkin passed an invalid item
Colin Campbell [Wed, 4 Nov 2009 21:15:55 +0000 (21:15 +0000)]
(Bug 3767 - Return error if checkin passed an invalid item

If an invalid item barcode is passed to checkin
the sip2 connection dies. This is because although
no item object is created its mehods are called in Checkin
To maintain the connection properly catch the condition
and return the correct response to the unit
(should also fix Bug #3696 )

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoDB rev 116 - finish fixing default value of OrderPdfFormat
Galen Charlton [Tue, 9 Feb 2010 02:14:12 +0000 (21:14 -0500)]
DB rev 116 - finish fixing default value of OrderPdfFormat

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>