]> git.koha-community.org Git - koha.git/log
koha.git
16 years agoFix for Bug 1955: Remove noOPACUserLogin system preference
Joshua Ferraro [Tue, 20 May 2008 00:11:19 +0000 (19:11 -0500)]
Fix for Bug 1955: Remove noOPACUserLogin system preference

16 years agoFix for bug 1952: OPACUserCSS preference has incorrect description
Joshua Ferraro [Tue, 20 May 2008 00:05:44 +0000 (19:05 -0500)]
Fix for bug 1952: OPACUserCSS preference has incorrect description

16 years agocorrect path to 404.pl in opac-details.pl
Galen Charlton [Mon, 19 May 2008 19:28:37 +0000 (14:28 -0500)]
correct path to 404.pl in opac-details.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2141 - avoid carp on display of details of deleted bib
Galen Charlton [Mon, 19 May 2008 19:28:36 +0000 (14:28 -0500)]
kohabug 2141 - avoid carp on display of details of deleted bib

When displaying details of bib in staff interface, check
that bib actually exists and display 404 page if not.  Avoids
following fatal error:

Can't call method "field" on an undefined value at /home/gmc/koha/dev/C4/Biblio.pm line 944.

This situtation can arise when running Zebra; if a bib is deleted,
Zebra will not necessarily be reindexed instantly, allowing a link
from a search result list to point to a missing record.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agominor POD improvement
Galen Charlton [Mon, 19 May 2008 19:28:35 +0000 (14:28 -0500)]
minor POD improvement

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBUGFIX - pagination bar was not in template, so only the first 20 hits were
Joe Atzberger [Mon, 19 May 2008 20:36:37 +0000 (15:36 -0500)]
BUGFIX - pagination bar was not in template, so only the first 20 hits were

 pagination bar was not in template, so only the first 20 hits were
 visible.  Probably it wasn't included because the script referenced a bogus base URL.
 Also debugified warn statement in script.  Note FIXME for bogus template reference.
 We probably don't need that template or the related selector lines for it.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdding RenewSerialAddsSuggestion syspref to Acquisitions tab
Joshua Ferraro [Mon, 19 May 2008 20:27:21 +0000 (15:27 -0500)]
Adding RenewSerialAddsSuggestion syspref to Acquisitions tab

16 years agotest suite: allow skipping of expensive tests
Galen Charlton [Mon, 19 May 2008 14:59:02 +0000 (09:59 -0500)]
test suite: allow skipping of expensive tests

Defined a function attribute for KohaTest and subclasses
called 'Expensive'.  When a test method has that attribute,
it is skipped unless the RUN_EXPENSIVE_TESTS environment
variable is true.

To mark a test method, expensive, do this:

sub test_foo : Tests(4) Expensive { ... }

To mark a whole class and its subclasses expensive,
define a SKIP_CLASS sub (with empty body) with the
Expensive attribute:

sub SKIP_CLASS : Expensive { }

Updated the t/Makefile so that 'make test' runs
nonexpensive tests, while 'make fulltest' runs both
cheap and expensive tests.

Marked KohaTest::Installer test class expensive.

Signed-off-by: Andrew Moore <andrew.moore@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoCSS fix for Internet Explorer display problem caused by previous commit.
Owen Leonard [Mon, 19 May 2008 15:05:04 +0000 (10:05 -0500)]
CSS fix for Internet Explorer display problem caused by previous commit.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoTemplate restructuring to allow option of styling OPAC with fixed-width layout. This...
Owen Leonard [Mon, 19 May 2008 14:34:59 +0000 (09:34 -0500)]
Template restructuring to allow option of styling OPAC with fixed-width layout. This commit doesn't change the default OPAC appearance.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdding padding to <p> to improve some readability issues; Correcting terminology...
Owen Leonard [Mon, 19 May 2008 14:34:46 +0000 (09:34 -0500)]
Adding padding to <p> to improve some readability issues; Correcting terminology in the cart (shelf -> list); Minor punctuation change in results.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoA couple of fixes: Logs tab was not highlighted when chosen; Serials checkexpiration...
Owen Leonard [Mon, 19 May 2008 14:34:16 +0000 (09:34 -0500)]
A couple of fixes: Logs tab was not highlighted when chosen; Serials checkexpiration.pl linked to biblio detail rather than subscription detail. Also adding 'edit' and 'renew' links to those results.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoTrying again to fix tab issues in Internet Explorer.
Owen Leonard [Mon, 19 May 2008 14:34:04 +0000 (09:34 -0500)]
Trying again to fix tab issues in Internet Explorer.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMinor updates to XSL display
Joshua Ferraro [Mon, 19 May 2008 18:05:49 +0000 (14:05 -0400)]
Minor updates to XSL display

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoEnhancement Jacket Covers in Shelf Browser should link to bib record, not to source...
Joshua Ferraro [Sun, 18 May 2008 12:02:11 +0000 (08:02 -0400)]
Enhancement Jacket Covers in Shelf Browser should link to bib record, not to source of image

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFixing isbn regex to not match unless isbn is valid
Joshua Ferraro [Sun, 18 May 2008 11:37:59 +0000 (07:37 -0400)]
Fixing isbn regex to not match unless isbn is valid

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoDon't display Acquisitions and Serials links if the user
Joshua Ferraro [Mon, 19 May 2008 18:01:04 +0000 (13:01 -0500)]
Don't display Acquisitions and Serials links if the user
doesn't have permission to view them

16 years agoAdding pipe (|) as delimitor option
Joshua Ferraro [Mon, 19 May 2008 16:34:12 +0000 (11:34 -0500)]
Adding pipe (|) as delimitor option

16 years agoFix links for web resources to display a 'Click here to access online' when no label...
Koha Production [Sun, 18 May 2008 03:39:26 +0000 (23:39 -0400)]
Fix links for web resources to display a 'Click here to access online' when no label is specified (XSLT only). Note that on the results screen, the links now show up in place of the Availability: section

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFixing Literary Form: display for Sound records
Koha Production [Sun, 18 May 2008 01:56:29 +0000 (21:56 -0400)]
Fixing Literary Form: display for Sound records

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoRemoving bib-level Call Number from display -- can be added to XSL based on library...
hcpl test [Sun, 18 May 2008 01:42:32 +0000 (21:42 -0400)]
Removing bib-level Call Number from display -- can be added to XSL based on library preferences if desired

Signed-off-by: Koha Production <koha-pro@koha-01.hclibrary.org>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFixing Amazon.com Similar Items and Editions features
Joshua Ferraro [Sun, 18 May 2008 01:35:48 +0000 (21:35 -0400)]
Fixing Amazon.com Similar Items and Editions features

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdding wrapping container around OpacMainUserBlock syspref
Joshua Ferraro [Sat, 17 May 2008 23:49:26 +0000 (18:49 -0500)]
Adding wrapping container around OpacMainUserBlock syspref

16 years agoFix bug in /admin/z3950servers.pl
Frederic Demians [Sat, 17 May 2008 21:23:12 +0000 (23:23 +0200)]
Fix bug in /admin/z3950servers.pl

Third attempt to correct a bug affecting this page.
Combo lists wasn't reflecting DB content in modification.
To Joshua: You have to apply patch 2 first (patch 1 isn't required)
since I applied this quick fix without rolling back to original state!

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFix bug in /admin/z3950servers.pl
Frederic Demians [Sat, 17 May 2008 20:08:35 +0000 (22:08 +0200)]
Fix bug in /admin/z3950servers.pl

Improve previous patch which was badly coded as pointed out by
Henri-Damien. <TMPL_IF> clauses were included in HTML tags:
it fails translator tool.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFix a bug in /admin/z3950servers.pl page
Frederic Demians [Sat, 17 May 2008 10:55:24 +0000 (12:55 +0200)]
Fix a bug in /admin/z3950servers.pl page

On /admin/z3950servers.pl page, modifying a z3950 host wasn't working
properly. Selected values in Syntax and Encoding combo boxes were hard
coded rather than selected based on record values.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agochanging defaults for french system preferences.
Marc Chantreux [Fri, 16 May 2008 11:25:27 +0000 (13:25 +0200)]
changing defaults for french system preferences.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug Fixing : ModMember and memberentrygen.tmpl
Henri-Damien LAURENT [Fri, 16 May 2008 08:03:16 +0000 (10:03 +0200)]
Bug Fixing : ModMember and memberentrygen.tmpl

Problem with ModMember : parameters were not passed safely
memberentrygen.tmpl deleted guarantorid for a children if step2 or step3 used fore edition.
Changeing TMPL_IF EXPR into TMPL_IF Name

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAltering CSS to make holding table on opac MARC view more compact. Adding "new" link...
Owen Leonard [Thu, 15 May 2008 19:40:26 +0000 (14:40 -0500)]
Altering CSS to make holding table on opac MARC view more compact. Adding "new" link to opac suggestions screen for display when there are no suggestions (Bug 2110 Can't place suggestion from my suggestions tab in OPAC)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoFix for problem introduced by previous attempt to fix Internet Explorer issues. Previ...
Owen Leonard [Thu, 15 May 2008 19:40:18 +0000 (14:40 -0500)]
Fix for problem introduced by previous attempt to fix Internet Explorer issues. Previous fix caused drop-down menu to appear behind circ search form.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobugfix - fix 'not' operator in NoZebra
Galen Charlton [Wed, 14 May 2008 22:09:43 +0000 (17:09 -0500)]
bugfix - fix 'not' operator in NoZebra

Corrected bug that prevented the 'not' operator
from working consistently - i.e., a search of
'mice not men' would not always work.

Also added test cases for NoZebra, so far focusing on
NZanalyse and adding and deleting bibs.  A couple of
the test cases are currently known to fail and
therefore are marked TODO.  The tests in question
are to verify that rows in nozebra are removed if
no bib is linked to the relevant word.  However, it
looks like such rows are retained, just with
nozebra.biblionubmers set to ''.  Is there any
reason to keep these rows?

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2020 - fix infinite loop in NoZebra on Perl 5.10
Galen Charlton [Wed, 14 May 2008 22:09:42 +0000 (17:09 -0500)]
kohabug 2020 - fix infinite loop in NoZebra on Perl 5.10

When running Koha in NoZebra mode under Perl 5.10, a search
containing a operator (e.g., "mice and men") could cause
a bib search to enter into an infinite loop in NZanalyse.

This possibility arises from the fact that NZanalyse used
to use capture variables from regular expressions without
verifying whether the regular expressions actually matched.
It was compounded by the fact that NZanalyse is recursive;
however, because $1, $2, etc. are dynamically scoped,
*they are not automatically cleared when NZanalyse calls
itself*.

Consequently, if the search string contains a boolean
operator, it would be split into

left = mice
operator = and
right = men

Then NZanalyse would be called recursively on the search
string 'mice'.  However, because $1, $2, and $3 are not
automatically cleared when the function is called again,
and because they are not cleared if a match fails, the code
would fail to recognize that 'mice' is leaf, and would
call NZanalyse('mice') repeatedly, to the promotion of
warm server rooms.

The wrinkle in this is that because of a bug in Perl 5.8, a
failing matches can sometimes alter the capture variables, thus
avoiding the infinite recursion.  However,  this bug was fixed in
Perl 5.10, leading to the NZanalyse bug becoming evident.

The Perl bug is described at http://rt.perl.org/rt3/Public/Bug/Display.html?id=19049
and the fix http://public.activestate.com/cgi-bin/perlbrowse/p/29279.

The fix to the Koha code is to check whether each regexp
that uses capture variables matches or fails, then act
accordingly.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2100 - allow deletion of non-default MARC framework
Galen Charlton [Wed, 14 May 2008 22:09:41 +0000 (17:09 -0500)]
kohabug 2100 - allow deletion of non-default MARC framework

An earlier attempt to prevent deletion of default framework
by passing a suitably constructured URL actually had
the opposite effect - the default framework could be deleted,
but ia hon-default one could not.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdd HTML::Scrubber dependency to Makefile.PL
Joe Atzberger [Wed, 14 May 2008 16:07:39 +0000 (11:07 -0500)]
Add HTML::Scrubber dependency to Makefile.PL

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBugfix ShelfBrowser using unsanitized ISBNs. Owen reported the
Joe Atzberger [Wed, 14 May 2008 16:07:38 +0000 (11:07 -0500)]
Bugfix ShelfBrowser using unsanitized ISBNs. Owen reported the

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agounimarc_complet framework: put 801$a in tab 8
Galen Charlton [Mon, 12 May 2008 21:59:32 +0000 (16:59 -0500)]
unimarc_complet framework: put 801$a in tab 8

Put the 801$a in tab 8, not 0, so that a valid 801
does not get split by the bib editor.

Signoff from Paul or Henri-Damien requested before
committing this patch.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug 1953: removing potential SQL injections from C4::Calendar::_init
Andrew Moore [Tue, 13 May 2008 17:00:55 +0000 (12:00 -0500)]
Bug 1953: removing potential SQL injections from C4::Calendar::_init

This patch changes the 4 select statements in C4::Calendar::_init.
tests for this method were included in a previous patch.

There are more potential problems in C4::Calendar::delete_holiday, but that
method seems to have deeper bugs than just these. I'll open another bug for
them if I can figure out how it's supposed to work.

No documentation changes necessary.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug 1953: adding tests and 2 corrections for C4::Calendar
Andrew Moore [Tue, 13 May 2008 17:00:54 +0000 (12:00 -0500)]
Bug 1953: adding tests and 2 corrections for C4::Calendar

In the course of writing tests for C4::Calendar, I found two bugs and am fixing them here.
One is a documentation bug.
The other prevented C4::Calendar::insert_exception_holiday from working. I was unable
to find anywhere else in the code that depended on the broken behaviour.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2105: prevent crash on IE7
Galen Charlton [Tue, 13 May 2008 21:40:15 +0000 (16:40 -0500)]
kohabug 2105: prevent crash on IE7

Three scripts were incorrect setting the HTTP type
header to 'utf-8' instead of something appropriate
like 'text/html' - Firefox evidentally can ignore that
mistake, but IE7 does not.

Fixed by replacing an invalid print of the HTTP header
and template output with a call to
C4::Output::output_html_with_http_headers.

Also corrected POD in C4::Auth and InstallAuth to
reflect correct use of output_html_with_http_headers.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 1621 - add subtitle to main results and details pages
Galen Charlton [Tue, 13 May 2008 17:32:06 +0000 (12:32 -0500)]
kohabug 1621 - add subtitle to main results and details pages

Including the subtitle in search results and OPAC and staff
details templates.  The subtitle is expected to be in the
MARC subfield that is mapped to the (now nonexistant) column
bibliosubtitle.subtitle.

This is a fairly hackish patch that is meant to be minimally
disruptive while allowing subtitles to be displayed for those
not using the experimental XSLT bib display feature.  It
does *not* cover all cases where you have a MARC
record and want to display its subtitle.

UNIMARC notes: at the moment, none of the fr-FR UNIMARC
frameworks appear to be map any subfields to bibliosubtitle.subtitle.
This could be changed, but caveat programmer: the UNIMARC 200$e
is repeatable (meaning that get_koha_field_from_marc will put in ' | '
between multiple subtitles) and one may want to also include the
200$d (parallel title).  A GetMarcSubtitle routine may be in order
if absolutely necessary.

This points to a long-term need to make display of MARC (and later, hopefully,
non-MARC) bib records more flexible - the XSLT feature is one approach;
there may be others.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agopatron cleaning - do not delete staff borrowers
Galen Charlton [Tue, 13 May 2008 15:56:49 +0000 (10:56 -0500)]
patron cleaning - do not delete staff borrowers

Adjusted C4::Members::GetBorrowersWhoHaveNotBorrowedSince so
that staff member records are not selected for deletion.

This functionality change is motivated by the consideration
that a staff member who is authorized to operate Koha is
not necessarily a prolific user of the library's services.
If a batch purge job for inactive staff records is really need,
it should be a separate tool.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 1573 - properly count patrons to delete
Galen Charlton [Tue, 13 May 2008 15:56:48 +0000 (10:56 -0500)]
kohabug 1573 - properly count patrons to delete

When both the patron delete and patron anonymize checkboxes
were selected, the patron cleaning tool would not
properly register the number of patrons to delete.  Fixed
by correcting form input handling.

Also, count of patrons to delete or anonymous now correct
when running with IndependentBranches = ON.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoRecent changes to YUI path preference require local OPAC copies of YUI library files.
Owen Leonard [Tue, 13 May 2008 13:51:28 +0000 (08:51 -0500)]
Recent changes to YUI path preference require local OPAC copies of YUI library files.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobugfixing pending reserves
Paul POULAIN [Tue, 13 May 2008 13:17:23 +0000 (15:17 +0200)]
bugfixing pending reserves

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdding COinS markup to shelves and results.
Owen Leonard [Tue, 13 May 2008 12:41:40 +0000 (07:41 -0500)]
Adding COinS markup to shelves and results.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoSwapping tablesorter version. GZipped version may have been responsible for errors...
Owen Leonard [Tue, 13 May 2008 12:41:31 +0000 (07:41 -0500)]
Swapping tablesorter version. GZipped version may have been responsible for errors in Internet Explorer. Change to usermenu.inc is whitespace only, for proper display in IE.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years ago(bugfix, CRI) Permission needed is acquisition, not acquisitionS
Paul POULAIN [Tue, 13 May 2008 08:19:20 +0000 (10:19 +0200)]
(bugfix, CRI) Permission needed is acquisition, not acquisitionS

+ i've added 'intranet' to reach intranet error page, not OPAC one (which is the default when no type specified)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2017: ensure MARC21 $9 are in correct bib editor tab
Galen Charlton [Mon, 12 May 2008 21:59:35 +0000 (16:59 -0500)]
kohabug 2017: ensure MARC21 $9 are in correct bib editor tab

Update MARC21 bib framework to ensure that subfield $9 in  110,
110, 111, 130, 240, 243, 440, 410, 411, and 440 remain
in same bib editing tab as rest of subfields in those fields.

This helps ensure that authority-controlled fields are not
mangled when editing a bib record.

Change also fixes editing tab for subfields in the 037, 584, and
760.

This is DB rev 085.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdding RenewalAddsSuggestion systempreference to sql files.
Henri-Damien LAURENT [Mon, 12 May 2008 21:59:34 +0000 (16:59 -0500)]
Adding RenewalAddsSuggestion systempreference to sql files.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMARC21 frameworks: keep a tag's subfields in the same tab
Galen Charlton [Mon, 12 May 2008 21:59:31 +0000 (16:59 -0500)]
MARC21 frameworks: keep a tag's subfields in the same tab

Changed default mandatory and optional MARC21 frameworks
to ensure that all the subfields of 037, 100, 110, 111, 130,
240, 243, 400, 410, 411, 440, 584, and 760 are all either
ignored (tab = -1) or assigned to the same editing tab.

Most of these changes involve the subfield $9 in authority-controlled
fields, which for the affected 1xx, 2xx, and 4xx fields was assigned
to tab 6, not 1, 2, or 4.  Because of this, any such field with a
$9 was effectively split, leading to record corruption.

This is part of the fix for bug 2017.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofixed typo in MARC framework test: "Codek" => "Code"
Galen Charlton [Mon, 12 May 2008 21:59:30 +0000 (16:59 -0500)]
fixed typo in MARC framework test: "Codek" => "Code"

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMARC framework test - tests all frameworks
Galen Charlton [Mon, 12 May 2008 21:59:29 +0000 (16:59 -0500)]
MARC framework test - tests all frameworks

Changed some of the tests so that all frameworks
are tested, not just the first row.

This patch has turned up a reported error in the
unimarc_lecture_pub - items.homebranch
and items.holdinbranch for the WEB framework are
in tab -1 (i.e., ignored), but the check is expecting
them in tab 10.  Not sure if this is a real error or not:
perhaps no items should be created for bibs in that framework;
on the other hand, it is still possible to do so, in which
case the branches need to be set.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoIncrementing to 084 -- adding GoogleJackets syspref
Joshua Ferraro [Tue, 13 May 2008 21:56:23 +0000 (16:56 -0500)]
Incrementing to 084 -- adding GoogleJackets syspref

16 years agoAdding RenewalAddsSuggestion systempreference to sql files.
Henri-Damien LAURENT [Mon, 12 May 2008 20:48:15 +0000 (22:48 +0200)]
Adding RenewalAddsSuggestion systempreference to sql files.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdding Optionnal suggestion creation when renewing subscription.
Henri-Damien LAURENT [Mon, 12 May 2008 20:48:14 +0000 (22:48 +0200)]
Adding Optionnal suggestion creation when renewing subscription.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoIncrement DB update 083
Joshua Ferraro [Mon, 12 May 2008 20:50:26 +0000 (15:50 -0500)]
Increment DB update 083

16 years agoyuipath : sysprefs changes only 2a/2
Henri-Damien LAURENT [Mon, 12 May 2008 20:33:48 +0000 (22:33 +0200)]
yuipath : sysprefs changes only 2a/2

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agochange in yuipath management 1/2 Noupdatedatabase.pl
Henri-Damien LAURENT [Mon, 12 May 2008 20:27:49 +0000 (22:27 +0200)]
change in yuipath management 1/2 Noupdatedatabase.pl

now yuipath is added in C4::Output and uses themelang
In my opinion, all the general variables that are used in output should get in C4::Output (since there is theme lang computed.)
rather than in C4::Auth

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug 1953: fixing potential SQL injection problems in C4::Branch::GetBranches
Andrew Moore [Mon, 12 May 2008 19:34:44 +0000 (14:34 -0500)]
bug 1953: fixing potential SQL injection problems in C4::Branch::GetBranches

I moved C4::Branch::GetBranches to use bind parameters and wrote some tests to demonstrate functionality.

No functional or documentation changes here.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofixed potential SQL error in fr-FR sample itemtypes
Galen Charlton [Mon, 12 May 2008 16:41:59 +0000 (11:41 -0500)]
fixed potential SQL error in fr-FR sample itemtypes

There is nothing to prevent a user from loading the
sample itemtypes from both 3-LecturePub and 4-Conservation.

To avoid an SQL error (and to let the installer tests
pass), made two of the SQL inserts "INSERT IGNORE" for
sample item types that have the same key.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofixed SQL error in sample labels scripts
Galen Charlton [Mon, 12 May 2008 16:41:58 +0000 (11:41 -0500)]
fixed SQL error in sample labels scripts

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofix SQL error in unimarc_lecture_pub fr-FR MARC framework
Galen Charlton [Mon, 12 May 2008 16:41:57 +0000 (11:41 -0500)]
fix SQL error in unimarc_lecture_pub fr-FR MARC framework

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofixed installer test
Galen Charlton [Mon, 12 May 2008 16:41:56 +0000 (11:41 -0500)]
fixed installer test

Now handles cases where two SQL scripts in different
directories have the same name, e.g., fr-FR sample_itemtypes.sql.
Bug was masked by existing failure when attempting to load
both sample_itemtypes.sql.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobug Fixing 2081
Henri-Damien LAURENT [Tue, 6 May 2008 15:27:32 +0000 (17:27 +0200)]
bug Fixing 2081

Editing authorisedvalue now checks if OTHER value has the same authorised_value
before storing
id is now passed to the form so that it is used when editing authorised_value
when imageurl it is passed as '' not empty parameter

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofrench translation updated
Paul POULAIN [Mon, 12 May 2008 12:56:51 +0000 (14:56 +0200)]
french translation updated

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobugfix : librarian name was libxxx, not lib.xxx
Paul POULAIN [Mon, 12 May 2008 12:56:50 +0000 (14:56 +0200)]
bugfix : librarian name was libxxx, not lib.xxx

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agobugfix : ship utf-8 encoding in mail header
Paul POULAIN [Mon, 12 May 2008 12:56:49 +0000 (14:56 +0200)]
bugfix : ship utf-8 encoding in mail header

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years ago(bugfix) focusing on barcode for returns
Paul POULAIN [Mon, 12 May 2008 12:56:48 +0000 (14:56 +0200)]
(bugfix) focusing on barcode for returns

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoHiding empty results table when there are no results (prevents js error from tablesor...
Owen Leonard [Mon, 12 May 2008 12:58:27 +0000 (07:58 -0500)]
Hiding empty results table when there are no results (prevents js error from tablesorter). Now links back to search form. Also includes minor CSS tweak for IE/Opera general layout problems.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdding check all/none controls to opac suggestions, following opac shelves interface.
Owen Leonard [Mon, 12 May 2008 12:58:10 +0000 (07:58 -0500)]
Adding check all/none controls to opac suggestions, following opac shelves interface.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAdding checks for dateformat preference so that tablesorter script can be passed...
Owen Leonard [Mon, 12 May 2008 12:58:00 +0000 (07:58 -0500)]
Adding checks for dateformat preference so that tablesorter script can be passed an extra parameter for proper sorting of metric dates (Bug 2089, dates & table ordering with jquery)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug Fixing : overduenotices wrote a file on disk before sending to browser
Henri-Damien LAURENT [Wed, 7 May 2008 14:32:49 +0000 (16:32 +0200)]
Bug Fixing : overduenotices wrote a file on disk before sending to browser

this script had quite serious issues :
- it would not use mindays and maxdays variables
- It would send latin1 where utf8 was expected
- It would send data without text delimiters (; was chosen if title contains ; it would have been a problem " used as delimiters now)
- It would write a file when it was not asked
Now stores the results in a string before printing it.
New option added to store result into a file : -o filename

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug fixing on overdues.tmpl : branchnames were not displayed
Henri-Damien LAURENT [Wed, 7 May 2008 09:19:24 +0000 (11:19 +0200)]
Bug fixing on overdues.tmpl : branchnames were not displayed

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoclose security holes in patron search autocompletion
Galen Charlton [Mon, 12 May 2008 15:01:10 +0000 (10:01 -0500)]
close security holes in patron search autocompletion

* Added authorization check - user must have a valid
  session cookie to use this feature; before this change,
  anybody could use circ/ysearch.pl to retrieve the entire
  patron directory without authorization.
* (bug 1953) now uses SQL placeholders

Note: this does, unfortunately, noticeably slow down automcompletion;
this indicates a need for factoring of C4::Auth to make authentication
for AJAX scripts as fast as possible.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBug Fixing 1782 patch
Henri-Damien LAURENT [Mon, 12 May 2008 14:29:45 +0000 (16:29 +0200)]
Bug Fixing 1782 patch

Adding a new routine GetBorrowercategoryList in C4/Member
Displaying categoryname when listing categories in memberentrygen.pl
using categorytype returned with GetMember wherever it is possible.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoIncrementing DB revision 081
Joshua Ferraro [Mon, 12 May 2008 14:36:13 +0000 (09:36 -0500)]
Incrementing DB revision 081

16 years agoDB Update 77 : add lastincrement column to accountlines
Ryan Higgins [Mon, 12 May 2008 10:29:37 +0000 (05:29 -0500)]
DB Update 77 : add lastincrement column to accountlines

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agofix error on lastincrement.
Ryan Higgins [Mon, 12 May 2008 10:41:25 +0000 (05:41 -0500)]
fix error on lastincrement.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoC4::Circulation::FixOverduesOnReturn now handles dropbox mode.
Ryan Higgins [Mon, 12 May 2008 10:29:38 +0000 (05:29 -0500)]
C4::Circulation::FixOverduesOnReturn now handles dropbox mode.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoMake dropbox mode obey Calendar module according to CircControl branch.
Ryan Higgins [Mon, 12 May 2008 10:29:36 +0000 (05:29 -0500)]
Make dropbox mode obey Calendar module according to CircControl branch.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAlter Overdues::CalcFine to use Dates objects.
Ryan Higgins [Mon, 12 May 2008 10:29:35 +0000 (05:29 -0500)]
Alter Overdues::CalcFine to use Dates objects.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoshow correct effective checkin date in dropbox mode.
Ryan Higgins [Mon, 12 May 2008 10:29:34 +0000 (05:29 -0500)]
show correct effective checkin date in dropbox mode.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoadjust dropboxdate to allow for holidays calendar.
Ryan Higgins [Mon, 12 May 2008 10:29:33 +0000 (05:29 -0500)]
adjust dropboxdate to allow for holidays calendar.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoC4::Calendar::addDate now handles negative offsets properly.
Ryan Higgins [Mon, 12 May 2008 10:29:32 +0000 (05:29 -0500)]
C4::Calendar::addDate now handles negative offsets properly.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAlter C4::Calendar::daysBetween() to take C4::Dates objects.
Ryan Higgins [Mon, 12 May 2008 10:29:31 +0000 (05:29 -0500)]
Alter C4::Calendar::daysBetween() to take C4::Dates objects.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBUGFIX (bloquing) moredetail & item edition
Paul POULAIN [Wed, 7 May 2008 17:15:53 +0000 (19:15 +0200)]
BUGFIX (bloquing) moredetail & item edition

this patch introduce the same behaviour as for additem.pl, ie : edit only own homebranch items, except for superlibrarians

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoBUGFIX : script to fix & fill onloan field in items table.
Paul POULAIN [Wed, 7 May 2008 17:15:52 +0000 (19:15 +0200)]
BUGFIX : script to fix & fill onloan field in items table.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoadjusted new C4::Scrubber test cases
Galen Charlton [Mon, 12 May 2008 14:18:04 +0000 (09:18 -0500)]
adjusted new C4::Scrubber test cases

Removed reference to override_context_prefs that
Andrew Moore had just factored out.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agopatron attributes - batch import
Galen Charlton [Mon, 12 May 2008 13:32:57 +0000 (08:32 -0500)]
patron attributes - batch import

When ExtendedPatronAttributes is ON, the batch
patron import tool's behavior changes as follows:

[1] A new (required) column is added to the input CSV
    format.  This column should contain a list of
    attributes to set for the record, each value
    preceded by its type code.  For example, if
    the superlibrarian has defined two types,
    a unique identifier INSTID and a repeatable
    BASEBALL, this field could contain:

    "INSTID:12345,BASEBALL:Cubs"

    This field must be wrapped in quotes if multiple
    values are defined.  Since values can contain
    spaces, additional doubled-quotes may be required:

    "INSTID:12345,BASEBALL:Cubs,""BASEBALL:White Sox"""

    When replacing a patron record, any attributes specified
    in the input file replace all of the attribute values
    of any type that were previously assigned to the patron
    record.

[2] It is possible to specify a field other than the
    cardnumber to use for looking for matching patrons.
    Specifically, any attribute marked as a unique ID
    can be used.  The operator is asked to specify
    which ID type to use; if an input record has an
    attribute value of that type, and exactly one patron
    record in the database has that value, then the
    record will be overlaid or ignored according to the
    overlay setting.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agopatron attributes - staff search and display
Galen Charlton [Mon, 12 May 2008 13:32:56 +0000 (08:32 -0500)]
patron attributes - staff search and display

If ExtendedPatronAttributes is ON, patron attributes
can be displayed and edited by staff members.

The patron attributes are displayed and edited
in a new section (step 4) of the patron details page.  Each
attribute is identified by its type (including type code
and type description) and value (included value description
if the attribute is controlled by an authorised value category).

Note: if, for a repeatable attribute type, the staff member
enters multiple copies of that type with the same value, duplicates
are removed when the patron record is saved.  Also, if the type
is repeatable, a JavaScript link allows the staff member to
create new attributes of that type.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agotemplate changes for OPAC display of patron attributes
Galen Charlton [Mon, 12 May 2008 13:32:55 +0000 (08:32 -0500)]
template changes for OPAC display of patron attributes

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agopatron attributes - OPAC display
Galen Charlton [Mon, 12 May 2008 13:32:54 +0000 (08:32 -0500)]
patron attributes - OPAC display

If ExtendedPatronAttributes is ON, any patron attributes
whose type is marked as displayble in the OPAC are now
displayed in the 'my details' page in the OPAC (assuming
that the patron is logged in).  These appear in the
'Library Use' section.

Currently, it is not possible for a patron to suggest
changes to any of their extended attributes using
opac-userupdate.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agocorrected base class of a test
Galen Charlton [Mon, 12 May 2008 13:32:53 +0000 (08:32 -0500)]
corrected base class of a test

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoC4::Members::SearchMember - support attributes
Galen Charlton [Mon, 12 May 2008 13:32:52 +0000 (08:32 -0500)]
C4::Members::SearchMember - support attributes

Modified SearchMember() so that if the patron attributes
feature is on (i.e., ExtendedPatronAttributes is ON), it
is possible to search for patrons on any attributes whose
type is set as staff searchable.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agonew editor for patron attribute types
Galen Charlton [Mon, 12 May 2008 13:32:51 +0000 (08:32 -0500)]
new editor for patron attribute types

Added new script under the Administration menu
to create, update, and delete patron attribute types.

Some things to note:

- once an attribute is created, its code cannot be changed
- the repeatibility and unique_id settings of an
  attribute type cannot be changed after creation -
  this is to avoid having to deal with changing
  constraints if an attribute type is already in use
  by patron records
- an attribute type cannot be deleted if it is
  used by any patron records
- this administration page is always displayed regardless
  of the value of the ExtendedPatronAttributes syspref.  If
  the syspref is off, the page will prompt the superlibrarian
  to turn it on if desired.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoC4::Koha - added GetAuthorisedValueCategories
Galen Charlton [Mon, 12 May 2008 13:32:50 +0000 (08:32 -0500)]
C4::Koha - added GetAuthorisedValueCategories

New convenience function to get list of authorised
value categories.

No user-visible changes.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agonew C4 modules for patron attributes
Galen Charlton [Mon, 12 May 2008 13:32:49 +0000 (08:32 -0500)]
new C4 modules for patron attributes

Two new modules to support patron attributes:

- C4::Members::AttributeTypes

  OO-module for managing patron attribute types.

- C4::Members::Attributes

  Procedural module for retrieving and setting
  extended attributes belonging to a patron.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoextended patron attributes tables & syspref (DB rev 081)
Galen Charlton [Mon, 12 May 2008 13:32:48 +0000 (08:32 -0500)]
extended patron attributes tables & syspref (DB rev 081)

Added two tables and system preference to support
a new patron alternate ID and attributes feature.

A patron attribute (or extended patron attribute) is an
additional piece of information associated with a patron
record.  Each attribute has a type that specifies
whether the attribute is repeatable, can serve as
a unique identifier, can take a password, and
whether it can be used to search for patron records
in the staff interface.

The list of attribute types is controlled by the
superlibrarian.  Once an attribute type is defined,
values for that attribute can be added to the patron record
via the staff interface or the batch patron import.

Two uses of extended attributes are:

- defining additional unique identifiers, such as
  a campus student ID number, a library staff
  HR number, and so on.  These IDs can be used
  for searching or matching and overlaying records
  during a batch import.
- additional statistical categories.  For example,
  a library could define an attribute type for
  tracking the academic major of a student patron.
  Any number of attributes of this sort could be
  defined.

The extended attributes feature is completely optional.  If
the new syspref, ExtendPatronAttributes, is OFF, the patron
attributes tables will be ignored; it will not be possible
to display, edit, search for, or match on extended
attributes.

The tables are:

[1] borrower_attribute_types - store attribute types
    defined by the administrator.

    - code
    - description
    - repeatable (whether a patron record can have
      more than value of a given attribute type)
    - unique_id (whether values of this type
      must be unique within the database)
    - opac_display (whether values of this type
      can display in the patron details page in the OPAC)
    - staff_searchable (whether values of this type
      can be used to retrieve patron records in circulation)
    - password_allowed (if set, staff patron editor will
      allow a password to be associated with a value; this
      is mostly a hook for functionality to be implemented
      in the future.
    - authorised_value_category (code of an authorised_value
      category.  If one is specified, the staff patron
      editor will use a dropdown for setting values of this type)
[2] borrower_attributes - the actual attributes.
    - code (attribute type code, FK)
    - borrowernumber (link to patron, FK)
    - attribute (the value)
    - password (password associated with value)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agokohabug 2076: more reconciliation of DB schema (DB rev 080)
Galen Charlton [Mon, 12 May 2008 13:32:47 +0000 (08:32 -0500)]
kohabug 2076: more reconciliation of DB schema (DB rev 080)

Adjustments to updatedatabase.pl to help ensure that a
DB upgraded from 2.2.9, 3.0-alpha, or 3.0-beta has a schema
identical to a fresh installation.

The changes to the following columns and indexes are to
default values, field widths, position relative to other
columns or index names.

virtualshelfcontents.biblionumber
virtualshelfcontents_ibfk_1 (virtualshelfcontents)
shelfcontents_ibfk_2 (virtualshelfcontents)
sessions.id
deletedbiblioitems.marc
branchcategories.categorycode
branchrelations.categorycode
items.damaged
deleteditems.notforloan
deleteditems.damaged
deleteditems.itemlost
deleteditems.wthdrawn
currency.symbol
subscription.numberlength
subscription.weeklength
serialidx (serialitems)
items.more_subfields_xml
z3950servers.type
deleteditems.more_subfields_xml
opac_news.lang
labels_conf.formatstring

The following missing columns were added:

deletedbiblioitems.marcxml
deleteditems.itype

The 080 DB rev is specifically for syncing the schema
for users of 3.0-alpha, 3.0-beta, and 3.0-beta2, and should
be a no-op for anybody who has followed git HEAD for
the past few months:

subscription.monthlength
deleteditems.marc
aqbooksellers.name

NOTE: this patch does not handle the case of syncing
the DB of a developer or user who has been following
git HEAD since before 3.0-alpha.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
16 years agoAlter itemBarcodeInputFilter T-Prefix.
Ryan Higgins [Sat, 10 May 2008 19:03:48 +0000 (14:03 -0500)]
Alter itemBarcodeInputFilter T-Prefix.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>