Bug 20702: Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 3 May 2018 11:12:19 +0000 (13:12 +0200)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Wed, 27 Jun 2018 08:51:02 +0000 (09:51 +0100)
commit7861cc07ba8afdf09079c7b51fdb99ad99132688
treea2bf43ef859ee8bc23151146f327f37b0c4eadd9
parent5462c1a88b2652fb25c67f40946436eb243d6ed1
Bug 20702: Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref

Triggered by the finding on bug 20697.
The three calls of GetHostItemsInfo should be controlled by the pref. This
patch makes the sub return an empty list when the pref is disabled.

The patch simplifies the sub by merging the two identical foreach loops
depending on the field number in MARC21/UNIMARC.

Will add a unit test on a follow-up patch.

Test plan:
See next patch.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
C4/Items.pm