Bug 33341: Address some perlcritic errors in 5.36
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 27 Mar 2023 12:17:31 +0000 (14:17 +0200)
committerMatt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Tue, 11 Apr 2023 10:54:27 +0000 (10:54 +0000)
commitc1c5420afae84e86938d4a7ecaf2adb7074a2cc1
treec6b7f1c5f44cd16fc233a296b3e1d0372b557bae
parentc9490945fcfef2c9bfbe25c69520f54c06eb54a8
Bug 33341: Address some perlcritic errors in 5.36

Some old-style code is making our tests fail when run in Debian Testing.

This patch addresses this.

To test:
1. Launch bookworm KTD:
   $ KOHA_IMAGE=master-bookworm ktd up -d
2. Run:
   $ ktd --shell
  k$ prove t/00-testcritic.t
=> FAIL: It fails!
3. Apply the patch
4. Repeat 2
=> SUCCESS: Tests now pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 10d12f999f9b8bff228c9c20f1ca4f0c7144201f)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
13 files changed:
C4/Installer.pm
C4/Koha.pm
C4/Languages.pm
C4/Ris.pm
Koha/AuthUtils.pm
admin/auth_subfields_structure.pl
admin/marc_subfields_structure.pl
installer/install.pl
misc/maintenance/generate_MARC21Languages.pl
misc/translator/tmpl_process3.pl
misc/translator/xgettext.pl
tools/access_files.pl
tools/picture-upload.pl