From 275197f4052c1695994a978b9ade04b6fc38e910 Mon Sep 17 00:00:00 2001 From: Michael Hafen Date: Thu, 24 Aug 2023 10:27:36 -0600 Subject: [PATCH] Bug 34592: Patron Search filter fields needs to be at least an empty array If buildPatronSearchQuery() doesn't return an empty array when it exits early, then the code that adds the sort fields to the filters will fail. Test plan: - If there is not all ready a patron with a sort1 or sort2 value from the bSort1 or bSort2 authorized values, add an authorized value if necessary. - Add a patron if necessary, and set the patrons sort field to the added value. - In Tools -> Patron card creator start a new card batch. - Click on Add Patron(s) to open the patron search window. - Pick the value in either the sort1 or sort2 drop down. - Submit the page. The page will reload and there won't be results. - Apply the patch, close the patron search window, clear the browser cache, reload the "New patron card batch" page, and open the patron search window again. - Repeat the search. There will be results. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi --- koha-tmpl/intranet-tmpl/prog/js/staff-global.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js index 56e35b6209..3fc507e4ee 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js +++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js @@ -534,7 +534,7 @@ function buildPatronSearchQuery(term, options) { // Bail if no patterns if (patterns.length == 0) { - return; + return q; } // Leading wildcard: If search_type option exists, we use that -- 2.39.2