From 437489347c9464d474bdbf9f75cd235f583fb79b Mon Sep 17 00:00:00 2001
From: =?utf8?q?Marc=20V=C3=A9ron?= <veron@veron.ch>
Date: Sun, 27 Jul 2014 20:30:47 +0200
Subject: [PATCH] Bug 4231 - Placing holds from cart fails silently

This patch adds a more meaningfull message if multiple biblios with no
items attached are in the cart.

To test:
- Add biblios with and without items to cart
- Go to cart, select all and click 'Place hold'

Without patch, message reads:
Cannot place hold: this record has no items attached.

With patch, message reads:
Cannot place hold: one or more records without items attached.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Trivial string fix. Message is better than before.
---
 .../intranet-tmpl/prog/en/modules/reserve/request.tt   | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
index cafc07280b..60551f440e 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
@@ -182,9 +182,13 @@ function checkMultiHold() {
 	<div id="yui-main">
 	<div class="yui-b">
 [% IF ( noitems ) %]
-<div class="dialog alert">
-<strong>Cannot place hold:</strong> this record has no items attached.
-</div>
+    <div class="dialog alert">
+    [%IF (multi_hold) %]
+        <strong>Cannot place hold:</strong> one or more records without items attached.
+    [% ELSE %]
+        <strong>Cannot place hold:</strong> this record has no items attached.
+    [% END %]
+    </ div>
 [% ELSE %]
   [% IF ( messagetransfert ) %]
 		<div class="dialog message">
-- 
2.39.2