From 535f555468709316aaea99e3b71481c3b2a6a800 Mon Sep 17 00:00:00 2001 From: Petro Vashchuk Date: Mon, 20 Jun 2022 17:08:32 +0300 Subject: [PATCH] Bug 30997: Fix "CGI::param called in list context" warning in detail.pl CGI param found1 should be explicitly scalar, or else error log gets flooded with this warning: CGI::param called in list context from /usr/share/koha/intranet/cgi-bin/catalogue/detail.pl line 622 This patch fixes it by working with it in a scalar context. The functionality still remains the same but warning doesn't flood error log. To reproduce: 1. Open any biblio (details.pl) page. 2. Check the error log and find the upper mentioned warning, check the timestamp to ensure that it was added when you loaded the page. 3. Apply the patch. 4. Load the page again, ensure that the same warning doesn't get added to the log file again. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 407564e3940ad08030383078fd1ce5c530a19f2d) Signed-off-by: Lucas Gass --- catalogue/detail.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/catalogue/detail.pl b/catalogue/detail.pl index e4d84aa0ea..3bf6255037 100755 --- a/catalogue/detail.pl +++ b/catalogue/detail.pl @@ -619,7 +619,7 @@ if ( C4::Context->preference('UseCourseReserves') ) { $template->param( course_reserves => $course_reserves ); } -$template->param(found1 => $query->param('found1') ); +$template->param(found1 => scalar $query->param('found1') ); $template->param(biblio => $biblio); -- 2.20.1