From 6a9b4d909618b7f6dd6f6d46d1a96802e81f0c1d Mon Sep 17 00:00:00 2001
From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Fri, 23 Jun 2023 10:50:33 -0400
Subject: [PATCH] Bug 33690: (QA follow-up) Mock C4::Letters subroutines for
 unit tests

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

JD Amended patch: tidy

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 t/db_dependent/api/v1/patrons.t | 29 ++++++++++++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

diff --git a/t/db_dependent/api/v1/patrons.t b/t/db_dependent/api/v1/patrons.t
index bad403db8e..0d98ad0c98 100755
--- a/t/db_dependent/api/v1/patrons.t
+++ b/t/db_dependent/api/v1/patrons.t
@@ -45,6 +45,32 @@ my $builder = t::lib::TestBuilder->new;
 my $t = Test::Mojo->new('Koha::REST::V1');
 t::lib::Mocks::mock_preference( 'RESTBasicAuth', 1 );
 
+### Mock Letters
+my $mocked_letters = Test::MockModule->new('C4::Letters');
+$mocked_letters->mock(
+    'GetPreparedLetter',
+    sub {
+        return 1;
+    }
+);
+my $letter_enqueued;
+$mocked_letters->mock(
+    'EnqueueLetter',
+    sub {
+        $letter_enqueued = 1;
+
+        # return a 'message_id'
+        return 42;
+    }
+);
+$mocked_letters->mock(
+    'SendQueuedMessages',
+    sub {
+        my $params = shift;
+        return 1;
+    }
+);
+
 subtest 'list() tests' => sub {
 
     plan tests => 3;
@@ -382,6 +408,7 @@ subtest 'add() tests' => sub {
         # Set a date-time field
         $newpatron->{last_seen} = output_pref({ dt => dt_from_string->add( days => -1 ), dateformat => 'rfc3339' });
 
+        $letter_enqueued = 0;
         $t->post_ok("//$userid:$password@/api/v1/patrons" => { 'x-koha-welcome' => 'email' } => json => $newpatron)
           ->status_is(201, 'Patron created successfully')
           ->header_like(
@@ -396,7 +423,7 @@ subtest 'add() tests' => sub {
           ->json_is( '/last_seen'     => $newpatron->{last_seen}, 'Date-time field set (Bug 28585)' );
 
         my $p = Koha::Patrons->find( { cardnumber => $newpatron->{cardnumber} } );
-        is( Koha::Notice::Messages->search({ borrowernumber => $p->borrowernumber })->count, 1 , "Patron got welcome notice" );
+        is( $letter_enqueued, 1 , "Patron got welcome notice" );
 
         $newpatron->{userid} = undef; # force regeneration
         warning_like {
-- 
2.39.2