From c5fcadf128e84c2a5deae5209b04fa82559845fb Mon Sep 17 00:00:00 2001 From: =?utf8?q?Marc=20V=C3=A9ron?= Date: Mon, 5 Jun 2017 06:52:58 +0200 Subject: [PATCH] Bug 18727: System preferences loose part of values because of double quotes System preferences do not display values of text fields properly if they contain doulbe quotes. To recreate: - Go to Home > Administration > System preferences , then tab Acquisitions - Enter values to both system preferences like proposed in the example (o=5|a="bar foo" and o=5|a="foo bar") - Save - Click on tab Acquisitions to reload - Wrong result: Both preferences show a value of: o=5|a= (parts with double quotes are truncated) - Edit any of the email addresses (Bug 9814): KohaAdminEmailAddress, NoticeBcc, ReplytoDefault, PayPalUser - Set value to: "The Library" - Search for this email address syspref to re-display it - Wrong result: Use [ ] " autocomplete="off" /> as the email address for the administrator of Koha. To test: - Apply patch - Try to recreate issues above - Additionally, edit other system preferences that could contain double quotes, e.g. LibraryName or UsageStatsLibraryName - Set value to: Bibliothek "Zur Leseratte" (Note: patch contains a tiny fix for a typo in acquisitions.pref) Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart (cherry picked from commit 6e7c125a56be8971ec9c9bb52373bff5004a936a) Signed-off-by: Fridolin Somers --- koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt | 2 +- .../prog/en/modules/admin/preferences/acquisitions.pref | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt index 22fb0011ca..28ccddcff0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt @@ -122,7 +122,7 @@ [% IF ( CHUNK.type_text ) %] [% CHUNK.contents %] [% ELSIF ( CHUNK.type_input ) %] - [% IF ( CHUNK.dateinput ) %][% INCLUDE 'date-format.inc' %][% END %] + [% IF ( CHUNK.dateinput ) %][% INCLUDE 'date-format.inc' %][% END %] [% ELSIF ( CHUNK.type_select ) %]