From c800ef7e594d9c1edc37ba563b4d508f656e940c Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 31 Mar 2020 17:56:41 +0200 Subject: [PATCH] Bug 22001: Errors are no longer logged by default (!) This is one of the biggest part we will have to deal with when we will switch to DBIC handler for UI as well. The DBI errors will not be logged if we do not deal with them correctly. Signed-off-by: Martin Renvoize --- t/db_dependent/Koha/Objects.t | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/t/db_dependent/Koha/Objects.t b/t/db_dependent/Koha/Objects.t index 891f30f393..5bb663030f 100644 --- a/t/db_dependent/Koha/Objects.t +++ b/t/db_dependent/Koha/Objects.t @@ -579,7 +579,7 @@ subtest 'Return same values as DBIx::Class' => sub { subtest 'Koha::Objects->delete' => sub { - plan tests => 9; + plan tests => 7; my ( $r_us, $e_us, $r_them, $e_them ); @@ -687,11 +687,7 @@ subtest 'Return same values as DBIx::Class' => sub { } ); - warning_like { - try { $r_us = $patrons->delete; } catch { $e_us = $_ }; - } - qr{DBD::mysql::st execute failed: Cannot delete or update a parent row: a foreign key constraint fails}, - "Foreign key constraint DBI error should be logged"; + try { $r_us = $patrons->delete; } catch { $e_us = $_ }; my $not_deleted_us = $patron_1->in_storage + $patron_2->in_storage + $patron_3->in_storage; $patron_1 = $builder->build_object({ class => 'Koha::Patrons' }); @@ -717,11 +713,7 @@ subtest 'Return same values as DBIx::Class' => sub { } ); - warning_like { - try { $r_them = $patrons->delete; } catch { $e_them = $_ }; - } - qr{DBD::mysql::st execute failed: Cannot delete or update a parent row: a foreign key constraint fails}, - "Foreign key constraint DBI error should be logged"; + try { $r_them = $patrons->delete; } catch { $e_them = $_ }; my $not_deleted_them = $patron_1->in_storage + $patron_2->in_storage + $patron_3->in_storage; ok( -- 2.39.2