From cdd763d1df61973620f8d75ce8738c396d70c89e Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Wed, 2 Dec 2020 10:34:50 +0100
Subject: [PATCH] Bug 26956: Allow guarantor's controls to be set when a
 guarantee is created

With AllowStaffToSetCheckoutsVisibilityForGuarantor and
AllowStaffToSetFinesVisibilityForGuarantor set to Allow, one can only see the
controls for these values in the patron record *after* the patron has been saved
with a guarantor. That makes a frustrating 2-step process. We should be able to
set those values regardless of whether or not there is currently a guarantor on
the account.

Test plan:
Create a guarantee and confirm that the 2 options "Show checkouts to
guarantors" and "Show fines to guarantors" are displayed
Select Yes, save
Confirm that the values have been correctly saved

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 6a461382ba944a8e9f4a7c4e534dca74745f0f55)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit a91ca451224aac8435aa3c3ff2ef3f2415093466)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
---
 .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
index b65bbfa93f..1ae3d7a7b1 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
@@ -559,7 +559,7 @@ legend:hover {
                                                     <a href="#" id="guarantor_search" class="btn btn-default"><i class="fa fa-plus"></i> Search to add</a>
                                                 </li>
 
-                                                [% IF relationships && Koha.Preference('AllowStaffToSetCheckoutsVisibilityForGuarantor') %]
+                                                [% IF Koha.Preference('AllowStaffToSetCheckoutsVisibilityForGuarantor') %]
                                                     <li>
                                                         <label for="privacy_guarantor_checkouts">Show checkouts to guarantors</label>
                                                         <select name="privacy_guarantor_checkouts" id="privacy_guarantor_checkouts">
@@ -574,7 +574,7 @@ legend:hover {
                                                         <div class="hint">Allow guarantors of this patron to view this patron's checkouts from the OPAC</div>
                                                     </li>
                                                 [% END %]
-                                                [% IF relationships && Koha.Preference('AllowStaffToSetFinesVisibilityForGuarantor') %]
+                                                [% IF Koha.Preference('AllowStaffToSetFinesVisibilityForGuarantor') %]
                                                     <li>
                                                         <label for="privacy_guarantor_fines">Show fines to guarantors</label>
                                                         <select name="privacy_guarantor_fines" id="privacy_guarantor_fines">
-- 
2.39.5