From f04ea65fa35a1f906a177b4a14e672ba4a4c3790 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 1 Sep 2020 12:24:57 +0000 Subject: [PATCH] Bug 26334: Move translatable strings out of members-menu.inc into members-menu.js This patch moves translatable strings out of members-menu.inc into members-menu.js where they can be translated using the double-underscore i18n function. To test, apply the patch and go to Patrons. - Expand the search options in the search header by clicking the [+] link. - Select "Date of birth" from the "Search fields" dropdown. - A tooltip should appear above the search form, "Dates of birth should be entered in the format..." with your current date format. - Remove all "Adult" type patron categories but one. - Check out to a child patron. - From the "More" menu choose "Update child to adult patron." - You should see a confirmation. - From the checkout screen, from the "More" menu, choose "Renew patron" - You should get a confirmation. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/members-menu.js for translation, e.g.: msgid "Are you sure you want to renew this patron's registration?" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart --- .../prog/en/includes/str/members-menu.inc | 7 ------- koha-tmpl/intranet-tmpl/prog/js/members-menu.js | 14 +++++++------- 2 files changed, 7 insertions(+), 14 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/str/members-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/str/members-menu.inc index d07cf4602e..6f47bda714 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/str/members-menu.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/str/members-menu.inc @@ -3,13 +3,6 @@ [% USE Categories %]