From f300af96a7fd1ad96f8dfd132882bafcec8a8426 Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer.83@web.de>
Date: Fri, 27 Mar 2020 23:48:56 +0100
Subject: [PATCH] Bug 25011: Improve display of MARC21 508 - Production credits
 in staff and OPAC

Makes some tiny changes to improve display and consistency between
OPAC and staff:
- Capitalization fix: Production Credits - Production credits
- Changes div to span avoiding display issues
- Make sequence of fields in display match (505, 508, 586)

To test:
- Catalog one or more records with none, one and multiple 508 $a
- Check and compare the staff and OPAC detail pages, both
  should display the production credits information correctly

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 .../en/xslt/MARC21slim2intranetDetail.xsl     | 26 +++++++++----------
 .../en/xslt/MARC21slim2OPACDetail.xsl         | 22 ++++++++--------
 2 files changed, 24 insertions(+), 24 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
index 23944c557a..84f1055e4c 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
@@ -1009,6 +1009,19 @@
             </span>
         </xsl:if>
 
+        <!-- 508 -->
+        <xsl:if test="marc:datafield[@tag=508]">
+            <span class="results_summary prod_credits">
+                <span class="label">Production credits: </span>
+                <xsl:for-each select="marc:datafield[@tag=508]">
+                    <xsl:call-template name="subfieldSelectSpan">
+                        <xsl:with-param name="codes">a</xsl:with-param>
+                    </xsl:call-template>
+                    <xsl:if test="position()!=last()"><span class="separator"><xsl:text> | </xsl:text></span></xsl:if>
+                </xsl:for-each>
+            </span>
+        </xsl:if>
+
          <!-- 583 -->
          <xsl:if test="marc:datafield[@tag=583]">
             <span class="results_summary actionnote">
@@ -1029,19 +1042,6 @@
             </span>
          </xsl:if>
 
-        <!-- 508 -->
-        <xsl:if test="marc:datafield[@tag=508]">
-            <div class="results_summary prod_credits">
-                <span class="label">Production credits: </span>
-                <xsl:for-each select="marc:datafield[@tag=508]">
-                    <xsl:call-template name="subfieldSelectSpan">
-                        <xsl:with-param name="codes">a</xsl:with-param>
-                    </xsl:call-template>
-                    <xsl:if test="position()!=last()"><span class="separator"><xsl:text> | </xsl:text></span></xsl:if>
-                </xsl:for-each>
-            </div>
-        </xsl:if>
-
         <!-- 773 -->
         <xsl:if test="marc:datafield[@tag=773]">
             <xsl:for-each select="marc:datafield[@tag=773]">
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
index ca5ee81dd7..5d79840678 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl
@@ -1102,17 +1102,17 @@
         </xsl:if>
 
         <!-- 508 -->
-            <xsl:if test="marc:datafield[@tag=508]">
-                <div class="results_summary prod_credits">
-                    <span class="label">Production Credits: </span>
-                    <xsl:for-each select="marc:datafield[@tag=508]">
-                        <xsl:call-template name="subfieldSelectSpan">
-                            <xsl:with-param name="codes">a</xsl:with-param>
-                        </xsl:call-template>
-                        <xsl:if test="position()!=last()"><span class="separator"><xsl:text> | </xsl:text></span></xsl:if>
-                    </xsl:for-each>
-                </div>
-            </xsl:if>
+        <xsl:if test="marc:datafield[@tag=508]">
+            <span class="results_summary prod_credits">
+                <span class="label">Production credits: </span>
+                <xsl:for-each select="marc:datafield[@tag=508]">
+                    <xsl:call-template name="subfieldSelectSpan">
+                        <xsl:with-param name="codes">a</xsl:with-param>
+                    </xsl:call-template>
+                    <xsl:if test="position()!=last()"><span class="separator"><xsl:text> | </xsl:text></span></xsl:if>
+                </xsl:for-each>
+            </span>
+        </xsl:if>
 
         <!-- 586 -->
         <xsl:if test="marc:datafield[@tag=586]">
-- 
2.39.2