]> git.koha-community.org Git - koha.git/commit
Bug 22030: Use preference to determine username sent to overdrive
authorNick Clemens <nick@bywatersolutions.com>
Wed, 19 Dec 2018 17:53:08 +0000 (17:53 +0000)
committerJesse Maseto <jesse@bywatersolutions.com>
Fri, 11 Jan 2019 18:54:41 +0000 (18:54 +0000)
commiteb13d9dccc30eb2873089b9786cebe02deaf0c4f
tree2fccc4590a5f7abd6008431c78ef060f9acbbaab
parente1050653fba9a2eb0af5926b8cc9326ca721f939
Bug 22030: Use preference to determine username sent to overdrive

Overdrive configuration generally defaults to cardnumber, however, they
have confirmed that some libraries use usernames. We need to allow for
both scenarios.

To test:
1 - Have an OverDrive account setup with SIP authentication
    Note: You can apply for a testing account at developer.overdrive.com
    and setup an environment
2 - Fill in all your OverDrive system preferences
3 - Test with a patron whose username is their cardnumber
4 - Confirm their overdrive account tab on opac loads
5 - Change the username to be another value like "borked_wont_work"
6 - Note the overdrive account tab won't load
7 - Apply patch, update database, not new system preference
OverDriveUsername (default to 'cardnumber)
8 - Note the OD account loads successfully
9 - Change the system preference to 'user name' - the account load fails

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 96adab7af8999da7f351169e1265d4be5e59742f)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 274271b59d5491dc44ebe7bbfb12da13e96d2ceb)

Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
installer/data/mysql/atomicupdate/bug_22030_add_OverDriveUsername_system_preference.perl [new file with mode: 0644]
installer/data/mysql/sysprefs.sql
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref
opac/svc/overdrive