]> git.koha-community.org Git - koha.git/commit
Bug 9860 [Alternate] Incorrect box heading 'Cannot check in' when a late document...
authorOwen Leonard <oleonard@myacpl.org>
Mon, 8 Apr 2013 14:13:11 +0000 (10:13 -0400)
committerJared Camins-Esakov <jcamins@cpbibliography.com>
Sun, 21 Apr 2013 13:34:03 +0000 (09:34 -0400)
commit5f3777350b4e69b36d4c164af2b520e6a832c70c
tree050b043e1ac49d3ea0659889e4901e637941c5b5
parent90e3fae692147b78cceb7ce49aee470066071958
Bug 9860 [Alternate] Incorrect box heading 'Cannot check in' when a late document is returned

The fix for Bug 9397 moved the "cannot check in" heading from within the
one conditional where it should have been displayed to the top of all
check-in errors/messages. "Cannot check in" is still only valid if the
item is withdrawn and BlockReturnOfWithdrawnItems is ON.

In order to accomplish the goal of Bug 9397 while fixing Bug 9860 this
patch puts "cannot check in" back into the correct conditional and adds
a generic heading to check in messages for accessibility purposes.

To test, check in items which will trigger a variety of errors
including:

- item must be returned to home library
- item is lost
- item is withdrawn (wtih BlockReturnOfWithdrawnItems on and off)
- item is overdue

...as well as items which should check in normally. Messages should
display correctly.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
(cherry picked from commit 3ce75bcf2631bccb584dff6ea2f78d16f49770f8)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt