]> git.koha-community.org Git - koha.git/commit
Bug 10935: fix breakage of CSV acq exports when using a non-English translation
authorJonathan Druart <jonathan.druart@biblibre.com>
Mon, 23 Sep 2013 15:07:09 +0000 (17:07 +0200)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Tue, 3 Dec 2013 15:17:04 +0000 (12:17 -0300)
commita6b83b24ca090f2be724706daa4768f659ef1eb8
treecdb186c7410fee1a28bf8c464cba6d92e84a025b
parent7f21891e10647d95449d265501a60a7915d778b6
Bug 10935: fix breakage of CSV acq exports when using a non-English translation

To reproduce:
- cd misc/translator
- ./translate update LANG
- ./translate install LANG
- go to the Koha mainpage and change the language.
- go to acqui/basketgroup.pl?booksellerid=XX and try to export a
  basketgroup.
The headers is followed by the first basketgroup information. There is
no carriage return.

It looks like it is caused by a routine used by the translator script
(TmplTokenizer::string_canon).

To test this patch:
- apply it
- cd misc/translator
- ./translate -f update LANG
- translate headers in your po file
- ./translate -f install LANG
- go to acqui/basketgroup.pl?booksellerid=XX and try to export a
  basketgroup.
- verify that the csv looks good now.
- same thing for basket.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Good idea and seems to work - just fixing a small glitch
with the first entry of the list in a follow-up.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 6bf848303fd4a0d827cc688dab907166df701102)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/acqui/basket.tt [new file with mode: 0644]
koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/acqui/basketgroup.tt [new file with mode: 0644]
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/csv/basket.tt
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/csv/basketgroup.tt