From 4da90d28808f2eee38da43f6feb0583dfff6b7f4 Mon Sep 17 00:00:00 2001 From: Fridolyn SOMERS Date: Wed, 17 Jul 2013 17:26:34 +0200 Subject: [PATCH] Bug 7484: keep selected values when changing search type on authority search form 1) I'm on the "Search authorities" tab. I select an authority type, then change the active tab. The type change is lost. 2) I'm on a tab and type a search pattern, then change tab, the string is lost. This behaviour is logical, given the fact that we're using tabs, but it would be more practical to keep the typed informations when the user changes the search mode. This patch add a few JQuery code to synchronise inputs between all tabbed authorities search forms. Test plan : - Go to Authorities home page : cgi-bin/koha/authorities/authorities-home.pl - In toolbar, "Search main heading" is selected - Change all inputs : authotity type, operator, term, and sort order - Click on "Search all headings" tab => Inputs are the same has previous tab - Click on "Keyword search" tab => Inputs are the same has previous tab Signed-off-by: Paola Rossi Signed-off-by: Jonathan Druart Amended patch: Explicitly declare 2 new variables used. Signed-off-by: Katrin Fischer Passes all tests and QA script. Works as described, Firebug doesn't show any problems with the Javascript. Could be useful for other tabbed searches like the start page as well. Signed-off-by: Galen Charlton (cherry picked from commit 85642ededaf71b0a67805151937014f42deea2dd) Signed-off-by: Fridolin SOMERS (cherry picked from commit 32277e0669c86c972117bd62b92bbad2dab4e5c5) Signed-off-by: Tomas Cohen Arazi --- .../intranet-tmpl/prog/en/includes/authorities-search.inc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc index d0b13a7bc4..cbdc939355 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc @@ -14,6 +14,11 @@ $("#header_search").tabs( "option", "selected", 2 ); } } + $("#header_search input[type='text'], #header_search select").change(function() { + var myname = $(this).attr("name"); + var myval = $(this).val(); + $("#header_search [name='" + myname + "']").val(myval); + }); }); //]]> -- 2.39.5