From fb59f3f0f046c7b08fa509e76c416b2c4db3fa5a Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Tue, 1 Sep 2020 15:43:19 +0200 Subject: [PATCH] Bug 26338: Show tool plugins run in tools home In tools home there is a link to the table showing tool plugins. Would be great to be able to run a tool plugin directly from tools home. Also adds the behavior than if there is no tool plugin, "Tool plugins" section is not displayed in tools home. No need of a link that goes to an empty table ;) Test plan : 1) Enable plugins, dont install any 2) Go to "Tools" module : /cgi-bin/koha/tools/tools-home.pl 3) Check you dont see "Tool plugins" 4) Install a tool plugin like Carrousel https://inlibro.com/instructions-carrousel/ 5) Refresh /cgi-bin/koha/tools/tools-home.pl 6) Check you see "Tool plugins" and a link to Carrousel 7) Click on link to Carrousel => You see plugin run 8) Disable Carrousel plugin 9) Refresh /cgi-bin/koha/tools/tools-home.pl 10) Check you dont see "Tool plugins" Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart --- .../intranet-tmpl/prog/css/src/staff-global.scss | 3 +-- .../prog/en/modules/tools/tools-home.tt | 15 +++++++++++++-- tools/tools-home.pl | 7 +++++++ 3 files changed, 21 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss index 9a7470546e..6ad62428ed 100644 --- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss +++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss @@ -1336,8 +1336,7 @@ dt { dd { font-size: 90%; font-weight: normal; - padding: .2em; - text-indent: 2.5em; + padding: .2em .2em .2em 2.5em; } #toolbar, diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt index 350fd1b28d..c8d7f7d567 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt @@ -120,9 +120,20 @@
Quote editor for Quote-of-the-day feature in OPAC
[% END %] - [% IF ( Koha.ArePluginsEnabled() && CAN_user_plugins_tool ) %] + [% IF ( Koha.ArePluginsEnabled() && CAN_user_plugins_tool && tool_plugins ) %]
Tool plugins
-
Use tool plugins
+
+ Use tool plugins + +
[% END %] [% IF ( CAN_user_tools_upload_general_files ) %] diff --git a/tools/tools-home.pl b/tools/tools-home.pl index a0f7832f6a..375cc09e76 100755 --- a/tools/tools-home.pl +++ b/tools/tools-home.pl @@ -42,4 +42,11 @@ $template->param( pendingtags => $pendingtags ); +if ( C4::Context->config('enable_plugins') ) { + my @tool_plugins = Koha::Plugins->new()->GetPlugins({ + method => 'tool', + }); + $template->param( tool_plugins => \@tool_plugins ); +} + output_html_with_http_headers $query, $cookie, $template->output; -- 2.39.5