]> git.koha-community.org Git - koha.git/commit
Bug 12663 - SCOUserCSS and SCOUserJS ignored on selfcheck login page
authorNick Clemens <nick@bywatersolutions.com>
Tue, 8 Mar 2016 22:04:32 +0000 (22:04 +0000)
committerJulian Maurice <julian.maurice@biblibre.com>
Mon, 9 May 2016 08:39:17 +0000 (10:39 +0200)
commitc56b10b580673c2dd8408d1dde4c6eac747f5b1e
tree8792a600fdee349b72adef1c9f892b6b4baf0fda
parentb53075b58df01e65371e13dee0b6848d12a181f2
Bug 12663 - SCOUserCSS and SCOUserJS ignored on selfcheck login page

Currently if not logged in when browsing to
http://YOURCATALOG/cgi-bin/koha/sco/sco-main.pl
You are redirected to opac-auth.tt and SCOUserCSS and SCOUserJS are not
loaded. This page passes through a parameter to the template to indicate
this is an SCO login and appropriate CSS and JS should be loaded.

Additionally this patch ensure that when loggin in using the form you
are redirected to the sco-main.pl instead of the patron account page for
the user.

To test:
1 - Verify that normal login works on both staff and opac
2 - Verify that SCO link goes to login page if AutoSelfCheckAllowed is
set to "Don't allow"
3 - Enter changes into SCOUserJS and SCOUserCSS and observe these are
present on SCO log in page with AutoSelfCheck disabled
4 - Verify that a logged in opac user without permissions cannot access
the self-checkout module
5 - Verify that AutoSelfCheckAllowed and associated system preferences
function as expected
6 - Verify the AutoSelfCheck user is logged out if they attempt to visit
another page

Followed test plan.
If I go to http://YOURCATALOG/cgi-bin/koha/sco/sco-main.pl, CSS and JS trigger already on
the login form, I suppose that is intended.
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher <bredan@bywatersolutions.com>
(cherry picked from commit e476be5568d41bb06ce2fef5e8da6417cf9ed682)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
C4/Auth.pm
koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc
koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt
opac/sco/sco-main.pl