]> git.koha-community.org Git - koha.git/commit
Bug 17978: Circ rules will not limit holds
authorKyle M Hall <kyle@bywatersolutions.com>
Tue, 19 Dec 2017 19:20:56 +0000 (14:20 -0500)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 15 Apr 2019 10:59:19 +0000 (11:59 +0100)
commit7a7fdac0b263baac5d196c83b17e2c7d830b930d
tree56e48624cda3308b0a255240ad206a3def1ed852
parent912a97f8b49b89d03ed524bed2072db0a50c4527
Bug 17978: Circ rules will not limit holds

The crux of this issue is that all those holds are unfilled record level holds. The code that checks for the number of holds the user already has *always* uses a branchcode of some form. Because of this, any open record level holds are completely ignored for this purpose.

Test Plan:
1) Set ReservesControlBranch to "item's home library"
2) Set an All libraries/All Patrons/All itemtypes rules limiting a patron to 2 holds
3) Place 3 record level holds, you can but you should not be able to!
4) Delete the holds
5) Apply this patch
6) Attempt to place 3 record level holds
7) Note that you cannot!

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit d7a5925aa0a7a185c8671d8c9989d80bdf2c0939)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
C4/Reserves.pm