From ae3cc1f417503df130c7195c14d316889b8f99c7 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 21 Oct 2019 17:55:17 +0200 Subject: [PATCH] Bug 23855: Fix "Mark selected suggestion as" status On the suggestions management page (suggestion/suggestion.pl) you can select suggestions and change their status. But it only works for "ACCEPTED" or "REJECTED". Maybe caused by bug 22905. Test plan: Select at least one suggestion on the screen and select the "Pending" status. => The status of the selected suggestions must have been updated Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit 030eb694a87029e3220e8f930f509556c9e816ea) Signed-off-by: Fridolin Somers --- suggestion/suggestion.pl | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl index ed043083bd..e04e2ef629 100755 --- a/suggestion/suggestion.pl +++ b/suggestion/suggestion.pl @@ -196,15 +196,12 @@ elsif ($op eq "change" ) { my $accepted_by = $input->param('acceptedby'); if ( $STATUS eq "ACCEPTED" ) { $suggestion = { - STATUS => $STATUS, accepteddate => dt_from_string, acceptedby => C4::Context->userenv->{number}, }; } elsif ( $STATUS eq "REJECTED" ) { $suggestion = { - - STATUS => $STATUS, rejecteddate => dt_from_string, rejectedby => C4::Context->userenv->{number}, }; @@ -212,6 +209,7 @@ elsif ($op eq "change" ) { if ($STATUS) { $suggestion->{manageddate} = dt_from_string; $suggestion->{managedby} = C4::Context->userenv->{number}; + $suggestion->{STATUS} = $STATUS; } if ( my $reason = $input->param("reason$tabcode") ) { if ( $reason eq "other" ) { -- 2.39.5