From 7f0612052770654aaa7d5344d18522dbfc8b9aab Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Sat, 29 Jul 2017 17:06:52 +0200 Subject: [PATCH] Bug 19003: Add a TestBuilder default for borrowers.login_attempts Bug 18314 causes t/db/SIP/Message.t to fail (quite often) since TestBuilder fills login_attempts with a random number. (Note: Only when FailedLoginAttempts is non-zero.) Trivial fix: TestBuilder should have a zero default for login_attempts. Test plan: Do not yet apply this patch. Set pref FailedLoginAttempts to say 3. Run t/db_dependent/SIP/Message.t. Might fail on the password test (CQ). Apply this patch. Run t/db_dependent/SIP/Message.t again. Does not fail anymore. Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart (cherry picked from commit 5bb56bf336187cde38e1a3b89c792ee6dc231acf) Signed-off-by: Fridolin Somers --- t/lib/TestBuilder.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/t/lib/TestBuilder.pm b/t/lib/TestBuilder.pm index ce8f601ede..2df9f0401e 100644 --- a/t/lib/TestBuilder.pm +++ b/t/lib/TestBuilder.pm @@ -451,6 +451,9 @@ sub _gen_blob { sub _gen_default_values { my ($self) = @_; return { + Borrower => { + login_attempts => 0, + }, Item => { more_subfields_xml => undef, }, -- 2.39.5