From e93de54ab2c6d96dbd63f2b910e422f350b621b3 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Thu, 23 May 2024 08:49:39 +0200
Subject: [PATCH] Bug 36924: Remove warning "Value not allowed for auto_incr
 itemnumber in Item"

We are removing entirely the badly written test.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Note: We cannot test this properly when the search index refers to biblios
and items that do not exist in the database.
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 12511385289b41c3c3d067f1b7c4397010e3d27c)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 98fa5f6b25360e056dac72a776e880ec2c4d4970)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 t/db_dependent/Search.t | 26 +-------------------------
 1 file changed, 1 insertion(+), 25 deletions(-)

diff --git a/t/db_dependent/Search.t b/t/db_dependent/Search.t
index f2be66b6c1..11b0f861c1 100755
--- a/t/db_dependent/Search.t
+++ b/t/db_dependent/Search.t
@@ -31,7 +31,6 @@ use Test::MockModule;
 use Test::Warn;
 use t::lib::Mocks;
 use t::lib::Mocks::Zebra;
-use t::lib::TestBuilder;
 
 use Koha::Caches;
 
@@ -703,29 +702,6 @@ ok(MARC::Record::new_from_xml($results_hashref->{biblioserver}->{RECORDS}->[0],'
         $results_hashref->{'biblioserver'}->{"RECORDS"});
     is(scalar(@{$newresults[0]->{'ALTERNATEHOLDINGS'}}), 1, 'Alternate holdings filled in correctly');
 
-
-    ## Regression test for Bug 10741
-
-    # make one of the test items appear to be in transit
-    my $circ_module = Test::MockModule->new('C4::Circulation');
-    my $builder = t::lib::TestBuilder->new;
-    my $transfer = $builder->build(
-        {
-            source => 'Branchtransfer',
-            value => {
-                itemnumber => 11,
-                frombranch => 'MPL',
-                tobranch => 'CPL',
-                datesent => \'NOW()'
-            }
-        }
-    );
-
-    ($error, $results_hashref, $facets_loop) = getRecords("TEST12121212","TEST12121212",[ ], [ 'biblioserver' ],20,0,\%branches,\%itemtypes,$query_type,0);
-    @newresults = searchResults({'interface'=>'intranet'}, $query_desc, $results_hashref->{'biblioserver'}->{'hits'}, 17, 0, 0,
-        $results_hashref->{'biblioserver'}->{"RECORDS"});
-    ok(!exists($newresults[0]->{norequests}), 'presence of a transit does not block hold request action (bug 10741)');
-
     ## Regression test for bug 10684
     ( undef, $results_hashref, $facets_loop ) =
         getRecords('ti:punctuation', 'punctuation', [], [ 'biblioserver' ], '19', 0, \%branches, \%itemtypes, 'ccl', undef);
@@ -947,7 +923,7 @@ sub run_unimarc_search_tests {
 }
 
 subtest 'MARC21 + DOM' => sub {
-    plan tests => 94;
+    plan tests => 93;
     run_marc21_search_tests();
 };
 
-- 
2.39.5