From 431b2c4a5dc5b3c213c5fb6c92ef9f7fad95a422 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Thu, 7 Nov 2024 21:29:54 -0300 Subject: [PATCH] Bug 31224: Revert to $metadata->record in `marcrecord2csv` This patch reverts the change for marcrecord2csv as `$biblio->metadata_record` doesn't support a list of itemnumbers, and it feels we should discuss in another context whether to add it as a parameter, or make it a Koha::Items iterator. The Koha::Item object is actually retrieved in marc2csv so there's room for easy improvements without adding technical debt (i.e. bad method signatures for a single use case). This fixes a feature: 1. Run: $ ktd --shell k$ prove t/db_dependent/Exporter/Record.t => FAIL: Test fails because the 'items' are not being filtered on the passed itemnumbers (i.e. all items are picked for generating the CSV). 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer --- C4/Record.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Record.pm b/C4/Record.pm index 15978a5b2b..6929700601 100644 --- a/C4/Record.pm +++ b/C4/Record.pm @@ -461,7 +461,7 @@ sub marcrecord2csv { # Getting the record my $biblio = Koha::Biblios->find($biblionumber); return unless $biblio; - my $record = eval { $biblio->metadata_record( { embed_items => 1, itemnumbers => $itemnumbers } ); }; + my $record = eval { $biblio->metadata->record( { embed_items => 1, itemnumbers => $itemnumbers } ); }; return unless $record; # Getting the framework -- 2.39.5