]> git.koha-community.org Git - koha.git/commit
Bug 29818: Cannot save subscription frequency without display order
authorPhil Ringnalda <phil@chetcolibrary.org>
Wed, 13 Nov 2024 05:31:02 +0000 (21:31 -0800)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Mon, 18 Nov 2024 16:44:35 +0000 (17:44 +0100)
commit77c003ed544d653345acf4debe968110ea94a1fd
treeb571a1a714125b62f9797517bd4a24c527fa3fa2
parentd794891005e4a457371bd9ecaaf845e70fe85255
Bug 29818: Cannot save subscription frequency without display order

The schema says that subscription_frequencies.displayorder can be null, and
everything else deals with it being null just fine, but if you try to save
a new frequency without specifying display order with strict_sql_modes set,
you get an error.

Test plan:
 1. Without the patch, Serials - Manage frequencies - New frequency
 2. Description is mandatory, so fill it in, then click Save
 3. Boom! Apply patch, restart_all
 4. Repeat steps 1-2, and verify that no error is thrown and the new
    frequency shows up (at the top of the list since nothing comes before
    something)
 5. New frequency, fill in Description, try typing something other than a
    number in Display order and saving. You should be told to follow the
    directions that only numeric characters are allowed

Sponsored-by: Chetco Community Public Library
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-frequencies.tt
serials/subscription-frequencies.pl