From 3d76ccdf94302b11a61394cc84199ae1b2002473 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Thu, 25 Jul 2024 13:50:30 -0300 Subject: [PATCH] Bug 37476: Unit tests Signed-off-by: Emily Lamancusa Signed-off-by: Martin Renvoize --- t/db_dependent/Serials.t | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/t/db_dependent/Serials.t b/t/db_dependent/Serials.t index da919c5f79..0c9ce3dffe 100755 --- a/t/db_dependent/Serials.t +++ b/t/db_dependent/Serials.t @@ -5,7 +5,7 @@ use Modern::Perl; -use C4::Serials qw( updateClaim NewSubscription GetSubscription GetSubscriptionHistoryFromSubscriptionId SearchSubscriptions ModSubscription GetExpirationDate GetSerials GetSerialInformation NewIssue AddItem2Serial DelSubscription GetFullSubscription PrepareSerialsData GetSubscriptionsFromBiblionumber ModSubscriptionHistory GetSerials2 GetLatestSerials GetNextSeq GetSeq CountSubscriptionFromBiblionumber ModSerialStatus findSerialsByStatus HasSubscriptionStrictlyExpired HasSubscriptionExpired GetLateOrMissingIssues check_routing addroutingmember GetNextDate ); +use C4::Serials qw( getroutinglist updateClaim NewSubscription GetSubscription GetSubscriptionHistoryFromSubscriptionId SearchSubscriptions ModSubscription GetExpirationDate GetSerials GetSerialInformation NewIssue AddItem2Serial DelSubscription GetFullSubscription PrepareSerialsData GetSubscriptionsFromBiblionumber ModSubscriptionHistory GetSerials2 GetLatestSerials GetNextSeq GetSeq CountSubscriptionFromBiblionumber ModSerialStatus findSerialsByStatus HasSubscriptionStrictlyExpired HasSubscriptionExpired GetLateOrMissingIssues check_routing addroutingmember GetNextDate ); use C4::Serials::Frequency; use C4::Serials::Numberpattern; use C4::Biblio qw( AddBiblio GetMarcFromKohaField ); @@ -17,7 +17,7 @@ use Koha::Acquisition::Booksellers; use t::lib::Mocks; use t::lib::TestBuilder; use Test::MockModule; -use Test::More tests => 57; +use Test::More tests => 63; BEGIN { use_ok('C4::Serials', qw( updateClaim NewSubscription GetSubscription GetSubscriptionHistoryFromSubscriptionId SearchSubscriptions ModSubscription GetExpirationDate GetSerials GetSerialInformation NewIssue AddItem2Serial DelSubscription GetFullSubscription PrepareSerialsData GetSubscriptionsFromBiblionumber ModSubscriptionHistory GetSerials2 GetLatestSerials GetNextSeq GetSeq CountSubscriptionFromBiblionumber ModSerialStatus findSerialsByStatus HasSubscriptionStrictlyExpired HasSubscriptionExpired GetLateOrMissingIssues check_routing addroutingmember GetNextDate )); @@ -227,6 +227,15 @@ my $patronid2 = $patron2->borrowernumber; addroutingmember( $patronid1, $subscriptionwithroutinglistid ); addroutingmember( $patronid2, $subscriptionwithroutinglistid ); +my @routinglist = getroutinglist($subscriptionwithroutinglistid); + +is( scalar @routinglist, 2, 'Two members on the routing list' ); +is( $routinglist[0]->{biblionumber}, $biblionumber, 'biblionumber is correct' ); +is( $routinglist[1]->{biblionumber}, $biblionumber, 'biblionumber is correct' ); +is( $routinglist[0]->{borrowernumber}, $patronid1, 'First patron added has the lowest rank' ); +is( $routinglist[0]->{ranking}, 1, 'Rank 1 set for first subscription list member' ); +is( $routinglist[1]->{ranking}, 2, 'Next rank value set for the second added subscription list member' ); + # Perform SearchSubscriptions my $fake_subscription = GetSubscription($subscriptionwithroutinglistid); -- 2.39.5