From 74c6b8a116658a0616b5825e9805ea65bb9cd504 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Tue, 1 Aug 2017 14:10:56 +0200 Subject: [PATCH] Bug 18996: Resolve an uninitialized warning from ILS/Item.pm From the syslog call on line 107/108. The field $item->{title} has not been initialized. When catching the warns in a test script with Test::Warn, I got: Use of uninitialized value $args[1] in sprintf at /usr/lib/x86_64-linux-gnu/perl/5.20/Sys/Syslog.pm line 423. This simply resolves the warning. We might have a closer look to this title field on another report though. Test plan: Run Message.t from the next patch without this fix. It will fail since the additional warning makes warnings_like return false. Signed-off-by: Marcel de Rooy Signed-off-by: Colin Campbell Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart (cherry picked from commit 66a7565995c00495fe670c809d9c7cf0c900fc7f) Signed-off-by: Fridolin Somers --- C4/SIP/ILS/Item.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/SIP/ILS/Item.pm b/C4/SIP/ILS/Item.pm index 06497994db..c4010525b0 100644 --- a/C4/SIP/ILS/Item.pm +++ b/C4/SIP/ILS/Item.pm @@ -103,7 +103,7 @@ sub new { bless $self, $type; syslog("LOG_DEBUG", "new ILS::Item('%s'): found with title '%s'", - $item_id, $self->{title}); + $item_id, $self->{title}//'' ); return $self; } -- 2.39.5