From 2ca65e0a06bff5b0b1c395874fca431e915c11c1 Mon Sep 17 00:00:00 2001 From: Emmi Takkinen Date: Tue, 22 Aug 2023 13:45:27 +0300 Subject: [PATCH] Bug 34585: Add data-code attribute to chargeperiod_charge_at selector When one tries to edit circulation rule "When to charge" columns value is always set as "End of interval". This patch adds data-code attribute to chargeperiod_charge_at selector to define existing rules value. To reproduce: 1. Navigate to Circulation and fine rules page. 2. Find or create a rule with a "When to charge" value set as "Start of interval". 3. Edit rule. => Note that "When to charge" value is now "End of interval", while as the other values should be copied as they were. 4. Apply this patch. 5. Edit rule again. => "When to charge" should now be copied correctly. Sponsored-by: Koha-Suomi Oy Signed-off-by: Emily Lamancusa Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer --- .../intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt index f1193b1441..f4901df8d0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt @@ -291,7 +291,13 @@ [% decreaseloanholds | html %] [% fine | $Price %] [% chargeperiod | html %] - [% IF chargeperiod_charge_at %]Start of interval[% ELSE %]End of interval[% END %] + + [% IF chargeperiod_charge_at %] + Start of interval + [% ELSE %] + End of interval + [% END %] + [% firstremind | html %] [% IF overduefinescap %][% overduefinescap | $Price %][% ELSE %][% END %] -- 2.39.5