From cca7c4fbde1ba5074937251d9fd3c8b3d86deef7 Mon Sep 17 00:00:00 2001 From: Galen Charlton Date: Tue, 9 Jul 2013 17:53:16 +0000 Subject: [PATCH] bug 10559: remove spurious "statement handle still active" warnings Generating (e.g.) overdue notices can result in spurious warnings in the cronjob logs: $ ./misc/cronjobs/overdue_notices.pl -t -library CPL prepare_cached(SELECT * FROM issues WHERE itemnumber = ?) statement handle DBI::st=HASH(0x54a7828) still Active at C4/Letters.pm line 589 This patch removes the warning by making sure that the relevant statement handle is finished after fetching its first row of results. To test: [1] Set up an overdue loan such that running overdue_notices.pl will trigger the generation of a notice. [2] Run overdue_notices.pl -t and note the warning message. [3] Apply the patch. [4] Run overdue_notices.pl -t again and note that the warning message is no longer displayed. [5] Check the message_queue table and verify that the overdue notices generated in steps 2 and 4 have the same text. Signed-off-by: Galen Charlton Signed-off-by: Srdjan Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 2bab95cac5f43b034adec36ec62a8c8f7f520627) Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 5e7452758949e037fcf286cead721b559dd7d0e3) Signed-off-by: Bernardo Gonzalez Kriegel (cherry picked from commit 5e7452758949e037fcf286cead721b559dd7d0e3) --- C4/Letters.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/C4/Letters.pm b/C4/Letters.pm index f1e4200d11..fb2a6c694d 100644 --- a/C4/Letters.pm +++ b/C4/Letters.pm @@ -543,6 +543,7 @@ sub _substitute_tables { $sth->execute( $ref ? @$param : $param ); $values = $sth->fetchrow_hashref; + $sth->finish(); } _parseletter ( $letter, $table, $values ); -- 2.39.5