]> git.koha-community.org Git - koha.git/commit
Bug 19693: (QA follow-up) Replace changed tag test
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 7 Oct 2022 08:41:20 +0000 (08:41 +0000)
committerArthur Suzuki <arthur.suzuki@biblibre.com>
Fri, 16 Dec 2022 15:52:03 +0000 (16:52 +0100)
commit2b15a60afdf713f55dffb1d1d7d3610bb8ee6087
tree296e546af7a09a0504a3e18b8a36884beefa6fb1
parentae17e1bcb3fc4c9173ead9534d4a43741462d583
Bug 19693: (QA follow-up) Replace changed tag test

The test
  $MARCfrom->field('1..', '2..'))[0]->tag ne ($MARCto->field('1..', '2..'))[0]->tag
is not completely consistent with following code in sub merge.
I decided to get the authtype code from the old record that comes
from Koha and should include the type.
Remaining changes refer to indentation/comments.

Test plan:
Run t/db_dependent/Authority/Merge.t
Note: The test actually could be extended a bit for mocking MARC
flavor, but needs some additional framework support to work.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit d7d33744ba34ef95aa3845ca4160abdece4d0f7a)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 90e4cdb752601d273aa1807a88330da29034305c)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
C4/AuthoritiesMarc.pm