From c51a1d726ba813ab0801766188a765718e589ccf Mon Sep 17 00:00:00 2001
From: Owen Leonard
Date: Wed, 12 Jan 2022 16:29:27 +0000
Subject: [PATCH] Bug 28993: Switch magnifying glass in staff detail pages to
FA icon
This patch modifies the staff interface's bibliographic detail XSL so
that a Font Awesome is used instead of a magnifying glass image when
listing authority subject headings.
The patch also corrects two other places where the image is used so that
the image can be removed. Some markup from authorities.detail.tt is
removed because it appears to be unused (a copy and paste from
catalogue/detail.tt).
To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
- To view the changes to the staff interface bibliographic detail page,
locate a record which has at least one subject heading which is linked
to a subject authority record.
- The subject heading link should be followed by a magifying glass
(Font Awesome) icon which links to the authority record's detail page.
- View a similar change to the MARC detail page for the record. Confirm
that the subject headings are followed by a link to the authority
detail page.
- Follow the authority search link to locate and view an authority
record. The information on the authority detail page should be
correct.
Signed-off-by: David Nind
Signed-off-by: Katrin Fischer
Signed-off-by: Fridolin Somers
---
.../prog/css/src/staff-global.scss | 7 +++++++
.../prog/en/modules/authorities/detail.tt | 8 --------
.../prog/en/modules/catalogue/MARCdetail.tt | 8 +++++---
.../prog/en/xslt/MARC21slim2intranetDetail.xsl | 16 ++++++----------
koha-tmpl/intranet-tmpl/prog/img/filefind.png | Bin 2479 -> 0 bytes
5 files changed, 18 insertions(+), 21 deletions(-)
delete mode 100644 koha-tmpl/intranet-tmpl/prog/img/filefind.png
diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
index 93c3226c49..e042f773c3 100644
--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
@@ -26,6 +26,13 @@ a {
}
}
+ &.authlink {
+ background-color: #e6f0f2;
+ border-radius: 5px;
+ display: inline-block;
+ padding: 2px 4px;
+ }
+
&.btn {
&:link,
&:visited {
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt
index fd98a45849..4c720bfc83 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/detail.tt
@@ -109,14 +109,6 @@
[% subfiel.marc_value | html %]
[% END %]
- [% IF ( subfiel.link ) %]
-
-
-
- [% END %]
- [% IF ( subfiel.authority ) %]
- Auth
- [% END %]
[% END %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt
index e2068693b1..f6be1b3d8f 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt
@@ -99,12 +99,14 @@
[% subfiel.short_desc | html %]
[% IF ( subfiel.is_url ) %][% subfiel.marc_value | html %][% ELSE %][% subfiel.marc_value | html %][% END %]
[% IF ( subfiel.link ) %]
-
-
+
+
[% END %]
[% IF ( subfiel.authority ) %]
- Auth
+
+
+
[% END %]
[% END %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
index 6983988867..7f14c298f6 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl
@@ -688,11 +688,9 @@
/cgi-bin/koha/authorities/detail.pl?authid=
-
- /intranet-tmpl/prog/img/filefind.png
-
- 15
- 15
+
+ fa fa-search
+ View authority record
@@ -740,11 +738,9 @@
/cgi-bin/koha/authorities/detail.pl?authid=
-
- /intranet-tmpl/prog/img/filefind.png
-
- 15
- 15
+
+ fa fa-search
+ View authority record
diff --git a/koha-tmpl/intranet-tmpl/prog/img/filefind.png b/koha-tmpl/intranet-tmpl/prog/img/filefind.png
deleted file mode 100644
index 3c05c72b5eaeab4938ee64e3ac09632f5dceebae..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001
literal 2479
zcmZ9Oc{tSj7stP5Y}v+*kdjGrGla2>WJrk2WND0TP$c_hEX_>T#3XCn8Y5(z%Ged5
zL?lc0C6c0C*QA*&BiYJ&N5A_=zx#Zi^Lam?^Sqw-Ip?p>NyJ*2i3-UI0RSM1L7U*X
z3f&Dse(p^S4`1dAueXt<5db{u)Zt6|!hQ2!GB+~;c6JZFu_%q3*%O3zBytt~GtPAR
z8SEyn1Q~gA75X#c*K=|KK)?-SVq}YNZGTHhkQ>=A@O4Lb$smN&do}xGLstMP?dW@Y
zBH_5TP9kl_{*uY~Ai_A7-+#lDg2HRK``>!Uau@tK`=)45YjXwdP6t6HMam!mtNN
zvyp)t)Q=xNHb$)V=VocKdUdxdW9%_$WoOpoQH0l-jGico;ruFf9W`NYH~W`FJ6{H
zu`MNoUtpt&^&^TLbNir+s%Y6mTs3}
z2|DPP?hthR&w-vdr4Tl*1ub(+9qMIBRlORla4Ip8PrL|lr^hWgx@(1Xkmt!y2m#Po
z5=32u&~~LfuLrZ@l%`u@1~2|M5?MlL>B3o9nlYMB?e_xQ
zAcK+>JP5mfR+nAdiMP=0QTn}gp(*0s+-#Z01(2*aZ*65!C
z=cfZ6ktIJ4N(>@FB}fHg9)wSLr7m~L{@D80+>q^rqCDAov0E_z@{uGfKD(vY*z=q<
zp;i_MQvBUe6)5GIY=~wcPB!ya%79UP1t1y4QuzIeN3q2NeYI-Z*{_v4s_G}=>RJ27
zax>?blKjmX*$
zE5%b90@i?Td>jk|=^J>uIv%D6l{R>H230*x5uVmHe95aX3ctSZ!mF_;=E9%TT
z!=H2?k#uQ!#csj*X#ia&j=|yCSlf}j<9QU*vf4jT8|B@W63*<5dHt%x+rc=f^*&aN
zE~L}VBbkm%E;`WD_O8q9j-&s`2miFp!jk*&lUn0G?S4DkqO6uOyRDY8k#P_bz&BhG
z7HM^|7+yw%<&CN;zv%Yzwzte_sJltdRIH<8a>lBO^OHljkhFaWQr9^IReP0E4vDrj;`uU)|jXYLl&r%L6
zslDZ7`X3ji^&NDdD3LD|(I_wtrtjSgH<_O@tZCRD&6>;4mMvt8N3MT^)Oj}=8w7g<
zFLp2g8CtOFD>Z!`(K`_Z14k?7NAehdY6~tOB+o}An}$?-W*xA!S$K^k#NaO9^`64t
zU9_PjC!X+{Ip;0BoOo|hNB&ua|JtaT!#(}y;LF=^sXv=)>q1x7ReyWBNg#aqe!(NF
zIcZ;G98;#A*2z3EeYda#ED$9Igw7{we%33j)_)VV(f9XUReH93w806X<%jY9+w)HZ
zx9p>t9oIyG6GZ-l&3$Haj9Ud%jMUEOF<3<9)5|sI0s85f)qt2CXyjx?zKTnu*rBeg
z87^g4LHGU^{=8KsIUes%CQqP_@IE{yb;?%zK&sV=Vr!s;Kyf_g=;J!3ObxY$&Bza&
zTFrm8*#ZFHCofUtPTzU18JOF@lzljEM{z0@044{dCG?vf>Y3!dA}D-Xl;^-Z_4wIB
zzXee2R2?0eo9HpG4oMBQ32Q^01h~@0aHnA}bG@|=#_cLSu{tG%WcgCrYAe4hVyu2o
zpV5$M2h>&|qI3NRg72$uZ12d5kH-6OuhNbjl_+PI%-+}fnIY=#b6J-tB(iBb(M+9)DXzz);PRd!`6pPxP(HP1iF(6o&h8j3hUKoigu**g{c9~eX6GANXfr?0mU=_iVO3;;ZuK+fYI8GXAu!!OSN!VbP3
zB%l9d4d!m|cA@YKYw1hyB!vb29Jpt9;1NWpxd8B61US@H*KF!P&X%@Z{C}3nYGf_4
zM!lLB5XOUKW^XpX