From d989615c3272b61dcc3fae2bf3397035caee499d Mon Sep 17 00:00:00 2001 From: Aleisha Date: Mon, 25 Apr 2016 23:08:49 +0000 Subject: [PATCH] Bug 15414: Silencing warns triggered by creating a new layout in patron card creator This patch assigns $field and $image values in the for loops To test: 1) Go to Tools -> Patron Card Creator -> New layout 2) Notice warns 3) Apply patch and refresh page 4) Notice warns are gone and page still works as expected Sponsored-by: Catalyst IT NOTE: Trivial initialization in a loop issue. Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall --- patroncards/edit-layout.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/patroncards/edit-layout.pl b/patroncards/edit-layout.pl index 9e663d3a9d..5d5d2dff8e 100755 --- a/patroncards/edit-layout.pl +++ b/patroncards/edit-layout.pl @@ -236,7 +236,7 @@ elsif ($op eq 'save') { elsif ($op eq 'new') { # this is a new layout $layout = C4::Patroncards::Layout->new(); my @fields = (); - for (my $field; $field < 4; $field++) { # limit 3 text fields + for (my $field = 0; $field < 4; $field++) { # limit 3 text fields push @fields, ( "field_$field" . "_font" => get_font_types(), "field_$field" . "_text_alignment" => get_text_justification_types(), @@ -244,7 +244,7 @@ elsif ($op eq 'new') { # this is a new layout } my @images = (); - for (my $image; $image < 3; $image++) { #limit 2 images + for (my $image = 0; $image < 3; $image++) { #limit 2 images push @images, ( "image_$image" . "_image_source" => $image_sources, "image_$image" . "_image_name" => $image_names, -- 2.39.5