From 218322597e7a7104a15229e333ae7c1a917a675c Mon Sep 17 00:00:00 2001 From: Didier Gautheron Date: Wed, 27 May 2020 04:18:58 +0200 Subject: [PATCH] Bug 25608: (bug 23463 follow-up) Fix inventory regression Follow-up work commit bbb504c86f5ca0a474365d4839177412f415c4ee Bug 23463: Replace ModItem with Koha::Item->store Test plan : - Create a biblio with default framework - Create an item with barcode='000AAA1', callnumber='ZZZAAA1' - Create an item with barcode='000AAA2', callnumber='ZZZAAA2' - Create a file 'barecodes.txt' containing 2 lines '000AAA1' and '000AAA2' - Go to inventory tool : /cgi-bin/koha/tools/inventory.pl - Choose file in 'Barcode file' - Enter item callnumber between 'ZZZ' and 'ZZZa' - Check 'Compare barcodes list to results' - Submit => without patch, you get an error trace - Apply patch, it works Signed-off-by: Jonathan Druart Amended commit title. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart --- tools/inventory.pl | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tools/inventory.pl b/tools/inventory.pl index 13c2f07e96..13b7a538a5 100755 --- a/tools/inventory.pl +++ b/tools/inventory.pl @@ -199,13 +199,10 @@ if ( $uploadbarcodes && length($uploadbarcodes) > 0 ) { } else { my $item = Koha::Items->find({barcode => $barcode}); if ( $item ) { - my $item_unblessed = $item->unblessed; # Modify date last seen for scanned items, remove lost status $item->set({ itemlost => 0, datelastseen => $date })->store; + my $item_unblessed = $item->unblessed; $moddatecount++; - # update item hash accordingly - $item_unblessed->{itemlost} = 0; - $item_unblessed->{datelastseen} = $date; unless ( $dont_checkin ) { $qonloan->execute($barcode); if ($qonloan->rows){ @@ -219,7 +216,7 @@ if ( $uploadbarcodes && length($uploadbarcodes) > 0 ) { } } } - push @scanned_items, $item; + push @scanned_items, $item_unblessed; } else { push @errorloop, { barcode => $barcode, ERR_BARCODE => 1 }; } -- 2.39.5