]> git.koha-community.org Git - koha.git/commit
Bug 24662: Remove global variables MSG_* from datatables.inc
authorJulian Maurice <julian.maurice@biblibre.com>
Fri, 14 Feb 2020 09:44:39 +0000 (10:44 +0100)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Wed, 11 Mar 2020 13:49:15 +0000 (13:49 +0000)
commit0c9b39a66dff00d2d76effc42824c2051484f9c5
treee62d9df235af0cb1dc12d3c801c7c33e09940b14
parentd28bf2de71edb2d895840619d0b70aadff43290a
Bug 24662: Remove global variables MSG_* from datatables.inc

Now that bug 21156 is pushed, we don't need to have global variables in
.inc or .tt files for translation in .js file. We can simply declare our
translatable strings where they are used.

This patch removes all global variables used in DataTables configuration

Test plan:
1. cd misc/translator && ./translate update fr-FR
2. Translate strings in misc/tranlator/po/fr-FR-messages-js.po
3. cd misc/translator && ./translate install fr-FR
4. Go to the staff interface, in english, and check that DataTables
tables are still working. You should check at least the following pages:
    - catalogue/detail.pl
    - circ/circulation.pl
    - tools/quotes.pl
    - tools/letter.pl
5. Switch to french and check again DataTables tables, and verify that
   strings are translated

This patch depends on bug 24661

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
koha-tmpl/intranet-tmpl/prog/en/modules/tools/quotes.tt
koha-tmpl/intranet-tmpl/prog/js/checkouts.js
koha-tmpl/intranet-tmpl/prog/js/datatables.js
koha-tmpl/intranet-tmpl/prog/js/letter.js
koha-tmpl/intranet-tmpl/prog/js/table_filters.js