]> git.koha-community.org Git - koha.git/commit
Bug 36018: biblio->active_orders should be ->uncancelled_orders
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 21 Feb 2024 14:39:00 +0000 (14:39 +0000)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Fri, 10 May 2024 14:45:46 +0000 (16:45 +0200)
commit21c87aeb15e6380d71b41f8c5e8ff28df74b3edd
treea680480b1c2398c3b7884d66e62c49428c711b2c
parentb7448dbd7531b24b7c54f254164881e144ce6b00
Bug 36018: biblio->active_orders should be ->uncancelled_orders

Active orders are more than just not cancelled. See filter_by_active
in Koha::Acquisition::Orders. They are still in the acq process; we
still need to receive items on those orders.

When we cancel and want to delete a biblio, we should check for not
cancelled orders (broader than active orders as in Orders.pm).

Test plan:
Git grep active_orders.
Run t/db_dependent/Koha/Biblio.t
Run t/db_dependent/Koha/Acquisition/Order.t
Add two order lines in a basket referring to same biblio. Try to
cancel with delete biblio. Should not be possible.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Janusz Kaczmarek <januszop@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Koha/Acquisition/Order.pm
Koha/Biblio.pm
acqui/basket.pl
api/v1/swagger/paths/acquisitions_orders.yaml
koha-tmpl/intranet-tmpl/prog/en/includes/catalog-strings.inc
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt
t/db_dependent/Koha/Acquisition/Order.t
t/db_dependent/Koha/Biblio.t