Bug 30865: Double-quote Host-item in Koha::Biblio->get_components_query
authorDavid Cook <dcook@prosentient.com.au>
Mon, 30 May 2022 03:31:44 +0000 (03:31 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Fri, 29 Jul 2022 17:23:01 +0000 (17:23 +0000)
commit2b4eb64563367d2fb0c51b244d0f9a936c4b49ba
treefb12c15f02b1ce1e58bf2b0f8ac9e636171c617f
parent248dc2787eaa496dfd1c0984fab49d8d76efc6fd
Bug 30865: Double-quote Host-item in Koha::Biblio->get_components_query

This patch adds double quotes around the term qualified by "Host-item"
in Koha::Biblio->get_components_query().

Without them, reserved charactrs like "=" will cause syntax errors like
"CCL parsing error (10014) Unknown qualifier ZOOM for query:
    Host-item=(MyTitle = Mysubtitle)
    at /usr/share/koha/lib/C4/Search.pm line 245."

Test plan:
0) Don't apply the patch
1) Create biblio with title and subtitle like (MyTitle : MySubtitle)
2) Note the warning "There was an error searching for analytic records,
   please see the logs for details." on the detail page
3) Apply the patch
4) koha-plack --restart kohadev
5) Refresh the detail page
6) Note that the warning message is gone
7) prove t/db_dependent/Koha/Biblio.t

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit fd385d90b8063d5cbdb0e5d1cf76e99b9c58cc84)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Koha/Biblio.pm
t/db_dependent/Koha/Biblio.t