]> git.koha-community.org Git - koha.git/commit
Bug 11445: regression test for duplicate hold notifications
authorGalen Charlton <gmc@esilibrary.com>
Wed, 25 Dec 2013 17:38:39 +0000 (17:38 +0000)
committerGalen Charlton <gmc@esilibrary.com>
Mon, 30 Dec 2013 15:10:17 +0000 (15:10 +0000)
commit2b6a20c509801b9eeb562aa6fd404546d6ba84df
tree9a1f84beeb0a1ff5e490491b204f6e26b2d1641e
parente8808dfd527b2b461485507fe508928bb84b7f82
Bug 11445: regression test for duplicate hold notifications

This patch implements a regression test for verifying that
duplicate hold notifications aren't sent if ModReserveAffect() is
called repeatedly (as might happen if a circ operator accidentally
checks in an item and confirms its hold more than once).

Note that the test depends on the fact that _koha_notify_reserve()
defaults to sending a HOLD_PRINT letter if the borrower has not
specified an email or SMS hold notification.

To test:

[1] Run prove -v t/db_dependent/Reserves.t
[2] The 'patron not notified a second time (bug 11445)' test
    should fail.
[3] Apply the main patch and run prove -v t/db_dependent/Reserves.t
    again.  This time all tests should pass.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
t/db_dependent/Reserves.t