Bug 35507: Plugins.t - Mock SessionStorage, remove KitchenSink
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tue, 12 Dec 2023 14:07:49 +0000 (14:07 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Wed, 14 Feb 2024 16:29:01 +0000 (16:29 +0000)
commit313f50854490beefdacc7034297d303ea4356dd2
tree2f9b9c6705ae33177e19c533b912134bd2eb89d3
parentc81e5dc0ba017ad85c417360a372e8df920d5ff3
Bug 35507: Plugins.t - Mock SessionStorage, remove KitchenSink

Removing the CGI::Session behavior to auto-commit by mocking
SessionStorage makes that the $plugin->test_template does no
longer commit.

Since KitchenSink includes a CREATE TABLE, removing that code
removes the second implicit commit. We might move that code
to its own script?

Adds a missing rollback too at the end.

Test plan:
Run prove t/db_dependent/Koha/Plugins/Plugins.t
Verify that no records got added to plugin_data/methods table.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit dc62d9bed5799b9583bbc1ed59ea37972d7fe472)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit bfb2a929e30e30e7bf490364fc216ca69c966e62)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
t/db_dependent/Koha/Plugins/Plugins.t