]> git.koha-community.org Git - koha.git/commit
Bug 17668: Fix typo in parcel.pl - listinct vs listincgst
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 22 Nov 2016 15:28:04 +0000 (15:28 +0000)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 9 Dec 2016 16:23:34 +0000 (16:23 +0000)
commit3e112f3837346b500ce863a248920d3207e27131
tree79314cf2374769a2ee0f7464051a6b14dac1da9c
parent167c74bfd386287783e101989b804077b1020369
Bug 17668: Fix typo in parcel.pl - listinct vs listincgst

This typo has been introduced by
  commit eed14b080db8691f371b4c19f1a190b87fcc396a
    Bug 13001: Refactor VAT and price calculation - parcel page
So before the tax rewrite (13321, 13323).
It sounded weird to me that testers did not catch the bug on this page.

To understand the logic:
Conditions are listincgst, invoiceincgst
Conditions | Before this patch |  If we fix the typo  | After this patch
 0     0   |    excluded       |    excluded          |   excluded
 0     1   |    included       |    included          |   included
 1     0   |    excluded       |    excluded          |   excluded
 1     1   |    included       |    included          |   included

Test plan:
Create 4 vendors with the difference combinations
Create a basket, add an order (with a tax) and receive it
Confirm that the different values displayed on the parcel page are correct

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
acqui/parcel.pl