]> git.koha-community.org Git - koha.git/commit
Bug 24964: [19.11.x] Do not fetch all patrons for owner/users of funds
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 6 Apr 2020 09:44:18 +0000 (11:44 +0200)
committerLucas Gass <lucas@bywatersolutions.com>
Mon, 11 May 2020 21:00:36 +0000 (21:00 +0000)
commit47d1ee26667c4003d8ae1a2b1ad9d2e38064a6e5
treeda699eee0e826179989809f98f17cf7b3cb6d823
parentdbd9d8a6b6a17400aa14323cd350131e2ae7b229
Bug 24964: [19.11.x] Do not fetch all patrons for owner/users of funds

admin/add_user_search.pl sets 'patrons_with_acq_perm_only', to only
retrieve patrons with acq (order_manage) permissions.

The original bug was hidden in the existing code, but the behavior was
terrible.
To prevent patrons matching the permissions contrainst to be hidden, we
fetched ALL the patrons from the DB, then filtered them depending on
their permissions. This might have awful performance on DB with lot of
patrons.

So basically with this patch we are adding the pagination back to the
"owner/users for funds" feature, as the permission filtering is now done
at DB level.

Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
(cherry picked from commit 300dbea81219245614d95599c7cd98c51a005242)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt