]> git.koha-community.org Git - koha.git/commit
Bug 31540: Exclude expired holds from the reminder job
authorNick Clemens <nick@bywatersolutions.com>
Mon, 12 Sep 2022 14:35:24 +0000 (14:35 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Mon, 3 Oct 2022 11:39:06 +0000 (08:39 -0300)
commit4c3d18091d821af2d9ac7a6178547cc9c478f9de
tree2f3fc00259826e7a369d2a96a20282a2d15d4cfc
parent90c675bae9cd760d85453921b8b15f3a27ac7cf9
Bug 31540: Exclude expired holds from the reminder job

Some libraries don't want to auto-cancel holds, but we should not remind
a patron about a hold which has expired.

To test:
1 - Place a hold for a patron
2 - Set it waiting
3 - Run the holds reminder script in the future
    perl misc/cronjobs/holds/holds_reminder.pl -day 1 --date '2023-09-12' -v
4 - Note the holds would be reminded
5 - Set expirationdate for the hold less than today
    UPDATE reserves SET expirationdate = DATE_SUB(CURDATE(), INTERVAL 1 DAY);
6 - Run the remidner cron again
7 - No holds trigger!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
misc/cronjobs/holds/holds_reminder.pl