]> git.koha-community.org Git - koha.git/commit
Bug 16944: Add "email" and "url" classes when edit or create a vendor
authorHector Castro <hector.hecaxmmx@gmail.com>
Tue, 19 Jul 2016 20:58:58 +0000 (14:58 -0600)
committerKyle M Hall <kyle@bywatersolutions.com>
Wed, 10 Aug 2016 14:18:34 +0000 (14:18 +0000)
commit71d20a8c3b48a4dd1c7fb569b3baf2352d9757ac
tree9cc38168353f13f607b4cb482787687586d2474b
parent865557e05c0fa1951478fbc1551c50b9b928619a
Bug 16944: Add "email" and "url" classes when edit or create a vendor

When edit or create a new vendor the two fields "email" and "website" don't test
if the data provided is right. When you add a direction like
"koha-community.org" without the protocol "https" the program redirect to an
404 error.

To reproduce the issue:
1-Go to Acquisition and create a new Vendor
2-Fill the field Website with koha-community.org
3-Use an email without at sing (@)
4-Notice that there is no error
5-Save
6-Go to the vendor created (/cgi-bin/koha/acqui/supplier.pl?booksellerid=1)
7-Click in Website: koha-community.org -> redirect to an 404 error
8-Notice the bad mailto:

To test:
-Apply patch
-Reproduce step 1 to 8 with the same vendor or create a new one
-Enter multiple wrong and valid urls
-Enter urls with and without protocols http, https, ftp
-Enter wrong and valid emails

NOTE: The classes used are taken from 'branches.tt'
Signed-off-by: Liz Rea <liz@catalyst.net.nz>
no longer allows entering of improper website urls or incomplete email addresses.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt