]> git.koha-community.org Git - koha.git/commit
Bug 15746: Do not record individual payments with randomly picked libraries
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 5 Feb 2016 10:46:28 +0000 (10:46 +0000)
committerBrendan Gallagher <brendan@bywatersolutions.com>
Tue, 23 Feb 2016 21:15:21 +0000 (21:15 +0000)
commit80a690588ceac464891dcb2956c3b148433a253c
treee5d6f1e40a9a6f4f6366d5e550d82772735dded5
parent1cb371689da5192caa529149a39c7a4389f056e4
Bug 15746: Do not record individual payments with randomly picked libraries

When a payment is made individualy, the library used to record this
payment is randomly picked from the library list.
This is because C4::Branch::GetBranch looks at 1. the $branch variable
sent by the template, wich does not exist, then 2. the branchname
cookie, which does not exist neither, then 3. get the first branchcode
from a list of keys (non ordered).

To reproduce:
- Create a manual invoice for a patron
(members/maninvoice.pl?borrowernumber=XXXX)
- Pay this fine using the "Pay" button of the corresponding line from
  the members/pay.pl?borrowernumber=XXXX page
Look at the statistics table:
select * from statistics order by datetime desc limit 10;

The branch value of the first line might not correspond to the library
you were using to pay the payment.

Test plan:
Apply this patch, repeat the steps above and confirm that the library
picked is now the one used to pay.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
members/paycollect.pl