Bug 26618: Remove use of transferbook in RotatingCollections
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 18 Dec 2020 16:37:29 +0000 (16:37 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 3 Mar 2021 14:36:13 +0000 (15:36 +0100)
commit87c3911bb8352b7e678c22ce7630c1a76c8c6b15
tree2b931be772910b03b8f153b327aa1bca0cbd912a
parent80e3bfd3763056b74e64c8ea628d7d201592cf52
Bug 26618: Remove use of transferbook in RotatingCollections

This patch replaces the use of C4::Circulation::transferbook in
C4::RotatingCollections with calls to Koha::Item->request_transfer and
adds handling for the various failure cases which that can throw.

We also introduce additional feedback for the end user where it did not
exist before. Now we notify the user if some of the collection could not
be transfers or if transfers were queued rather than set to request
immediately.

Test plan
1/ Set up a rotating collection
2/ Transfer the collection
3/ Confirm the action succeeds
4/ Set up some branch transfer limits that will affect items in your
collection
5/ Transfer the collection
6/ Note that the transfer succeeds but some items are returned as
failures

Signed-off-by: Kathleen Milne <kathleen.milne@cne-siar.gov.uk>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/RotatingCollections.pm
koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/transferCollection.tt
rotating_collections/transferCollection.pl